Skip to content

Fix Web - User can't navigate through the autocomplete suggestion list using the keyboard #79684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valforte merged 3 commits into from
Jan 27, 2026
+9 −2
Merged

Fix Web - User can't navigate through the autocomplete suggestion list using the keyboard #79684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40a78dc
fix: init fix
annaweber830 Jan 15, 2026
acd9590
fix: prettier
annaweber830 Jan 15, 2026
a31422e
Merge branch 'main' of https://github.com/annaweber830/App into fix-7…
annaweber830 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Search/SearchList/BaseSearchList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ function BaseSearchList({
},
...(!hasKeyBeenPressed.current && {setHasKeyBeenPressed}),
isFocused,
captureOnInputs: false,
Copy link
Contributor

@truph01 truph01 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annaweber830 I encountered no issues when removing this line.

Could you provide a case where removing it could cause problems?

Copy link
Contributor Author

@annaweber830 annaweber830 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry If I removed this line, it doesn't work correctly.

Screen.Recording.2026-01-20.at.2.44.34.AM.mov

});

const renderItemWithKeyboardFocus = useCallback(
Expand Down
2 changes: 2 additions & 0 deletions src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
reports={reports}
allCards={allCards}
allFeeds={allFeeds}
textInputRef={textInputRef}
/>
</View>
)}
Expand Down Expand Up @@ -476,6 +477,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
reports={reports}
allCards={allCards}
allFeeds={allFeeds}
textInputRef={textInputRef}
/>
</View>
)}
Expand Down
8 changes: 6 additions & 2 deletions src/hooks/useArrowKeyFocusManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ type Config = {
onFocusedIndexChange?: (index: number) => void;
initialFocusedIndex?: number;
disabledIndexes?: readonly number[];
captureOnInputs?: boolean;
shouldExcludeTextAreaNodes?: boolean;
isActive?: boolean;
itemsPerRow?: number;
Expand Down Expand Up @@ -46,6 +47,7 @@ export default function useArrowKeyFocusManager({
// The "disabledIndexes" array needs to be stable to prevent the "useCallback" hook from being recreated unnecessarily.
// Hence the use of CONST.EMPTY_ARRAY.
disabledIndexes = CONST.EMPTY_ARRAY,
captureOnInputs = true,
shouldExcludeTextAreaNodes = true,
isActive,
itemsPerRow,
Expand All @@ -63,16 +65,18 @@ export default function useArrowKeyFocusManager({
() => ({
excludedNodes: shouldExcludeTextAreaNodes ? ['TEXTAREA'] : [],
isActive,
captureOnInputs,
}),
[isActive, shouldExcludeTextAreaNodes],
[captureOnInputs, isActive, shouldExcludeTextAreaNodes],
);

const horizontalArrowConfig = useMemo(
() => ({
excludedNodes: shouldExcludeTextAreaNodes ? ['TEXTAREA'] : [],
isActive: isActive && allowHorizontalArrowKeys,
captureOnInputs,
}),
[isActive, shouldExcludeTextAreaNodes, allowHorizontalArrowKeys],
[allowHorizontalArrowKeys, captureOnInputs, isActive, shouldExcludeTextAreaNodes],
);

useEffect(() => {
Expand Down
Loading