Skip to content

Remove stale LOOKING_AROUND onboarding message#79728

Merged
inimaga merged 5 commits intomainfrom
fix/588910-update-concierge-messaging
Mar 6, 2026
Merged

Remove stale LOOKING_AROUND onboarding message#79728
inimaga merged 5 commits intomainfrom
fix/588910-update-concierge-messaging

Conversation

@marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Jan 15, 2026

Explanation of Change

This PR narrows the scope of #588910 to only clean up the LOOKING_AROUND onboarding intent. The askConcierge and conciergeSupport copy updates were already shipped via PRs #81331 and #81774, so this PR no longer touches those strings.

Problem: When a user selects "Looking around" during onboarding, Concierge sends a stale support-era message: "Expensify is best known for expenses, travel, and corporate card management..." This conflicts with the new AI-focused welcome message already shipped on the backend.

Fix:

  • Remove onboardingLookingAroundMessage from all 10 language files (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans)
  • Set message: '' for the LOOKING_AROUND intent in OnboardingFlow.ts
  • Add && message guard to guidedSetupData, optimisticData, successData, and failureData to prevent creating empty comment actions — without this, an empty optimistic message bubble appears in the Concierge chat
  • Add skipSignOff logic so the "It's great to meet you!" sign-off is suppressed for LOOKING_AROUND
  • Add unit tests for LOOKING_AROUND onboarding behavior

Onboarding intent scenarios (side-by-side):

Intent Welcome Message Tasks Sign-off
Employer / Submit "Getting paid back is as easy as sending a message. Let's go over the basics." Test drive, Submit expense "It's great to meet you!"
Personal Spend "Here's how to track your spend in a few clicks." Test drive, Track expense "It's great to meet you!"
Chat & Split "Splitting bills with friends is as easy as sending a message. Here's how." Test drive, Start chat, Split expense "It's great to meet you!"
Admin "Learn how to manage your team's workspace as an admin and submit your own expenses." Review workspace settings, Submit expense "It's great to meet you!"
Manage Team Long specialist onboarding message 9 workspace setup tasks "Once you finish the tasks above, we can explore more functionality..."
Track Workspace Long specialist onboarding message 6 workspace setup tasks "It's great to meet you!"
Test Drive Receiver "*You've got 3 months free! Get started below.*" Test drive admin, Create workspace "It's great to meet you!"
Looking Around (this PR) (none, backend welcome only) (none) (none)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/588910

Tests

  1. Create a brand new user account
  2. During onboarding, select "Looking around"
  3. Open the Concierge DM
  4. Verify: No stale "Expensify is best known for..." message appears
  5. Verify: Only the backend welcome message is shown
  6. Verify: No "It's great to meet you!" sign-off appears
  7. Create another new user, select a different intent (e.g. "Personal Spend")
  8. Verify: The welcome message and sign-off still appear as expected
  • Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior changes. The onboarding message is constructed at onboarding time, not fetched from network.

QA Steps

  1. Create a new user account (do not use an existing account)
  2. During onboarding, select "Looking around"
  3. Open the Concierge DM
  4. Verify only the backend welcome message appears (no stale copy)
  5. Test with other intents (Employer, Personal Spend, etc.) to verify they still show their messages + sign-off
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Static text removal only - no visual changes beyond message absence

Android: mWeb Chrome

Static text removal only - no visual changes beyond message absence

iOS: Native

Static text removal only - no visual changes beyond message absence

iOS: mWeb Safari

Static text removal only - no visual changes beyond message absence

MacOS: Chrome / Safari

Static text removal only - no visual changes beyond message absence

@marcochavezf marcochavezf requested review from a team as code owners January 15, 2026 20:59
@melvin-bot melvin-bot bot requested review from heyjennahay and linhvovan29546 and removed request for a team and heyjennahay January 15, 2026 20:59
@melvin-bot
Copy link

melvin-bot bot commented Jan 15, 2026

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezf marcochavezf changed the title Update Concierge messaging to be more AI-focused [WIP] Update Concierge messaging to be more AI-focused Jan 15, 2026
@codecov

This comment was marked as outdated.

@marcochavezf marcochavezf force-pushed the fix/588910-update-concierge-messaging branch from a051d67 to cc09ce3 Compare January 16, 2026 03:45
@marcochavezf marcochavezf changed the title [WIP] Update Concierge messaging to be more AI-focused [HOLD] Update Concierge messaging to be more AI-focused Jan 16, 2026
@OSBotify
Copy link
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (143KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw eb5533466e1e27371b968517c9eddf06 | git apply 😉

@marcochavezf marcochavezf force-pushed the fix/588910-update-concierge-messaging branch from f65d21e to 21b9c3b Compare January 27, 2026 21:46
@marcochavezf marcochavezf changed the title [HOLD] Update Concierge messaging to be more AI-focused Update Concierge messaging to be more AI-focused Feb 5, 2026
@marcochavezf
Copy link
Contributor Author

Ok, this can be reviewed (header) and merged while the backend PR is reviewed (welcome message).

These are the messages with the updated copy (cc @jamesdeanexpensify @danielrvidal). Since we’re still showing onboarding tasks for other intents, I left the copy for those messages unchanged. I only removed the extra messages for the “look around” intent, where we don’t create onboarding tasks.

Screenshot 2026-02-05 at 3 51 13 p m Screenshot 2026-02-05 at 3 53 03 p m Screenshot 2026-02-05 at 4 01 53 p m

@jamesdeanexpensify
Copy link
Contributor

Quick question - aren't we moving to a world where the Concierge welcome message varies based on intent + gives you three clickable options? Or is that what the message after this welcome message will be? Just making sure!

@marcochavezf
Copy link
Contributor Author

Quick question - aren't we moving to a world where the Concierge welcome message varies based on intent + gives you three clickable options? Or is that what the message after this welcome message will be? Just making sure!

Yes, but that's only for admins in the #admins room, we're depending on making Concierge responses faster, because sometimes the bespoke welcome message (based on the intent + onboarding selected options) takes minutes to be generated

@linhvovan29546
Copy link
Contributor

linhvovan29546 commented Feb 9, 2026

@marcochavezf I see that this change only affects the newDotLookingAround and other introSelected, so I think we should update the tests to match these change

@linhvovan29546
Copy link
Contributor

I think we should add a unit test as well.

Copy link
Contributor

@linhvovan29546 linhvovan29546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at this comment: #79728 (comment)? We need to use the translated text from there. And it looks outdated could you please run the tool again and apply the fix?

usePlusButton: ({additionalText}: UsePlusButtonParams) => ` Use the + button to ${additionalText} an expense.`,
askConcierge: ' Ask me anything!',
conciergeSupport: 'Your personal AI agent',
askConcierge: ' Your 24/7 AI expense assistant is here to help.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we should add a leading space here, since it causes the Polyglot Parrot! tool to always produce diffs during auto-translation. Instead, we should manually add the leading space in the getWelcomeMessage function:

messageHtml += ` ${translate('reportActionsView.askConcierge')}`;

@jamesdeanexpensify
Copy link
Contributor

@marcochavezf from this comment, the welcome message copy in the first two screenshots doesn't flow well into the rest of the copy. I'm trying to think of something that works better.

Maybe we can take a cue from these: Since we’re still showing onboarding tasks for other intents, I left the copy for those messages unchanged. What do those look like? Thank you!

@marcochavezf
Copy link
Contributor Author

@MelvinBot please address the feedback from @jamesdeanexpensify above. Specifically, James noted that the welcome message copy in the first two screenshots (for intents other than "look around") doesn't flow well into the rest of the onboarding copy that follows. He's asking to see what the unchanged welcome messages look like for those other intents, so we can figure out copy that transitions better into the onboarding tasks. Please share the current (unchanged) welcome message copy for the non-"look around" intents, and propose updated copy that flows more naturally into the subsequent onboarding task messages.

@MelvinBot
Copy link
Contributor

@jamesdeanexpensify @marcochavezf — Here's a breakdown of the current (unchanged) welcome messages for each non-"look around" intent, followed by copy suggestions.

Current (Unchanged) Welcome Messages by Intent

These are the messages that appear as the first Concierge message in the chat, before the onboarding tasks are listed:

Intent Welcome Message Tasks That Follow
Employer (newDotEmployer) "Getting paid back is as easy as sending a message. Let's go over the basics." Test drive, Submit expense
Submit (newDotSubmit) "Getting paid back is as easy as sending a message. Let's go over the basics." Test drive, Submit expense
Personal Spend (newDotPersonalSpend) "Here's how to track your spend in a few clicks." Test drive, Track expense
Chat & Split (newDotSplitChat) "Splitting bills with friends is as easy as sending a message. Here's how." Test drive, Start chat, Split expense
Admin (newDotAdmin) "Learn how to manage your team's workspace as an admin and submit your own expenses." Review workspace settings, Submit expense
Manage Team (newDotManageTeam) "# Your free trial has started! Let's get you set up.\n👋 Hey there, I'm your Expensify setup specialist..." (long onboarding message) 9 workspace setup tasks
Track Workspace (newDotTrackWorkspace) "# Let's get you set up\n👋 Hey there, I'm your Expensify setup specialist..." (long onboarding message) 6 workspace setup tasks
Test Drive Receiver (testDriveReceiver) "*You've got 3 months free! Get started below.*" Test drive admin, Create workspace

After all the tasks, a sign-off message appears:

  • For Manage Team: "Once you finish the tasks above, we can explore more functionality like approval workflows and rules!"
  • For all others: "It's great to meet you!"

The Flow Problem

In this PR, the new header subtext (askConcierge) is: "Your 24/7 AI expense assistant is here to help."

The first two screenshots show intents like Employer/Submit and Personal Spend. The chat flow reads:

Header: "Your 24/7 AI expense assistant is here to help."
Welcome message: "Getting paid back is as easy as sending a message. Let's go over the basics."
[Tasks follow]
Sign-off: "It's great to meet you!"

The disconnect James is noting: the header says "AI expense assistant is here to help" but the welcome message immediately jumps into a specific how-to without acknowledging the AI assistant framing.

Proposed Updated Copy

Here are suggestions that bridge the AI assistant header into the task-based onboarding, organized by intent:

Employer / Submit:

Current: "Getting paid back is as easy as sending a message. Let's go over the basics."

Option A: "I can help you get paid back quickly — it's as easy as sending a message. Let's go over the basics."

Option B: "Let me show you how easy it is to get paid back. Here are a few things to get you started."

Personal Spend:

Current: "Here's how to track your spend in a few clicks."

Option A: "I can help you stay on top of your spending. Here's how to track it in a few clicks."

Option B: "Let me help you track your spend — it only takes a few clicks to get started."

Chat & Split:

Current: "Splitting bills with friends is as easy as sending a message. Here's how."

Option A: "I can help you split bills with friends — it's as easy as sending a message. Here's how."

Option B: "Need to split a bill? I'll walk you through it — it's as easy as sending a message."

Admin:

Current: "Learn how to manage your team's workspace as an admin and submit your own expenses."

Option A: "I'll help you manage your team's workspace and submit your own expenses. Here's how to get started."

Option B: "Let me walk you through managing your team's workspace as an admin and submitting your own expenses."

Test Drive Receiver:

Current: "*You've got 3 months free! Get started below.*"

Suggestion: "*You've got 3 months free! Let me help you get started.*"

The Manage Team and Track Workspace intents already have their own long-form specialist messages ("Hey there, I'm your Expensify setup specialist..."), which have a different tone and likely don't need changes for this PR.

Let me know which direction works best and I can help update the copy!

@marcochavezf
Copy link
Contributor Author

@MelvinBot great analysis! The copy suggestions look good. Let's go with Option A for each intent — they feel more natural and maintain a consistent "I can help you..." voice that connects well with the "AI expense assistant" header.

To summarize the chosen copy:

  • Employer / Submit: "I can help you get paid back quickly — it's as easy as sending a message. Let's go over the basics."
  • Personal Spend: "I can help you stay on top of your spending. Here's how to track it in a few clicks."
  • Chat & Split: "I can help you split bills with friends — it's as easy as sending a message. Here's how."
  • Admin: "I'll help you manage your team's workspace and submit your own expenses. Here's how to get started."
  • Test Drive Receiver: "You've got 3 months free! Let me help you get started."

Please push a commit to this PR with these welcome message copy updates. The Manage Team and Track Workspace intents can stay as-is since they already have their own specialist framing.

@jamesdeanexpensify — does this direction work for you? Happy to adjust if you'd prefer Option B or a different approach for any of these.

🤖 This comment was generated with the assistance of an AI tool.

@MelvinBot
Copy link
Contributor

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/21842977704

@marcochavezf
Copy link
Contributor Author

@MelvinBot Please rebase this PR onto main to resolve the merge conflicts in the 10 language files (de, en, es, fr, it, ja, nl, pl, pt-BR, zh-hans). Keep the PR branch wording for the askConcierge and conciergeSupport strings.

🤖 This comment was generated with the assistance of an AI tool.

@MelvinBot MelvinBot force-pushed the fix/588910-update-concierge-messaging branch from 1cc5337 to f7196f0 Compare February 10, 2026 22:00
@MelvinBot
Copy link
Contributor

Rebased this PR onto latest main and resolved the merge conflicts. The branch now has a clean single commit on top of main.

What was done:

  • Created a fresh branch from current main and re-applied all PR changes
  • Kept the PR branch wording for askConcierge and conciergeSupport strings across all 10 language files (the "24/7 AI expense assistant" wording)
  • Removed onboardingLookingAroundMessage from all language files
  • Preserved the ReportUtils.ts changes (skipSignOff logic, message guard)
  • Preserved the OnboardingFlow.ts change (empty message for LOOKING_AROUND)
  • Applied the zh-hans.ts onboardingTestDriveReceiverMessage tweak (下面 → 下方)

The PR is now mergeable with no conflicts.

@marcochavezf marcochavezf changed the title Update Concierge messaging to be more AI-focused Remove stale LOOKING_AROUND onboarding message Mar 2, 2026
@linhvovan29546
Copy link
Contributor

@codex @MelvinBot review

@MelvinBot
Copy link
Contributor

🔍 PR Review

Summary

This PR removes the stale LOOKING_AROUND onboarding message by: removing onboardingLookingAroundMessage from all 10 language files, setting message: '' for the LOOKING_AROUND intent, adding a && message guard to guidedSetupData, adding skipSignOff logic, and adding unit tests. The scope is clean and focused.

Failing CI Check

test (job 2) is failing — the test should not include sign-off message for LOOKING_AROUND intent at tests/unit/ReportUtilsTest.ts:715 fails with:

Expected length: 0
Received length: 1
Received array:  ["reportActions_5"]

Root cause: There is an inconsistency between the optimisticData and guidedSetupData guards for empty messages:

  • At ReportUtils.ts:11965, guidedSetupData correctly guards against empty messages:

    if (!shouldUseFollowupsInsteadOfTasks && message) {
  • At ReportUtils.ts:11831, optimisticData does not have the same guard — it only checks:

    if (!shouldUseFollowupsInsteadOfTasks) {

So the textCommentAction (the main onboarding message) is still pushed to optimisticData even when message is ''. The test expects zero reportActions_5 entries, but there is one (the empty-message text comment action — not the sign-off, which IS correctly suppressed).

Suggested fix: Add the && message guard to the optimisticData push as well to align both code paths:

- if (!shouldUseFollowupsInsteadOfTasks) {
+ if (!shouldUseFollowupsInsteadOfTasks && message) {

This would prevent pushing an empty-message report action into optimistic data, which is consistent with not including it in guidedSetupData.

Code Review

Area Status Notes
Language file removals (10 files) Complete and consistent across all locales
OnboardingFlow.ts — empty message Clean change, message: '' for LOOKING_AROUND
ReportUtils.tsskipSignOff logic Correctly combines existing and new conditions
ReportUtils.tsguidedSetupData guard && message prevents empty messages in guided setup
ReportUtils.tsoptimisticData guard ⚠️ Missing && message guard (causes test failure)
Unit tests ⚠️ Logic is correct but one test fails due to the missing guard above

Unresolved Discussion

There was a discussion thread with jamesdeanexpensify about updating welcome message copy for other intents to flow better with the new header subtext. jamesdeanexpensify's last comment asked to see the different scenarios together and noted that em dashes should be avoided. This hasn't been resolved yet. However, since this PR was narrowed to only handle the LOOKING_AROUND intent cleanup (the copy updates for other intents seem like a separate concern), this may not block this PR.

Bottom Line

The functional logic is sound. The one fix needed is adding && message to the optimisticData guard at line 11831 of ReportUtils.ts to match the guidedSetupData guard — this will fix the failing test and also prevent pushing unnecessary empty-message report actions to optimistic data.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13b8b207f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@linhvovan29546
Copy link
Contributor

@marcochavezf I agree with the suggestions from Melvin and Codex. Without those changes, we optimistically display an empty message, see the attached below.

Screen.Recording.2026-03-04.at.15.30.17.mov

marcochavezf and others added 3 commits March 4, 2026 16:30
The LOOKING_AROUND intent still sent a support-era message about expenses,
travel, and corporate card management, which conflicts with the new AI-focused
Concierge welcome shipped in PRs #81331/#81774. This narrows the PR scope to
only the LOOKING_AROUND cleanup:

- Remove onboardingLookingAroundMessage from all 10 language files
- Set message to empty string for LOOKING_AROUND in OnboardingFlow.ts
- Add message guard to prevent pushing empty messages to guidedSetupData
- Add skipSignOff logic to suppress "It's great to meet you!" for LOOKING_AROUND
- Add unit tests for LOOKING_AROUND onboarding behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Simplify the sign-off suppression test to avoid unsafe-return and
unsafe-member-access lint errors by checking guidedSetupData length
and optimistic data keys instead of inspecting untyped action values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…OOKING_AROUND

When LOOKING_AROUND is selected and the message is empty, prepareOnboardingOnyxData
was still creating a textCommentAction entry in optimisticData, successData, and
failureData. This created a local-only empty comment action that the backend never
receives. Guard all three data arrays with the same `message` check already used for
guidedSetupData.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@marcochavezf marcochavezf force-pushed the fix/588910-update-concierge-messaging branch from 13b8b20 to 3e58e6b Compare March 4, 2026 22:44
@marcochavezf
Copy link
Contributor Author

Thanks @linhvovan29546, the suggested changes were applied to remove the empty bubble due to the empty message. Ready for review!

@linhvovan29546
Copy link
Contributor

linhvovan29546 commented Mar 4, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-05.at.06.54.35.mov
Android: mWeb Chrome
Screen.Recording.2026-03-05.at.06.55.31.mov
iOS: HybridApp
Screen.Recording.2026-03-05.at.06.52.59.mov
iOS: mWeb Safari
Screen.Recording.2026-03-05.at.06.51.20.mov
MacOS: Chrome / Safari Screenshot 2026-03-05 at 07 35 23

marcochavezf and others added 2 commits March 5, 2026 16:44
…sage

When skipSignOff is true and there is no message (e.g., LOOKING_AROUND
onboarding choice), we already skip the optimistic message action. This
change also skips setting lastVisibleActionCreated in that case, so the
"new message" indicator displays correctly during offline onboarding.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@melvin-bot melvin-bot bot requested a review from inimaga March 6, 2026 00:32
@melvin-bot
Copy link

melvin-bot bot commented Mar 6, 2026

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Mar 6, 2026

🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #84345.

@inimaga inimaga merged commit 1d7120a into main Mar 6, 2026
37 of 39 checks passed
@inimaga inimaga deleted the fix/588910-update-concierge-messaging branch March 6, 2026 11:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Mar 9, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants