[CP Staging] Restore default attendee tracking flag for legacy policies by francoisl · Pull Request #79730 · Expensify/App

francoisl · 2026-01-15T23:12:34Z

Explanation of Change

Restore the default value for the attendee tracking enabled flag for legacy policies that was changed in https://github.com/Expensify/App/pull/79050/changes#diff-e0bbc1d7016fc365a636f5e1d9928913f99dc8a5e532727c6ebb9c2bbd1181bb. Legacy policies don't have isAttendeeTrackingEnabled, since we always showed the Attendees field by default.

Fixed Issues

$ #79710

Attendee selector not being visible on legacy policies

Tests

Create a new policy, enable "Rules"
Manually delete the isAttendeeTrackingEnabled value from the policy in your local dev database, e.g.:

update nameValuePairs set value = json_remove(value, '$.isAttendeeTrackingEnabled') where name = 'expensify_policyXXXX';

Create a new expense
Make sure the Attendees selector is visible
Go to the policy settings, disable Attendee tracking
Create another expense
Verify that the attendee selector is not visible

Verify that no errors appear in the JS console

QA Steps

I'll do the QA, this requires testing on a legacy policy that doesn't have the isAttendeeTrackingEnabled attribute. The internal Expensify policy 137DA25D273F2423 will work for this

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

codecov · 2026-01-15T23:22:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/TransactionUtils/index.ts	`72.83% <100.00%> (ø)`
... and 9 files with indirect coverage changes

melvin-bot · 2026-01-15T23:24:19Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2026-01-15T23:26:17Z

@francoisl manually delete what?
Manually delete the '' value from the policy

Julesssss · 2026-01-15T23:27:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

francoisl · 2026-01-15T23:28:15Z

Manually delete the '' value from the policy

updated

ikevin127 · 2026-01-15T23:28:40Z

@francoisl 🔴 What about this issue if we fallback to true ? Here's what I found.

☝️ These two should be handled by BE, as the FE fallback doesn't mean that we're toggling the switch ON - it's just a visual switch-ON fallback that IMO doesn't make any sense - not sure why this was added in the first place.

francoisl · 2026-01-15T23:37:18Z

Hmm let me test, but doesn't your previous PR #79620 prevent this issue?

I agree that there might be some changes we can do in the backend though I'm out of the loop on those recent changes regarding the ability to require attendees.

francoisl · 2026-01-15T23:42:15Z

For the issues from this comment:

Issue 1:

Created a new user and set up a workspace with Rules enabled during onboarding.

Initially, Attendee tracking is enabled by default under Rules.

With this change attendee tracking is disabled (as expected)

Issue 2:

Enabled Description and Attendees for the xyz category.

Attendees can't be required (I'm assuming from your previous PR) so 👍

So I think we're good there.

[CP Staging] Restore default attendee tracking flag for legacy policies (cherry picked from commit f2ffc1a) (cherry-picked to staging by francoisl)

OSBotify · 2026-01-16T00:02:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-16T00:26:29Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.3-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:18:14Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:38:14Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.4-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-20T17:11:31Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.4-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Restore default attendee tracking flag for legacy policies

156d81d

melvin-bot bot assigned francoisl Jan 15, 2026

francoisl mentioned this pull request Jan 15, 2026

feat: add ability to require attendees based on category selection (rework) #79050

Merged

53 tasks

francoisl marked this pull request as ready for review January 15, 2026 23:24

francoisl requested review from a team as code owners January 15, 2026 23:24

melvin-bot bot requested review from ZhenjaHorbach and heyjennahay January 15, 2026 23:24

melvin-bot bot removed request for a team January 15, 2026 23:24

francoisl requested review from Julesssss and removed request for ZhenjaHorbach January 15, 2026 23:24

Julesssss approved these changes Jan 15, 2026

View reviewed changes

francoisl changed the title ~~Restore default attendee tracking flag for legacy policies~~ [CP Staging] Restore default attendee tracking flag for legacy policies Jan 15, 2026

francoisl merged commit f2ffc1a into main Jan 15, 2026
40 of 41 checks passed

francoisl deleted the francois-attendee-default branch January 15, 2026 23:53

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 15, 2026

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

melvin-bot bot mentioned this pull request Jan 20, 2026

[Due for payment 2026-01-27] Expense - Invited member cannot see Attendee field #79710

Closed

7 tasks

Conversation

francoisl commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 15, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 15, 2026

Uh oh!

Julesssss commented Jan 15, 2026

Uh oh!

Julesssss commented Jan 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

francoisl commented Jan 15, 2026

Uh oh!

ikevin127 commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francoisl commented Jan 15, 2026

Uh oh!

francoisl commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francoisl commented Jan 15, 2026 •

edited

Loading

codecov bot commented Jan 15, 2026 •

edited by github-actions bot

Loading

ikevin127 commented Jan 15, 2026 •

edited

Loading

francoisl commented Jan 15, 2026 •

edited

Loading