Support displaying a pending state in the report status for To-Do search results when an action is pending by tsa321 · Pull Request #79736 · Expensify/App

tsa321 · 2026-01-16T02:52:52Z

Explanation of Change

This PR displays a lower-opacity (pending) state for the report’s status field when an action is pending in the To-Do search results.

Fixed Issues

$ #78599
PROPOSAL: #78599 (comment)

Tests

Precondition: Have some draft reports (two is sufficient).

Go to Reports → Submit.
Visit all listed reports by clicking each report or using the Next button in the carousel.
Go back to Reports.
Go offline.
Open the first report and click Submit.
Go to the Approve tab.
Verify that the submitted report’s status has lower opacity (indicating a pending state).
Go online.
Verify that after some time (once the submit request is successful), the opacity returns to normal / the status is no longer pending.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Have some draft reports (two is sufficient).

Go to Reports → Submit.
Visit all listed reports by clicking each report or using the Next button in the carousel.
Go back to Reports.
Go offline.
Open the first report and click Submit.
Go to the Approve tab.
Verify that the submitted report’s status has lower opacity (indicating a pending state).
Go online.
Verify that after some time (once the submit request is successful), the opacity returns to normal / the status is no longer pending.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native_d.mp4

Android: mWeb Chrome

android_mweb_d.mp4

iOS: Native

ios_native_d.mp4

iOS: mWeb Safari

ios_msafari_d.mp4

MacOS: Chrome / Safari

macos_web_d.mp4

…ing while offline Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2026-01-16T02:52:59Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

App/src/libs/SearchUIUtils.ts

Lines 1769 to 1772 in c882930

    
           const isActionLoading = isActionLoadingSet?.has(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportItem.reportID}`); 
        
           if (queryJSON && !isActionLoading) { 
        
               if (queryJSON.type === CONST.SEARCH.DATA_TYPES.EXPENSE) { 
        
                   const status = queryJSON.status;

Reapply action filter for expense-report searches

The getReportSections filtering now only checks status for EXPENSE queries and no longer considers the action filter that powers the Submit/Approve/Pay/Export canned searches. This means when results are built locally (e.g., offline or when using cached snapshot data), an action:approve/action:submit query can show reports in the wrong state because the action predicate is never applied. That’s a regression in the search semantics (the query still includes action), so those tabs/filters will be inconsistent with the intended results unless action filtering is restored or scoped to allow the pending exception explicitly.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

codecov · 2026-01-16T03:54:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ReportSearchHeader/index.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`33.05% <ø> (ø)`
...stWithSections/Search/ExpenseReportListItemRow.tsx	`0.00% <ø> (ø)`
src/libs/SearchUIUtils.ts	`64.41% <100.00%> (+0.02%)`	⬆️
...ts/SelectionListWithSections/Search/StatusCell.tsx	`66.66% <0.00%> (ø)`
... and 34 files with indirect coverage changes

dukenv0307 · 2026-01-16T09:11:35Z

src/components/Search/index.tsx

        return [filteredData1, filteredData1.length, allLength];
    }, [
        searchKey,
+        isFocused,


do we need this change?

@dukenv0307 Yes, it’s needed so the data gets updated when the user goes back to the search list after viewing the report.
If I don’t include this, the pending data won’t update properly.

src/components/ReportSearchHeader/index.tsx

dukenv0307 · 2026-01-16T09:24:10Z

src/components/MoneyRequestReportView/MoneyRequestReportNavigation.tsx

            archivedReportsIDList: archivedReportsIdSet,
            isActionLoadingSet,
            cardFeeds,
-            shouldSkipActionFiltering: true,


Why do we need to remove shouldSkipActionFiltering? I don't see you mentioning it in the proposal.

This was added to fix a regression caused by the offending PR. Since I am reverting the original PR, this is no longer needed.

dukenv0307 · 2026-01-16T09:24:24Z

src/components/ReportSearchHeader/types.ts

 type ReportSearchHeaderProps = {
    /** Report, if we're showing the details for one and using AvatarWithDisplay */
-    report?: OnyxEntry<Report>;
+    report?: ExpenseReportListItemType;


Actually, the data type passed to ReportSearchHeader is ExpenseReportListItemType.

App/src/components/SelectionListWithSections/Search/ExpenseReportListItemRow.tsx

Lines 245 to 246 in ac269f8

<ReportSearchHeader

report={item}

and OnyxEntry is only part of it. Since isReportStatePending is not part of OnyxEntry<Report>, I need to use the full type.

dukenv0307 · 2026-01-16T09:25:12Z

src/libs/SearchUIUtils.ts

@@ -1795,11 +1779,6 @@
                        shouldShow = isValidExpenseStatus(status) ? expenseStatusActionMapping[status](reportItem) : false;


Please add a comment for this change.

I didn’t modify these lines—below this, I’m only reverting the offending PR. What comment are you referring to?

mkhutornyi · 2026-01-16T10:25:39Z

Offending PR is being reverted. Please hold this for #79714
cc: @luacmartins

tsa321 · 2026-01-16T13:52:15Z

@dukenv0307 I’ve replied to your comments. Should we tag or loop in the design team?

luacmartins · 2026-01-16T18:33:36Z

#79714 is merged

dukenv0307 · 2026-01-19T02:22:27Z

@tsa321 can you please merge main?

tsa321 · 2026-01-19T02:36:34Z

@dukenv0307 I have merged main

dukenv0307 · 2026-01-19T02:57:14Z

@tsa321 Thank you, can you please confirm with @Expensify/design team about showing the offline indicator?

trjExpensify · 2026-01-23T16:43:56Z

Sounds good!

tsa321 · 2026-01-24T01:00:44Z

@trjExpensify Since PR #79506 has been merged, reports are now listed under the correct action tab when offline. Do we still want to show a pending state on the status field for reports that have been submitted or approved while offline?

It would look something like this:

Screen.Recording.2026-01-24.at.07.53.37.mov

dukenv0307 · 2026-01-27T01:23:46Z

@trjExpensify @luacmartins can you please take a look at the comment above ^?

luacmartins · 2026-01-27T16:44:37Z

Not sure if we need the pending state, but the main issue is fixed now. cc @trjExpensify

trjExpensify · 2026-01-28T01:23:43Z

Mhm... I think we probably should still do the pending state change as it can be rolled back when coming back online if it fails. 👍

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2026-01-28T05:36:39Z

@dukenv0307 I’ve updated the code.

dukenv0307 · 2026-01-28T09:22:39Z

src/components/ReportSearchHeader/index.tsx

    const {isLargeScreenWidth} = useResponsiveLayout();

+    const statusContainerStyle = useMemo(() => {
+        return [isLargeScreenWidth ? styles.mt1 : styles.mt0Half, report?.isReportStatePending && styles.offlineFeedbackPending];


Should apply offlineFeedbackPending if report?.isReportStatePending and isOffline?

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

dukenv0307 · 2026-01-29T03:07:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-29.at.10.06.16.mov

Android: mWeb Chrome

Screen.Recording.2026-01-29.at.10.01.53.mov

iOS: HybridApp

Screen.Recording.2026-01-29.at.10.06.45.mov

iOS: mWeb Safari

Screen.Recording.2026-01-29.at.10.02.16.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.09.56.24.mov

dukenv0307

LGTM

robertjchen · 2026-01-29T03:19:21Z

Woo

OSBotify · 2026-01-29T03:29:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:16:09Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:18:05Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

tsa321 added 6 commits January 15, 2026 16:49

Fix report not displayed in search results after submitting or approv…

e4bbc3b

…ing while offline Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Narrow screen related changes

6e6691d

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Fix tests

098dab8

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Using report pendingFields

f0a984e

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Remove unused const

a38c723

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Compare with nextStep update

c882930

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested review from a team as code owners January 16, 2026 02:52

melvin-bot bot assigned tsa321 Jan 16, 2026

melvin-bot bot requested review from dukenv0307 and trjExpensify and removed request for a team and trjExpensify January 16, 2026 02:52

melvin-bot bot removed the request for review from a team January 16, 2026 02:52

chatgpt-codex-connector bot reviewed Jan 16, 2026

View reviewed changes

Fix test

d3b4799

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

dukenv0307 reviewed Jan 16, 2026

View reviewed changes

src/components/ReportSearchHeader/index.tsx Show resolved Hide resolved

dukenv0307 reviewed Jan 16, 2026

View reviewed changes

Merge branch 'main' into fixSearchActionFilter

a903fda

tsa321 changed the title ~~Fix report not displayed in search action tabs after submitting, approving, etc while offline~~ [HOLD] Fix report not displayed in search action tabs after submitting, approving, etc while offline Jan 22, 2026

trjExpensify changed the title ~~[HOLD] Fix report not displayed in search action tabs after submitting, approving, etc while offline~~ [HOLD PR#79506] Fix report not displayed in search action tabs after submitting, approving, etc while offline Jan 23, 2026

tsa321 added 2 commits January 24, 2026 07:12

Merge branch 'main' into fixSearchActionFilter

9896b70

Merge branch 'main' into fixSearchActionFilter

3d3e8da

tsa321 changed the title ~~[HOLD PR#79506] Fix report not displayed in search action tabs after submitting, approving, etc while offline~~ Fix report not displayed in search action tabs after submitting, approving, etc while offline Jan 26, 2026

tsa321 added 2 commits January 28, 2026 09:17

Merge branch 'main' into fixSearchActionFilter

158ffb3

Using pending fields live data

ffaa8be

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 changed the title ~~Fix report not displayed in search action tabs after submitting, approving, etc while offline~~ Display Pending State in Report Status for To-Do Search Results Jan 28, 2026

tsa321 changed the title ~~Display Pending State in Report Status for To-Do Search Results~~ Support displaying a pending state in the report status for To-Do search results when an action is pending Jan 28, 2026

dukenv0307 reviewed Jan 28, 2026

View reviewed changes

tsa321 added 3 commits January 29, 2026 08:02

add offline check

4cbebe1

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Merge branch 'main' into fixSearchActionFilter

4ea081f

Fix test

8bd70a3

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

dukenv0307 approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot requested a review from robertjchen January 29, 2026 03:07

robertjchen approved these changes Jan 29, 2026

View reviewed changes

robertjchen merged commit 735721f into Expensify:main Jan 29, 2026
30 checks passed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

tsa321 mentioned this pull request Feb 3, 2026

[$250] Expense - In the offline state, the paid report disappears from the 'Pay' list #78599

Closed

7 tasks

	const isActionLoading = isActionLoadingSet?.has(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportItem.reportID}`);
	if (queryJSON && !isActionLoading) {
	if (queryJSON.type === CONST.SEARCH.DATA_TYPES.EXPENSE) {
	const status = queryJSON.status;

		@@ -1795,11 +1779,6 @@
		shouldShow = isValidExpenseStatus(status) ? expenseStatusActionMapping[status](reportItem) : false;

Conversation

tsa321 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

codecov bot commented Jan 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Jan 16, 2026

Uh oh!

tsa321 commented Jan 16, 2026

Uh oh!

luacmartins commented Jan 16, 2026

Uh oh!

dukenv0307 commented Jan 19, 2026

Uh oh!

tsa321 commented Jan 19, 2026

Uh oh!

dukenv0307 commented Jan 19, 2026

Uh oh!

trjExpensify commented Jan 23, 2026

Uh oh!

tsa321 commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jan 27, 2026

Uh oh!

luacmartins commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Jan 28, 2026

Uh oh!

tsa321 commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

robertjchen commented Jan 29, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 29, 2026

Uh oh!

tsa321 commented Jan 16, 2026 •

edited

Loading

codecov bot commented Jan 16, 2026 •

edited by github-actions bot

Loading

tsa321 Jan 16, 2026 •

edited

Loading

tsa321 commented Jan 24, 2026 •

edited

Loading

luacmartins commented Jan 27, 2026 •

edited

Loading