fix: wrong copy action when expense report is undefined by truph01 · Pull Request #79748 · Expensify/App

truph01 · 2026-01-16T07:11:10Z

Explanation of Change

Fixed Issues

$ #77158
PROPOSAL:

Tests

Requirement: Have two accounts opened on two different devices or environments
User A has at least one workspace

A: Open any workspace expenses chat
A: Click on the chat header and select Members and invite User B as a member/ or type @userbemail in the composer chat
B: Open the same workspace chat
A: Create/submit an expense
B: Notice there's new report preview action appears
B: Right click on the report preview action, > select "Copy message"
B: Paste the value
Verify: It should return the report expense name, which is "Expense Report 2026-01-08"

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-16.at.14.03.50.mov

Android: mWeb Chrome

I encountered an error with this platform. I will update video later

iOS: Native

Screen.Recording.2026-01-16.at.14.06.06.mov

iOS: mWeb Safari

Screen.Recording.2026-01-16.at.14.03.07.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-16.at.14.01.04.mov

melvin-bot · 2026-01-16T07:11:25Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd6886236a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-16T07:17:56Z

src/libs/ReportUtils.ts

+    if (isCopyAction) {
+        if (report) {
+            return computeReportName(report) || (originalReportAction?.childReportName ?? '');
+        }
+        return originalReportAction?.childReportName ?? '';


Fall back to message when report is missing

When isCopyAction is true and the report is missing (which the comment below notes can happen after sign‑in or before the report loads), this branch now returns originalReportAction?.childReportName ?? ''. Because childReportName is optional (and not set on some report preview actions), the copy operation can silently produce an empty string instead of the visible preview text; previously it would fall back to reportActionMessage via the empty‑report branch. This means users can get a blank clipboard entry in the missing‑report scenario. Consider falling back to reportActionMessage when childReportName is absent.

Useful? React with 👍 / 👎.

Can you please leave comments on the AI feedback? @truph01

The ?? '' is just to address a type issue. As far as I know, there's no real scenario where originalReportAction?.childReportName would be undefined. So we don't need to consider a fallback value for reportActionMessage in cases where childReportName is absent.

codecov · 2026-01-16T07:20:46Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`71.97% <75.00%> (-0.01%)`	⬇️
... and 4 files with indirect coverage changes

mountiny · 2026-01-20T17:29:22Z

@thesahindia can you review please?

thesahindia · 2026-01-20T20:01:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-21.at.2.08.18.AM.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-21.at.1.13.17.AM.mov

thesahindia · 2026-01-20T20:01:56Z

@thesahindia can you review please?

Thanks for the bump.

mountiny

@truph01 Can you please make sure to update the unit test to verify this change and that the previous issue is fixed?

mountiny · 2026-01-21T13:36:25Z

src/libs/ReportUtils.ts

+    if (isCopyAction) {
+        if (report) {
+            return computeReportName(report) || (originalReportAction?.childReportName ?? '');
+        }
+        return originalReportAction?.childReportName ?? '';


Can you please leave comments on the AI feedback? @truph01

mountiny · 2026-01-26T01:50:39Z

@truph01 bump

truph01 · 2026-01-26T07:44:31Z

@mountiny I just added a comment on AI feedback

OSBotify · 2026-01-27T01:02:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:11:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:57:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: wrong copy action when expense report is undefined

fd68862

melvin-bot bot assigned truph01 Jan 16, 2026

truph01 marked this pull request as ready for review January 16, 2026 07:11

truph01 requested review from a team as code owners January 16, 2026 07:11

melvin-bot bot requested review from JmillsExpensify and thesahindia and removed request for a team and JmillsExpensify January 16, 2026 07:11

melvin-bot bot removed the request for review from a team January 16, 2026 07:11

truph01 mentioned this pull request Jan 16, 2026

[Due for payment 2026-02-04] [$250] Chat - Message copied from empty report shows "Workspace owes 0,00" instead of report title #77158

Closed

8 tasks

chatgpt-codex-connector bot reviewed Jan 16, 2026

View reviewed changes

thesahindia approved these changes Jan 20, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 20, 2026 20:39

mountiny requested changes Jan 21, 2026

View reviewed changes

Merge branch 'Expensify:main' into fix/77158-v2

9fbc18e

mountiny approved these changes Jan 27, 2026

View reviewed changes

mountiny merged commit f83f7ce into Expensify:main Jan 27, 2026
30 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Conversation

truph01 commented Jan 16, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Jan 20, 2026

Uh oh!

thesahindia commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia commented Jan 20, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 26, 2026

Uh oh!

truph01 commented Jan 26, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 16, 2026 •

edited by github-actions bot

Loading

thesahindia commented Jan 20, 2026 •

edited

Loading