[NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow by ikevin127 · Pull Request #79810 · Expensify/App

ikevin127 · 2026-01-17T06:09:49Z

Explanation of Change

2.4 Update Settlement Frequency Flow

UX Flow

In the active state, we show a “Settlement frequency” row with the current value (“Monthly”, “Weekly”, etc.).
When the admin taps the row:
- We open a simple selection UI (modal or full‑screen) showing available frequencies.
When the admin chooses a frequency:
- We call the Travel Invoicing frequency action.
- On success, the row shows the new value.

Default Value: When Travel Invoicing is first enabled, the settlement frequency defaults to Monthly (matching CONST.EXPENSIFY_CARD.FREQUENCY_SETTING.MONTHLY). This aligns with typical business billing cycles and mirrors Expensify Card behavior. Users can change to daily if preferred.

Data & Onyx
Current frequency comes from getTravelSettlementFrequency(policy) (e.g., 'monthly', 'weekly').

We map backend values to localized labels via a pure helper: getLocalizedSettlementFrequencyLabel(frequency, translate).

Actions
New function in src/libs/actions/TravelInvoicing.ts:

updateTravelInvoiceSettlementFrequency({policyID, frequency}):
- Wraps UpdateTravelInvoiceSettlementFrequency.
- Returns a Promise and surfaces failures as localized errors.

Components & reuse
Frequency selector:

Implemented using SelectionList + RadioListItem, same as other simple settings pickers.
The options array is small and static (e.g., [Daily and Monthly]) aligned with the backend.

WorkspaceTravelInvoicingSection:

Renders the row using MenuItem with a right‑aligned label for the localized frequency.
Handles the navigation to the selection screen and updates when Onyx changes.

Testing
Component tests:

The frequency row displays the correct label for each backend enum.
Selecting a new frequency triggers updateTravelInvoiceSettlementFrequency with the correct payload.

Fixed Issues

$ #78676
PROPOSAL:

Tests

Preconditions:

Must be on a private domain account
ALL or Travel Invoicing beta enabled on your account
in workspace settings More features enable Travel
workspace must have BA added in Workflows section (can be test BA)

Test 1: View Settlement Frequency Row

Steps:

Navigate to Workspace > Travel
Observe the "Travel Invoicing" section

Expected Results:

✅ "Settlement frequency" row is visible with default value displayed as "Monthly" (first time settlement account set)
✅ Row shows a right arrow indicating it's clickable

Test 2: Open Frequency Selection Screen

Steps:

Tap the "Settlement frequency" row.

Expected Results:

✅ Frequency selection RHP opens
✅ Header shows "Settlement frequency" with back button
✅ Description text is visible: "Choose how often you'll settle your travel invoicing balance."
✅ Selectable items list shows "Monthly" and "Daily" options
✅ Current frequency is pre-selected

Test 3: Change Frequency (Online)

Steps:

Open frequency selection screen.
Current frequency shows "Monthly".
Tap "Daily" option.

Expected Results:

✅ Selection immediately updates to "Daily"
✅ Screen navigates back to Travel Invoicing section
✅ Settlement frequency row now displays "Daily"
Verify that no errors appear in the JS console

Offline tests

Test 5: Change Frequency While Offline (Optimistic Update)

Steps:

Open the app on the Travel Invoicing section.
Toggle offline mode.
Tap "Settlement frequency" row.
Change from "Monthly" to "Daily".

Expected Results:

✅ Optimistic update: Frequency row immediately shows "Daily"
✅ Row appears grayed out (pending indicator)
✅ No error message

Test 6: Reconnect After Offline Change (Success)

Steps:

After Test 5, reconnect to network.
Wait for sync.

Expected Results:

✅ Pending indicator (gray styling) disappears
✅ Frequency row shows "Daily" (confirmed from server)
✅ No error / RBR indicator

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

web.mov

ios-hybrid.mov

melvin-bot · 2026-01-17T06:09:55Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-01-17T18:58:57Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/TravelInvoicingUtils.ts	`100.00% <100.00%> (ø)`
src/ROUTES.ts	`13.07% <0.00%> (-0.11%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.68% <0.00%> (-0.02%)`	⬇️
src/libs/actions/TravelInvoicing.ts	`75.75% <88.88%> (+15.75%)`	⬆️
...rkspace/travel/WorkspaceTravelInvoicingSection.tsx	`75.00% <60.00%> (-4.17%)`	⬇️
...orkspaceTravelInvoicingSettlementFrequencyPage.tsx	`0.00% <0.00%> (ø)`
... and 20 files with indirect coverage changes

melvin-bot · 2026-01-17T19:46:04Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b58d69d992

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx

src/pages/workspace/travel/WorkspaceTravelSettlementFrequencyPage.tsx

ikevin127 · 2026-01-17T22:43:47Z

🟢 Ready for review!

joekaufmanexpensify

Design doc implementation

The merge-base changed after approval.

blimpich · 2026-01-29T23:47:59Z

@ikevin127 can you update this branch and fix the merge conflicts?

parasharrajat · 2026-01-30T11:18:56Z

Conflicts @ikevin127

parasharrajat · 2026-01-30T20:02:45Z

@ikevin127 Can you please merge main here? There are duplicate changes here.

parasharrajat · 2026-01-31T12:00:30Z

Noticed a bug:

Book or manage travel button does not open the page.

31.01.2026_17.27.52_REC.mp4

parasharrajat · 2026-01-31T12:14:51Z

BUG: Errors are not cleared on the settlement account field.

31.01.2026_17.43.49_REC.mp4

parasharrajat · 2026-02-02T16:49:16Z

Bump @ikevin127

ikevin127 · 2026-02-02T20:04:21Z

Will get to this one soon - currently attention is directed towards #81084 to allow testing for @blimpich and because this testing PR will pring about some changes that will affect all currently opened PRs we should hold the currently opened PRs until that one is merged 👍

parasharrajat · 2026-02-04T09:18:31Z

Any updates? @ikevin127

ikevin127 · 2026-02-04T20:35:35Z

BUG: Errors are not cleared on the settlement account field.

✅ Resolved, after #81084 was merged now the flow works as follows:

when Central invoicing is turned from disabled to enabled:
- if API fails -> settlement account field will have error which if dismissed-> disables Central invoicing (reverts the enabling) since there isn't any previous BA to revert the field (no assigned BA = Central invoicing OFF)
- if API success -> settlement account field will be set to the assigned BA and settlement frequency to Monthly
when Central invoicing is already enabled:
- if settlement account change API fails -> settlement account field will have error which if dismissed -> error is cleared and settlement account BA value is reverted to the account set before the change (settlement frequency is preserved)

@parasharrajat 🟢 Ready for review! Updated PR description tests since testing is easier after the latest PR was merged.

ikevin127 · 2026-02-04T20:56:11Z

❌ ESLint fail is not caused by our PRs changes, there's no errors just warnings coming from other PRs changes which overflow the warning limit causing workflow to fail.

parasharrajat · 2026-02-05T08:04:24Z

if API fails -> settlement account field will have error which if dismissed-> disables Central invoicing (reverts the enabling) since there isn't any previous BA to revert the field (no assigned BA = Central invoicing OFF)

Why are we using a Settlement account for this purpose?

(no assigned BA = Central invoicing OFF)

This contradicts your point 2 ⬇️

if settlement account change API fails -> settlement account field will have error which if dismissed -> error is cleared and settlement account BA value is reverted to the account set before the change (settlement frequency is preserved)

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx

…7-travel-invoicing-24

ikevin127 · 2026-02-05T22:55:42Z

Why are we using a Settlement account for this purpose?

That's how we agreed on the flow behaving for PR #81084 / Slack thread discussion.

This contradicts your point 2 ⬇️

It doesn't contradict because we're talking about 2 specific cases:

settlement account was assigned first time (meaning there won't be any previous settlement account to revert to) -> resulting in Central Invoicing turning OFF when settlement account error is cleared
settlement account was changed (meaning we have previous settlement account to revert to if the change fails) -> resulting in Central Invoicing remaining OD when settlement account error is cleared

parasharrajat · 2026-02-06T21:04:57Z

Screenshots

🔲 iOS / Safari

31.01.2026_17.35.37_REC.mp4

🔲 MacOS / Chrome

31.01.2026_17.33.36_REC.mp4

🔲 Android / native

07.02.2026_02.52.51_REC.mp4

parasharrajat · 2026-02-06T21:32:41Z

Notes:

Clicking the selected settlement account again makes the api call again to set the same bank account. It should simply close the page.
Currently, when we turn on central invoicing, the user is asked to select a bank, and if there is an error, remove that error, and then the central invoicing turns off.
But if we click on the settlement account again and make a change to the account, and there is an error, clearing the error will not close the central invoicing.
There is an issue with the add bank account flow in the app; it does not move to step 3 after completing the Plaid flow.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2026-02-06T21:34:06Z

some points #79810 (comment) cc: @ikevin127 @blimpich

blimpich · 2026-02-06T22:18:12Z

@ikevin127 would you like to address these issues @parasharrajat points out in this PR or in a follow up? I'm good with either path

ikevin127 · 2026-02-06T22:21:45Z

@blimpich Follow-up would be best, specifically in Release 2.2 - the only issue to address would be:

Clicking the selected settlement account again makes the api call again to set the same bank account. It should simply close the page.

as the 2 & 3 are agreed upon behaviour (for testing purposes) and the last one is not related to our changes (didn't change the general add BA flow).

github-actions · 2026-02-06T23:02:34Z

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-06T23:06:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79810.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a9accbd-cc9fb948f79fedd9b657a68374c8b3b984d8a3f5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a9accbd-c4ef11e1cd28762d86754de5b6d1aca01896a1c2/index.html

Web 🕸️
https://79810.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-06T23:08:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-10T07:22:23Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-11T06:26:51Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ikevin127 added 3 commits January 16, 2026 21:43

chore: draft preparation

3f3369a

fix: eslint

58a0448

fix: lint

530d292

melvin-bot bot assigned ikevin127 Jan 17, 2026

ikevin127 mentioned this pull request Jan 17, 2026

Travel Invoicing – Release 2: Add UI to NewDot #78672

Open

fix: CI, BE integration, optimistic behaviour, styles

5912c27

fix: default frequency adjustment and eslint

b58d69d

ikevin127 marked this pull request as ready for review January 17, 2026 19:45

ikevin127 requested review from a team as code owners January 17, 2026 19:45

melvin-bot bot requested review from joekaufmanexpensify and parasharrajat and removed request for a team January 17, 2026 19:46

melvin-bot bot removed request for a team and parasharrajat January 17, 2026 19:46

fix: unit test

21d0155

chatgpt-codex-connector bot reviewed Jan 17, 2026

View reviewed changes

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx Outdated Show resolved Hide resolved

src/pages/workspace/travel/WorkspaceTravelSettlementFrequencyPage.tsx Outdated Show resolved Hide resolved

ikevin127 added 2 commits January 17, 2026 12:52

fix: codex review and error handling

c9cb1d7

fix: updated tests

e055dcd

joekaufmanexpensify previously approved these changes Jan 19, 2026

View reviewed changes

blimpich requested a review from parasharrajat January 29, 2026 23:48

ikevin127 changed the title ~~[NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow~~ [HOLD #81084][NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow Feb 2, 2026

ikevin127 added 2 commits February 4, 2026 09:37

chore: main sync

46d773e

fix: adjust error clearing logic

c0ccf00

ikevin127 changed the title ~~[HOLD #81084][NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow~~ [NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow Feb 4, 2026

parasharrajat reviewed Feb 5, 2026

View reviewed changes

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx Show resolved Hide resolved

Merge branch 'main' of https://github.com/Expensify/App into ikevin12…

349a870

…7-travel-invoicing-24

parasharrajat approved these changes Feb 6, 2026

View reviewed changes

melvin-bot bot requested a review from blimpich February 6, 2026 21:33

blimpich approved these changes Feb 6, 2026

View reviewed changes

blimpich merged commit a9accbd into Expensify:main Feb 6, 2026
31 of 35 checks passed

OSBotify mentioned this pull request Feb 10, 2026

Deploy Checklist: New Expensify 2026-02-10 #81937

Closed

Conversation

ikevin127 commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

2.4 Update Settlement Frequency Flow

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 17, 2026

Uh oh!

codecov bot commented Jan 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ikevin127 commented Jan 17, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented Jan 29, 2026

Uh oh!

parasharrajat commented Jan 30, 2026

Uh oh!

parasharrajat commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 31, 2026

Uh oh!

parasharrajat commented Jan 31, 2026

Uh oh!

parasharrajat commented Feb 2, 2026

Uh oh!

ikevin127 commented Feb 2, 2026

Uh oh!

parasharrajat commented Feb 4, 2026

Uh oh!

ikevin127 commented Feb 4, 2026

Uh oh!

ikevin127 commented Feb 4, 2026

Uh oh!

parasharrajat commented Feb 5, 2026

Uh oh!

Uh oh!

ikevin127 commented Feb 5, 2026

Uh oh!

parasharrajat commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / native

Uh oh!

parasharrajat commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented Feb 6, 2026

Uh oh!

blimpich commented Feb 6, 2026

Uh oh!

ikevin127 commented Feb 6, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

ikevin127 commented Jan 17, 2026 •

edited

Loading

codecov bot commented Jan 17, 2026 •

edited by github-actions bot

Loading

parasharrajat commented Jan 30, 2026 •

edited

Loading

parasharrajat commented Feb 6, 2026 •

edited

Loading

parasharrajat commented Feb 6, 2026 •

edited

Loading