refactor startMoneyRequest part 1 by dukenv0307 · Pull Request #79951 · Expensify/App

dukenv0307 · 2026-01-20T09:48:23Z

Explanation of Change

Refactor startMoneyRequest part 1 (too many startMoneyRequest usages). In the next PR, we'll update other usages of startMoneyRequest

Fixed Issues

$ #67778
PROPOSAL:

Tests

Create an expense
Click FAB
Select quick action
Create another expense
Verify that the new expense is created successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-20.at.16.42.09.mov

codecov · 2026-01-20T09:59:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../FloatingCameraButton/BaseFloatingCameraButton.tsx	`82.35% <100.00%> (+1.10%)`	⬆️
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.63% <100.00%> (+0.23%)`	⬆️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
...tReportView/SearchMoneyRequestReportEmptyState.tsx	`3.57% <0.00%> (-0.14%)`	⬇️
src/libs/actions/IOU/index.ts	`72.83% <80.00%> (+0.38%)`	⬆️
...stReportView/MoneyRequestReportTransactionList.tsx	`1.31% <0.00%> (-0.02%)`	⬇️
src/libs/ReportUtils.ts	`75.43% <0.00%> (-0.07%)`	⬇️
src/libs/actions/QuickActionNavigation.ts	`78.00% <75.00%> (ø)`
src/selectors/TransactionDraft.ts	`70.00% <40.00%> (-30.00%)`	⬇️
...ortActionCompose/AttachmentPickerWithMenuItems.tsx	`48.22% <14.28%> (-1.04%)`	⬇️
... and 1 more
... and 64 files with indirect coverage changes

melvin-bot · 2026-01-22T04:20:55Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/MoneyReportHeader.tsx

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

tests/actions/IOUTest/StartMoneyRequestTest.ts

JmillsExpensify

Product review not required.

DylanDylann · 2026-01-27T08:52:51Z

@codex review

chatgpt-codex-connector · 2026-01-27T09:23:49Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-01-27T09:31:49Z

@codex review

chatgpt-codex-connector · 2026-01-27T09:47:55Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dukenv0307 · 2026-01-28T03:47:35Z

Let's wait for #79948

dukenv0307 · 2026-02-09T03:34:08Z

Same as above

dukenv0307 · 2026-02-27T10:47:47Z

@DylanDylann It's ready for review

DylanDylann · 2026-03-05T10:03:14Z

@codex review

DylanDylann · 2026-03-05T10:14:49Z

src/libs/actions/IOU/index.ts


-function clearMoneyRequest(transactionID: string, skipConfirmation = false, draftTransactions?: OnyxCollection<OnyxTypes.Transaction>) {
-    removeDraftTransactions(undefined, draftTransactions);
+function clearMoneyRequest(transactionID: string, skipConfirmation = false, draftTransactionIDs: string[] = []) {


Don't use default value

DylanDylann · 2026-03-05T10:15:13Z

src/libs/actions/IOU/index.ts

    skipConfirmation = false,
    backToReport?: string,
-    draftTransactions?: OnyxCollection<OnyxTypes.Transaction>,
+    // TODO: Make draftTransactionIDs required in the follow-up PR


Please link the issue to the comment

DylanDylann · 2026-03-05T10:17:42Z

src/pages/inbox/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

+                                startDistanceRequest(
+                                    CONST.IOU.TYPE.SUBMIT,
+                                    report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID),
+                                    lastDistanceExpenseType,
+                                    false,
+                                    undefined,
+                                    draftTransactionIDs,


@dukenv0307 Your PRs are conflicting with each other. The order of draftTransactionIDs is different from other PRs in the refactor. It’s fine to work on PRs in parallel, but let’s make sure they stay consistent.

chatgpt-codex-connector · 2026-03-05T10:24:04Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

refactor startMoneyRequest part 1

9502476

melvin-bot bot assigned dukenv0307 Jan 20, 2026

Merge branch 'main' into fix/67778-part-4

00cef74

dukenv0307 marked this pull request as ready for review January 22, 2026 04:20

dukenv0307 requested review from a team as code owners January 22, 2026 04:20

melvin-bot bot requested review from DylanDylann and JmillsExpensify and removed request for a team January 22, 2026 04:20

melvin-bot bot removed the request for review from a team January 22, 2026 04:20

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2026

View reviewed changes

tests/actions/IOUTest/StartMoneyRequestTest.ts Show resolved Hide resolved

JmillsExpensify reviewed Jan 22, 2026

View reviewed changes

update test

771d21e

merge main

1851db2

DylanDylann reviewed Mar 5, 2026

View reviewed changes

dukenv0307 closed this Mar 12, 2026

Conversation

dukenv0307 commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 20, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 27, 2026

Uh oh!

DylanDylann commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 27, 2026

Uh oh!

dukenv0307 commented Jan 28, 2026

Uh oh!

dukenv0307 commented Feb 9, 2026

Uh oh!

dukenv0307 commented Feb 27, 2026

Uh oh!

DylanDylann commented Mar 5, 2026

Uh oh!

DylanDylann Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dukenv0307 commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited by github-actions bot

Loading