[Pre RN 0.83] Update react-native-reanimated, react-native-live-markdown and react-native-worklets to the latest versions#79993
Conversation
|
|
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny could you trigger an adhoc build here? 🙏 |
|
@jayeshmangwani can you please test on the builds once ready? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@jayeshmangwani Looks like PR needs a bit more polishing, will take care of that tomorrow |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@war-in Just checking, is the PR ready for review? |
|
ah sorry, not yet marking as a draft again |
9a4b13b to
6a5d2df
Compare
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@war-in @mjasikowski Do we need to clear more cache? |
|
@mountiny let's start with a new build and check if it's still failing |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Latest ad hoc APK is working well and doesn’t crash on startup. |
That's great! it works for me too! @jayeshmangwani could you review this recent change - 26f3855? There was a bug when opening a modal on mobile devices caused backdrop issues Before: Screen_Recording_20260202_125621_Expensify.Dev.mp4After: Screen_Recording_20260202_132230_Expensify.Dev.mp4 |
|
@jayeshmangwani Can you please review and let me know in slack when ready? |
|
changes work well, tested and everything looks good. This PR is good to merge. Android: Android.moviOS: ios.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.13-1 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.15-0 🚀
|
|
@IuliiaHerets I'm not sure if there are any specific steps because those libs are used across the entire app. You can verify if opening/closing modals look good and if markdown is properly formatted in the composer cc @mountiny for thoughts |
|
@war-in I think these modals should be covered as part of the regression steps, and since there are no specific steps for them, we can check off this PR. WDYT? |
|
Sounds good 👍 |
|
Sounds good |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
Explanation of Change
Update
react-native-reanimated,react-native-live-markdownandreact-native-workletsto the latest versions required for the RN bumpWe can't split this PR because both markdown and reanimated depend on worklets, which have to be updated too
Fixed Issues
$ #79919
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13824
Tests
Go through the app and check if animations work fine
Offline tests
QA Steps
Go through the app and check if animations work fine
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari