refactor: company card feed types and utils by chrispader · Pull Request #80006 · Expensify/App

chrispader · 2026-01-20T16:03:00Z

@carlosmiceli @joekaufmanexpensify

Explanation of Change

Refactorings around types and utils for company card feeds.

Fixed Issues

#76438

PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open the app
Go to a workspace with multiple connected card feeds, then go to"Company cards"
Make sure the first card feed loads
Assign a card
Make sure the card get's assigned properly.
Unassign card
Make sure the card is unassigned
Switch card feed
Make sure the second card feed loads
Repeat steps 4.-7.
Go offline
Repeat steps 4.-7. and make sure that the proper error messages are displayed or the behavior is prevented based on the offline patterns

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-01-20T16:27:45Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
...ponents/ReportActionAvatars/ReportActionAvatar.tsx	`86.53% <ø> (ø)`
src/components/ReportActionAvatars/index.tsx	`100.00% <ø> (ø)`
src/hooks/useCardFeedsForDisplay.ts	`72.72% <ø> (ø)`
src/hooks/useCompanyCards.ts	`100.00% <ø> (ø)`
src/libs/CardFeedUtils.ts	`89.69% <100.00%> (ø)`
src/libs/PolicyUtils.ts	`57.58% <100.00%> (+0.24%)`	⬆️
src/libs/TransactionUtils/index.ts	`83.80% <100.00%> (+7.43%)`	⬆️
...libs/actions/OnyxDerived/configs/cardFeedErrors.ts	`97.05% <100.00%> (ø)`
src/libs/actions/Policy/Member.ts	`72.86% <100.00%> (ø)`
... and 18 more
... and 31 files with indirect coverage changes

melvin-bot · 2026-01-20T20:26:16Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac25b86ab2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/libs/actions/CompanyCards.ts

ikevin127 · 2026-01-21T01:37:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

src/types/onyx/CardFeeds.ts

src/libs/CardUtils.ts

src/libs/actions/CompanyCards.ts

tests/unit/CardUtilsTest.ts

melvin-bot · 2026-02-06T21:13:19Z

🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #81759.

carlosmiceli · 2026-02-07T16:13:59Z

@chrispader We have failing tests 🫡

chrispader · 2026-02-10T19:21:33Z

@ikevin127 @carlosmiceli all tests passing now!

github-actions · 2026-02-10T19:55:44Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-10T19:58:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-10T20:00:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80006.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-082a129-e28711f5d1c2b4ab34649286784fbffa29474b99/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-082a129-69e208f872a5ea84952916251003bdf37dc2886a/index.html

Web 🕸️
https://80006.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-11T06:53:13Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-02-11T07:15:24Z

Hi @chrispader. Any QA steps here?

chrispader · 2026-02-11T09:19:28Z

@IuliiaHerets @carlosmiceli i don't think we'll need QA on this one, right? It's mainly refactoring and types.

Otherwise, the QA would just be to make sure everything works as expected, especially around the Workspace -> Company Cards flow

IuliiaHerets · 2026-02-11T09:30:59Z

@chrispader can we check it off in this case?

chrispader · 2026-02-11T09:42:27Z

@chrispader can we check it off in this case?

@carlosmiceli wdyt?

carlosmiceli · 2026-02-11T17:37:51Z

@IuliiaHerets I think QAing going through all the usual tests in the company cards assignment section is a good idea, we're making changes consistently to this flow and anything could introduce a bug these days 🙏

IuliiaHerets · 2026-02-11T17:53:41Z

@carlosmiceli please share the QA steps then

carlosmiceli · 2026-02-11T18:11:24Z

I'll let @chrispader propose that list 👍

chrispader · 2026-02-11T18:22:21Z

@IuliiaHerets i've added some basic QA steps for the company cards functionality

OSBotify · 2026-02-12T15:22:32Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

suneox · 2026-03-16T16:05:55Z

src/libs/CardUtils.ts

+        const cardFeedKeyParts = key.split('_');
+        const feedDomainID = Number(cardFeedKeyParts.at(1));
+        if (cardFeedKeyParts.length !== 3 || cardFeedKeyParts.at(0) !== ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST || Number.isNaN(feedDomainID)) {
+            return false;
+        }


Coming from #82554 checklist:

When assigning a direct-feed company card to a workspace, the app should detect if that card is already assigned to another workspace and show an error. so length check fails for plaid.ins_19 feeds (4 parts instead of 3)

refactor: company card feed types and utils

ae10277

melvin-bot bot assigned chrispader Jan 20, 2026

chrispader mentioned this pull request Jan 20, 2026

fix: Handle company Cards errors and initial loading states #78305

Merged

53 tasks

fix: more types

2493975

chrispader added 4 commits January 20, 2026 16:46

fix: TS errors

34f8a2b

fix: more TS errors

462a627

fix: more TS errors

fe2279e

Merge branch 'main' into @chrispader/company-cards-refactoring-and-types

ac25b86

chrispader changed the title ~~[WIP] refactor: company card feed types and utils~~ refactor: company card feed types and utils Jan 20, 2026

chrispader marked this pull request as ready for review January 20, 2026 20:25

chrispader requested review from a team as code owners January 20, 2026 20:25

melvin-bot bot requested review from joekaufmanexpensify and marcochavezf and removed request for a team January 20, 2026 20:25

carlosmiceli requested review from carlosmiceli and removed request for marcochavezf January 20, 2026 20:33

chatgpt-codex-connector bot reviewed Jan 20, 2026

View reviewed changes

src/libs/actions/CompanyCards.ts Outdated Show resolved Hide resolved

carlosmiceli requested a review from ikevin127 January 20, 2026 22:07

fix: TS and ESLint

1d27ce9