Apply test review changes #801
Conversation
tgolen
left a comment
tgolen
left a comment
There was a problem hiding this comment.
Great, thanks! Those descriptions on the tests really help. We still have an unresolved discussion about the config files, so I'll leave this open for a bit longer depending on how that conversation is resolved.
| const path = require('path'); | ||
| const dotenv = require('dotenv'); | ||
|
|
||
| const env = dotenv.config({path: path.resolve('./.env.example')}).parsed; |
There was a problem hiding this comment.
Wasn't exactly sure what .env file would be best, but I thought this one fit the best.. Let me know if you disagree @tgolen
There was a problem hiding this comment.
Oh, I actually hadn't considered the .env.example file. I was thinking maybe we would need a .env.testing file, but I think using the example file is brilliant 👍
There was a problem hiding this comment.
Also, I think using path can be overkill sometimes. I'm pretty sure this could be path: './.env.example'. I'm sure this was just from copy/pasting what we have elsewhere, but I would also say the same thing about wherever you copied it from.
| const path = require('path'); | ||
| const dotenv = require('dotenv'); | ||
|
|
||
| const env = dotenv.config({path: path.resolve('./.env.example')}).parsed; |
There was a problem hiding this comment.
Also, I think using path can be overkill sometimes. I'm pretty sure this could be path: './.env.example'. I'm sure this was just from copy/pasting what we have elsewhere, but I would also say the same thing about wherever you copied it from.
Pls review - @tgolen
Applies feedback from here: #415 (review) (sorry it's a bit late!)
Fixed Issues
Fixes N/A
Tests
Verify GitHub actions passes ✅