feat(insights): add Top Categories suggested search by ashu75575 · Pull Request #80102 · Expensify/App

ashu75575 · 2026-01-21T10:54:22Z

Explanation of Change

Fixed Issues

$ #80036
PROPOSAL: #80036 (comment)

Tests

Same as Q/A

Verify that no errors appear in the JS console
Same as Qa Steps

Offline tests

QA Steps

Launch app
Naviage to reports
verify "Top categories" under Insights section appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-21.at.10.12.43.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-01-21.at.10.11.34.PM.mov

iOS: Native

Screen.Recording.2026-01-21.at.5.54.43.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-01-21.at.10.49.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-21.at.5.47.38.PM.mov

melvin-bot · 2026-01-21T10:54:28Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

github-actions · 2026-01-21T10:54:33Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

ashu75575 · 2026-01-21T10:54:44Z

I have read the CLA Document and I hereby sign the CLA

ashu75575 · 2026-01-22T22:09:23Z

src/languages/es.ts

                [CONST.SEARCH.GROUP_BY.FROM]: 'De',
                [CONST.SEARCH.GROUP_BY.CARD]: 'Tarjeta',
                [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de retiro',
+                [CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoría',


I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

i dont have access to slack, Can c+ reviewer please help me verify this 🙏

Please read this guide to learn how to access Slack:
https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#slack-channels

When you update translations, Slack access is required to get confirmation. If you have any additional questions, you can post them in Slack.

If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

@ashu75575 https://expensify.slack.com/archives/C01GTK53T8Q/p1769138968997009 Please add this link to the checklist.

Category exists in en.ts, this is fine.

App/src/languages/es.ts

Line 232 in 9ce6569

category: 'Categoría',

(But generally agree with the process to follow for the future!)

melvin-bot · 2026-01-22T22:09:47Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/SearchUIUtils.ts

ashu75575 · 2026-01-22T22:15:26Z

src/libs/SearchUIUtils.ts

        const isEligibleForReconciliationSuggestion = isPaidPolicy && isAdmin && ((isPaymentEnabled && hasVBBA && hasReimburser) || isECardEnabled);
        const isAuditor = policy.role === CONST.POLICY.ROLE.AUDITOR;
        const isEligibleForTopSpendersSuggestion = isPaidPolicy && (isAdmin || isAuditor || isApprover);
+        const isEligibleForTopCategoriesSuggestion = isPaidPolicy && (isAdmin || isAuditor || isApprover);


issue suggests "Add visibility logic in getSuggestedSearchesVisibility() to show for all accounts with at least one workspace (policy)" but i added same logic to be consistent with isEligibleForTopSpendersSuggestion please let me know if we want to change this

@neil-marcellini can you please confirm this 🙏

Nah, Top Spenders is shown to admins, approvers and auditors. Top Categories is shown to all workspace members.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59f41f6401

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-22T22:23:18Z

src/libs/SearchUIUtils.ts

+                {
+                    type: CONST.SEARCH.DATA_TYPES.EXPENSE,
+                    groupBy: CONST.SEARCH.GROUP_BY.CATEGORY,
+                    dateOn: CONST.SEARCH.DATE_PRESETS.LAST_MONTH,


Add UI support for category group-by or hide suggestion

This new suggested search sets groupBy to CATEGORY, but the search UI only handles group-by values for FROM, CARD, and WITHDRAWAL_ID (e.g., getSections/getSortedSections switches in SearchUIUtils.ts, and header rendering in SearchTableHeader.tsx/TransactionGroupListItem.tsx lack a category case). When a user taps “Top categories,” the backend will return grouped data, yet the UI falls back to the non-grouped path and ignores group entries, which typically yields empty or broken results with missing headers. Either implement category group rendering (sections, headers, list item type guards, sorting) or avoid surfacing this suggestion until support is in place.

Useful? React with 👍 / 👎.

i think this will be part of #80034

huult · 2026-01-23T03:40:31Z

@ashu75575 Please update the Tests and QA steps in the checklist. What should QA verify? For example:

Preconditions:
- ....

1. Open the Expensify app.
2. Log in with email.
3. Navigate to Reports.
4. Verify that Top categories appears under the Insights section.
5. Tap Top categories.
6. Verify ...

huult · 2026-01-23T03:42:39Z

@ashu75575 Please set up data before recording the video so that Top categories has data to display.

huult · 2026-01-23T03:53:38Z

src/libs/SearchUIUtils.ts

-                return this.searchQueryJSON?.similarSearchHash ?? CONST.DEFAULT_NUMBER_ID;
-            },
-        },
+        [CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS]: createTopSearchMenuItem(CONST.SEARCH.SEARCH_KEYS.TOP_SPENDERS, 'search.topSpenders', Expensicons.User, CONST.SEARCH.GROUP_BY.FROM),


We do not need to add the createTopSearchMenuItem util function here. Therefore, you only need to add the TOP_CATEGORIES case and follow the existing code pattern above.

please check this ai comment #80102 (comment)

src/libs/SearchUIUtils.ts

src/languages/it.ts

src/languages/nl.ts

src/languages/pl.ts

src/languages/zh-hans.ts

…ty()

trjExpensify · 2026-01-23T15:23:54Z

Sounds like this PR needs to come first before we can merge this one: #80333

trjExpensify · 2026-01-27T02:35:34Z

Taking this off hold as we've merged #80333

github-actions · 2026-01-27T03:16:29Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

trjExpensify · 2026-01-27T03:57:16Z

@ashu75575 @huult I just took the adhoc build for a spin and I'm getting nothing to show. Why is that?

CC: @lakchote @cristipaval @puneetlath

codecov · 2026-01-27T06:01:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`84.03% <ø> (ø)`
src/libs/SearchUIUtils.ts	`61.83% <89.47%> (+0.22%)`	⬆️
... and 11 files with indirect coverage changes

huult · 2026-01-27T06:15:24Z

@trjExpensify it looks like this PR hasn’t been merged into main yet, so the code changes don’t exist and there’s nothing showing up.

@ashu75575 please merge main and double-check your changes after that, then ping me to review again.

github-actions · 2026-01-27T07:46:35Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-27T07:51:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80102.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://80102.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

lakchote · 2026-01-27T08:18:58Z

It now works correctly:

cc @huult you can continue the review

shawnborton · 2026-01-27T08:21:40Z

Looks good on my end too from a design perspective 👍

ashu75575 · 2026-01-27T08:25:19Z

added limit filter as per issue #80036

huult · 2026-01-27T08:36:36Z

@ashu75575 Is this PR is ready?

ashu75575 · 2026-01-27T08:40:59Z

yes

huult · 2026-01-27T08:53:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-27.at.15.46.00.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-27.at.15.46.44.mp4

iOS: HybridApp

Screen.Recording.2026-01-27.at.15.49.41.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-27.at.15.50.40.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.15.39.49.mp4

huult

LGTM

lakchote

LGTM

OSBotify · 2026-01-27T11:17:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:12:30Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:57:42Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned ashu75575 Jan 21, 2026

ashu75575 force-pushed the issue/80036 branch from 9c6e968 to 01a88a8 Compare January 21, 2026 11:00

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 21, 2026

@ashu75575 has signed the CLA in Expensify/App#80102

08151b2

ashu75575 force-pushed the issue/80036 branch from 01a88a8 to 743daa0 Compare January 21, 2026 11:06

feat(insights): add Top Categories suggested search

4d5aff2

ashu75575 force-pushed the issue/80036 branch from 743daa0 to 4d5aff2 Compare January 21, 2026 11:12

fix style and translation

59f41f6

ashu75575 commented Jan 22, 2026

View reviewed changes

ashu75575 marked this pull request as ready for review January 22, 2026 22:09

ashu75575 requested review from a team as code owners January 22, 2026 22:09

melvin-bot bot requested review from huult and trjExpensify and removed request for a team January 22, 2026 22:09

melvin-bot bot removed the request for review from a team January 22, 2026 22:09

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/libs/SearchUIUtils.ts Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/libs/SearchUIUtils.ts Show resolved Hide resolved

github-actions bot reviewed Jan 22, 2026

View reviewed changes

src/libs/SearchUIUtils.ts Outdated Show resolved Hide resolved

ashu75575 commented Jan 22, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

ashu75575 added 2 commits January 23, 2026 04:07

fix ai comments

1946495

code format

7860598

huult reviewed Jan 23, 2026

View reviewed changes

src/libs/SearchUIUtils.ts Show resolved Hide resolved

ashu75575 commented Jan 23, 2026

View reviewed changes

src/languages/it.ts Outdated Show resolved Hide resolved

src/languages/nl.ts Outdated Show resolved Hide resolved

src/languages/pl.ts Outdated Show resolved Hide resolved

src/languages/zh-hans.ts Outdated Show resolved Hide resolved

src/languages/zh-hans.ts Outdated Show resolved Hide resolved

ashu75575 and others added 2 commits January 23, 2026 14:00

remove unnecessary changes

6cb9d6a

fix "Top Categories" visibility logic in getSuggestedSearchesVisibili…

6def831

…ty()

trjExpensify changed the title ~~feat(insights): add Top Categories suggested search~~ [Hold PR #80333] feat(insights): add Top Categories suggested search Jan 23, 2026

trjExpensify changed the title ~~[Hold PR #80333] feat(insights): add Top Categories suggested search~~ feat(insights): add Top Categories suggested search Jan 27, 2026

This comment has been minimized.

Sign in to view

Merge branch 'Expensify:main' into issue/80036

a70d6c8

merge main and add limit filter

af79c27

huult approved these changes Jan 27, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 27, 2026 08:55

lakchote approved these changes Jan 27, 2026

View reviewed changes

lakchote merged commit a654f79 into Expensify:main Jan 27, 2026
32 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Conversation

ashu75575 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashu75575 commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult commented Jan 23, 2026

Uh oh!

huult commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trjExpensify commented Jan 23, 2026

Uh oh!

trjExpensify commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

This comment has been minimized.

trjExpensify commented Jan 27, 2026

Uh oh!

codecov bot commented Jan 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

ashu75575 commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

codecov bot commented Jan 27, 2026 •

edited by github-actions bot

Loading