Add auto travel description toggle#80142
Merged
stitesExpensify merged 42 commits intomainfrom Feb 10, 2026
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…avelDescriptionToggle
This comment has been minimized.
This comment has been minimized.
…avelDescriptionToggle
This comment has been minimized.
This comment has been minimized.
stitesExpensify
changed the title
Contributor
Author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Hm okay thanks I'll take a look. |
Contributor
Author
|
This is the error you're getting which is weird because the policy should have travel settings. Looking into it now. There are also some merge issues and the travel invoicing page is taking over when on a beta, so I'll chat with @blimpich about that
|
Contributor
Author
|
@thesahindia the issue was caused by the policy being provisioned a long time ago. I have a different PR to fix that, but this specific policy is fixed and you can continue testing |
stitesExpensify
changed the title
Member
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
|
thesahindia
approved these changes
Feb 8, 2026
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
carlosmiceli
previously approved these changes
Feb 9, 2026
stitesExpensify
changed the title
This comment has been minimized.
This comment has been minimized.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 91d872f3..1418d028 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2827,7 +2827,8 @@ ${
5. Füge eine eigene Einladung hinzu, wenn du möchtest!
[Zu den Workspace-Mitgliedern](${workspaceMembersLink}).
- `),
+
+ `),
},
setupCategoriesAndTags: {
title: ({workspaceCategoriesLink, workspaceTagsLink}) => `Richte [Kategorien](${workspaceCategoriesLink}) und [Tags](${workspaceTagsLink}) ein`,
@@ -5170,9 +5171,9 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
subtitle: 'Wir prüfen derzeit deine Anfrage zur Aktivierung von Expensify Travel. Keine Sorge, wir sagen dir Bescheid, sobald alles bereit ist.',
ctaText: 'Anfrage gesendet',
},
- bookOrManageYourTrip: {title: 'Reisebuchung', subtitle: 'Glückwunsch! Du kannst in diesem Arbeitsbereich jetzt Reisen buchen und verwalten.', ctaText: 'Reisen verwalten'},
+ bookOrManageYourTrip: {title: 'Reisebuchung', subtitle: 'Glückwunsch! Du kannst jetzt in diesem Workspace Reisen buchen und verwalten.', ctaText: 'Reisen verwalten'},
settings: {
- autoAddTripName: {title: 'Reisenamen zu Ausgaben hinzufügen', subtitle: 'Reisenamen für in Expensify gebuchte Reisen automatisch zu Spesenbeschreibungen hinzufügen.'},
+ autoAddTripName: {title: 'Reisenamen zu Ausgaben hinzufügen', subtitle: 'Reisenamen automatisch zu Spesenbeschreibungen hinzufügen für in Expensify gebuchte Reisen.'},
},
travelInvoicing: {
centralInvoicingSection: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e1d986dc..1d7cafcc 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5181,13 +5181,13 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
},
bookOrManageYourTrip: {
title: 'Réservation de voyage',
- subtitle: 'Félicitations ! Vous êtes prêt à réserver et gérer des voyages dans cet espace de travail.',
+ subtitle: 'Félicitations ! Vous êtes prêt à réserver et gérer vos déplacements dans cet espace de travail.',
ctaText: 'Gérer les déplacements',
},
settings: {
autoAddTripName: {
- title: 'Ajouter des noms de voyage aux dépenses',
- subtitle: 'Ajouter automatiquement les noms de voyage aux descriptions des dépenses pour les voyages réservés dans Expensify.',
+ title: 'Ajouter des noms de déplacement aux dépenses',
+ subtitle: 'Ajouter automatiquement les noms de voyage aux descriptions des dépenses pour les déplacements réservés dans Expensify.',
},
},
travelInvoicing: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 07c930c2..999a54f2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5152,14 +5152,10 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
subtitle: 'Stiamo attualmente esaminando la tua richiesta di abilitare Expensify Travel. Non preoccuparti, ti faremo sapere quando sarà pronto.',
ctaText: 'Richiesta inviata',
},
- bookOrManageYourTrip: {
- title: 'Prenotazione di viaggio',
- subtitle: 'Complimenti! Ora sei pronto per prenotare e gestire i viaggi in questo spazio di lavoro.',
- ctaText: 'Gestisci viaggi',
- },
+ bookOrManageYourTrip: {title: 'Prenotazione viaggi', subtitle: 'Complimenti! Ora puoi prenotare e gestire i viaggi in questo spazio di lavoro.', ctaText: 'Gestisci viaggi'},
settings: {
autoAddTripName: {
- title: 'Aggiungi nomi di viaggi alle spese',
+ title: 'Aggiungi i nomi dei viaggi alle spese',
subtitle: 'Aggiungi automaticamente i nomi dei viaggi alle descrizioni delle spese per i viaggi prenotati in Expensify.',
},
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 4b9fbd38..6c8ad69e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5117,7 +5117,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
ctaText: 'リクエストを送信しました',
},
bookOrManageYourTrip: {title: '出張予約', subtitle: 'おめでとうございます！このワークスペースで旅行の予約と管理を行う準備が整いました。', ctaText: '出張を管理'},
- settings: {autoAddTripName: {title: '経費に出張名を追加', subtitle: 'Expensifyで予約した出張について、経費の説明に出張名を自動的に追加します。'}},
+ settings: {autoAddTripName: {title: '経費に出張名を追加', subtitle: 'Expensifyで予約した出張について、出張名を経費の説明に自動的に追加します。'}},
travelInvoicing: {
centralInvoicingSection: {
title: '集中請求',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 41e25a41..7443582c 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5146,13 +5146,12 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
subtitle: 'We beoordelen je aanvraag om Expensify Travel in te schakelen. Maak je geen zorgen, we laten je weten wanneer het klaar is.',
ctaText: 'Verzoek verzonden',
},
- bookOrManageYourTrip: {
- title: 'Boeking van reizen',
- subtitle: 'Gefeliciteerd! Je bent helemaal klaar om reizen in deze workspace te boeken en te beheren.',
- ctaText: 'Reizen beheren',
- },
+ bookOrManageYourTrip: {title: 'Reisboeking', subtitle: 'Gefeliciteerd! Je bent helemaal klaar om reizen te boeken en beheren in deze workspace.', ctaText: 'Reizen beheren'},
settings: {
- autoAddTripName: {title: 'Reisnamen aan uitgaven toevoegen', subtitle: 'Voeg automatisch reisnamen toe aan onkostomemo’s voor reizen die in Expensify zijn geboekt.'},
+ autoAddTripName: {
+ title: 'Reisnamen aan onkosten toevoegen',
+ subtitle: 'Voeg automatisch reissnamen toe aan onkostomschrijvingen voor reizen die in Expensify zijn geboekt.',
+ },
},
travelInvoicing: {
centralInvoicingSection: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 0d6eeda3..c416024e 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5140,7 +5140,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
ctaText: 'Zarządzaj podróżami',
},
settings: {
- autoAddTripName: {title: 'Dodaj nazwy podróży do wydatków', subtitle: 'Automatycznie dodawaj nazwy podróży do opisów wydatków za podróże zarezerwowane w Expensify.'},
+ autoAddTripName: {title: 'Dodaj nazwy podróży do wydatków', subtitle: 'Automatycznie dodawaj nazwy podróży do opisów wydatków dla podróży zarezerwowanych w Expensify.'},
},
travelInvoicing: {
centralInvoicingSection: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index ec703778..c00ef9dd 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5139,12 +5139,12 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
},
bookOrManageYourTrip: {
title: 'Reserva de viagem',
- subtitle: 'Parabéns! Você já está pronto para reservar e gerenciar viagens neste workspace.',
+ subtitle: 'Parabéns! Agora você está pronto para reservar e gerenciar viagens neste workspace.',
ctaText: 'Gerenciar viagens',
},
settings: {
autoAddTripName: {
- title: 'Adicionar nomes de viagem às despesas',
+ title: 'Adicionar nomes de viagens às despesas',
subtitle: 'Adicione automaticamente os nomes das viagens às descrições das despesas para viagens reservadas no Expensify.',
},
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0edf673b..6520c4b5 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5047,8 +5047,8 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
subtitle: '我们正在审核你启用 Expensify Travel 的请求。别担心，准备好后我们会通知你。',
ctaText: '请求已发送',
},
- bookOrManageYourTrip: {title: '差旅预订', subtitle: '恭喜！您现在可以在此工作区预订和管理差旅了。', ctaText: '管理差旅'},
- settings: {autoAddTripName: {title: '将行程名称添加到报销单', subtitle: '为在 Expensify 中预订的行程，自动将行程名称添加到报销事由描述中。'}},
+ bookOrManageYourTrip: {title: '差旅预订', subtitle: '恭喜！您已准备就绪，可以在此工作区预订和管理差旅。', ctaText: '管理差旅'},
+ settings: {autoAddTripName: {title: '将行程名称添加到报销费用中', subtitle: '为在 Expensify 中预订的差旅自动将行程名称添加到报销事由中。'}},
travelInvoicing: {
centralInvoicingSection: {
title: '集中开票',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
carlosmiceli
approved these changes
Feb 10, 2026
Contributor
|
🚧 @stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
53 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.3.17-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
| export {enablePolicyTravel}; | ||
| function setPolicyTravelSettings(policyID: string, settings: Partial<OnyxTypes.WorkspaceTravelSettings>) { | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated -- Tracked in https://github.com/Expensify/Expensify/issues/507850 | ||
| const policy = PolicyUtils.getPolicy(policyID); |
Contributor
There was a problem hiding this comment.
@stitesExpensify This function was deprecated. Can you please pass the policy directly here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #80019
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari