Refactor ContextProviders with AI by staszekscp · Pull Request #80196 · Expensify/App

staszekscp · 2026-01-22T08:51:10Z

Explanation of Change

This PR migrates less complex ContextProviders using AI following the pattern from this PR. It splits ContextProviders into State and Actions in order to make sure, that if some component uses only state-agnostic actions doesn't re-render when the state changes.

Fixed Issues

$ #80271
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1768995280447999

Tests

Because the PR touches multiple areas of the app and was primarily AI-generated we would need full regression testing for it

Offline tests

QA Steps

Because the PR touches multiple areas of the app and was primarily AI-generated we would need full regression testing for it

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-01-22T09:01:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/Expensify.tsx	`84.81% <100.00%> (+0.07%)`	⬆️
src/HybridAppHandler.tsx	`60.00% <ø> (ø)`
src/SplashScreenStateContext.tsx	`83.33% <100.00%> (+8.33%)`	⬆️
...nents/ActionSheetAwareScrollView/index.android.tsx	`0.00% <ø> (ø)`
...omponents/ActionSheetAwareScrollView/index.ios.tsx	`0.00% <ø> (ø)`
...rc/components/ActionSheetAwareScrollView/index.tsx	`0.00% <ø> (ø)`
...etAwareScrollView/useActionSheetKeyboardSpacing.ts	`0.00% <ø> (ø)`
...onents/BlockingViews/ForceFullScreenView/index.tsx	`0.00% <ø> (ø)`
src/components/EmojiPicker/EmojiPickerButton.tsx	`81.81% <ø> (ø)`
src/components/ErrorBoundary/BaseErrorBoundary.tsx	`66.66% <ø> (ø)`
... and 48 more
... and 11 files with indirect coverage changes

…y. Introduced separate hooks for accessing state and actions. Updated imports across components to use the new hooks.

github-actions · 2026-01-22T15:44:26Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-01-22T15:50:42Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2026-01-22T16:17:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80196.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d413acf15b6c568db1ae6cdc9434a9150d24ccda/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f25d2207cb55dfbd478acb2a17f9aa4cd3c713a6/index.html

Web 🕸️
https://80196.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2026-01-22T22:04:26Z

@mkhutornyi feel free to review please, our goal is to test through the various flow if there are no obvious issues and then ask QA for full regression testing

mkhutornyi · 2026-01-23T08:08:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

mkhutornyi

Confirmed all components that removed manual memoization are ✨ and commented accordingly.

chatgpt-codex-connector · 2026-01-23T08:36:34Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-01-23T10:35:23Z

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

@@ -549,6 +551,7 @@ function IOURequestStepScan({
                        Log.warn('Error taking photo', error);
                    });
            });
+        // eslint-disable-next-line react-hooks/exhaustive-deps -- askForPermissions is not needed


The comment should be the reason why not needed, not what is not needed.
As missing dependencies already existed, out of scope for this PR.

mountiny · 2026-01-24T16:24:36Z

Thank you! requested the adhoc build https://expensify.slack.com/archives/C09V78U42D8/p1769271852640199

heyjennahay

Product review not required

IuliiaHerets · 2026-01-27T15:54:22Z

@mountiny, regression has been completed.
No issues were found in this build.

OSBotify · 2026-01-27T21:39:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

m-natarajan · 2026-01-28T23:17:10Z

@staszekscp @MonilBhavsar @mountiny Missing QA steps, Can you please help with the QA steps for this.

mkhutornyi · 2026-01-28T23:18:58Z

As stated, we need full regression testing. No specific pages to focus on test

OSBotify · 2026-01-28T23:21:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:19:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Refactor PopoverContextProvider with AI

1145b83

melvin-bot bot assigned staszekscp Jan 22, 2026

Refactor CurrentReportIDContextProvider with AI

d1d85da

staszekscp and others added 15 commits January 22, 2026 10:33

Refactor ActionSheetAwareScrollViewProvider with AI

0fa227b

Fix linter and prettier

168ff46

Refactor KeyboardDismissibleFlatListContext with AI

38d872d

Refactor InputBlurContext with AI

d3e08b8

Refactor FullScreenBlockingViewContextProvider with AI

e114721

Refactor FullScreenLoaderContext with AI

721f127

Refactor ExpensifyCardContextProvider with AI

0413670

Refactor InitialURLContextProvider with AI

1bdfd17

Refactor SplashScreenStateContext to improve performance and usabilit…

da16eaf

…y. Introduced separate hooks for accessing state and actions. Updated imports across components to use the new hooks.

Fix linter errors

3b0152d

Fix prettier

7752661

Remove lint errors

9d07fe2

Fix TS

b017bb7

Fix TS

fd523b9

Fix linter

dbcfe1d

mountiny requested review from mkhutornyi and mountiny January 22, 2026 21:14

mountiny marked this pull request as ready for review January 22, 2026 22:03

mountiny requested review from a team as code owners January 22, 2026 22:03

melvin-bot bot requested review from heyjennahay and removed request for a team January 22, 2026 22:04

mkhutornyi reviewed Jan 23, 2026

View reviewed changes

mkhutornyi approved these changes Jan 23, 2026

View reviewed changes

mountiny mentioned this pull request Jan 24, 2026

Refactor SplashScreenStateContext to improve performance and usability #80123

Closed

51 tasks

heyjennahay reviewed Jan 26, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into perf/refactor-contexts

7a4b2d2

mountiny previously approved these changes Jan 27, 2026

View reviewed changes

Merge branch 'main' into perf/refactor-contexts

d8305dc

adamgrzybowski dismissed mountiny’s stale review via d8305dc January 27, 2026 18:39

Merge branch 'main' into perf/refactor-contexts

a9e0aae

mountiny previously approved these changes Jan 27, 2026

View reviewed changes

adamgrzybowski dismissed mountiny’s stale review via 2f0532e January 27, 2026 19:41

mountiny previously approved these changes Jan 27, 2026

View reviewed changes

adamgrzybowski dismissed mountiny’s stale review via 7d86353 January 27, 2026 20:49

adamgrzybowski added 2 commits January 27, 2026 13:07

fix linting

b6547d5

Merge branch 'main' into perf/refactor-contexts

97034b3

adamgrzybowski force-pushed the perf/refactor-contexts branch from 7d86353 to 97034b3 Compare January 27, 2026 21:10

mountiny approved these changes Jan 27, 2026

View reviewed changes

mountiny merged commit ba7277b into Expensify:main Jan 27, 2026
29 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

grgia mentioned this pull request Jan 30, 2026

[$250] LHN - The chat is in unread status, the deleted message is still shown in LHN #80827

Closed

7 tasks

Conversation

staszekscp commented Jan 22, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 22, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

melvin-bot bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

mountiny commented Jan 22, 2026

Uh oh!

mkhutornyi commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Jan 23, 2026

Uh oh!

mkhutornyi Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 24, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

IuliiaHerets commented Jan 27, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

m-natarajan commented Jan 28, 2026

Uh oh!

mkhutornyi commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

staszekscp commented Jan 22, 2026 •

edited by mountiny

Loading

codecov bot commented Jan 22, 2026 •

edited by github-actions bot

Loading

mkhutornyi commented Jan 23, 2026 •

edited

Loading