Accessibility/ add autoComplete attributes by ChavdaSachin · Pull Request #80214 · Expensify/App

ChavdaSachin · 2026-01-22T12:09:18Z

Explanation of Change

Fixed Issues

$ #79246
PROPOSAL: #79246 (comment)

Tests

Same as QA.

Verify that no errors appear in the JS console

Offline tests

Same as QA.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisites: User has configured browser for autofill.
Test 1.

Go to Account -> Profile -> Display Name.
Clear existing values(if any) click again on First Name/ Last Name input field.
Verify autoComplete suggestions pops up and clicking a suggestion should autoComplete the input fields.
Go to Profile -> Phone number.
Clear existing values(if any) click again on the input field.
Verify autoComplete suggestions pops up and clicking a suggestion should autoComplete the input fields.
Go to Profile -> Address.
Clear existing values(if any).
Verify autoComplete suggestions pops up for each of Address Line 1, Address Line 2 and ZIP / Postcode input fields and clicking a suggestion should autoComplete the input fields.

Test 2. (Web-only test)

Go to Accounts -> Subscriptions -> Add payment card.
Clear existing values(if any) click again on any of the input field.
Verify autoComplete suggestions pops up and clicking a suggestion should autoComplete the input fields.

Test 3.

Create a new account, and reach the work email step.
On work Email page - Verify autoComplete suggestions pops up and clicking a suggestion should autoComplete the input fields.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

WhatsApp.Video.2026-02-05.at.19.24.51.mp4

WhatsApp.Video.2026-02-05.at.19.24.48.mp4

Android: mWeb Chrome

WhatsApp.Video.2026-02-05.at.19.29.55.1.mp4

WhatsApp.Video.2026-02-05.at.19.29.55.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.5.13.50.PM.mov

Screen.Recording.2026-01-29.at.5.15.21.PM.mov

melvin-bot · 2026-01-22T12:09:26Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-01-22T12:18:59Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/AddPaymentCard/PaymentCardChangeCurrencyForm.tsx	`0.00% <ø> (ø)`
src/components/AddPaymentCard/PaymentCardForm.tsx	`92.64% <ø> (ø)`
src/components/AddressForm.tsx	`98.00% <ø> (ø)`
src/components/AddressSearch/index.tsx	`48.03% <100.00%> (+0.51%)`	⬆️
src/components/SubStepForms/DateOfBirthStep.tsx	`0.00% <ø> (ø)`
src/components/SubStepForms/FullNameStep.tsx	`0.00% <ø> (ø)`
.../pages/MissingPersonalDetails/subPages/Address.tsx	`0.00% <ø> (ø)`
...gPersonalDetails/BaseOnboardingPersonalDetails.tsx	`91.07% <100.00%> (+0.16%)`	⬆️
...es/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx	`86.48% <ø> (ø)`
...c/pages/ReimbursementAccount/AddressFormFields.tsx	`0.00% <ø> (ø)`
... and 9 more
... and 408 files with indirect coverage changes

ChavdaSachin · 2026-01-22T13:26:56Z

@rushatgabhane @situchan
There are two input fields which accept both email and phone number as input

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Line 147 in e8cd714

<InputWrapper

App/src/pages/TeachersUnite/KnowATeacherPage.tsx

Line 120 in e8cd714

<InputWrapper

So in general there's no option to allow multiple fields for autoComplete, so I guess we could choose one of the email or tel as autoComplete attribute.

Also currently datePicker does not support autoComplete feature, but datePicker is soon to be re-developed so I've added the autoComplete attribute here and here which would be reminder to implement autoComplete features for new datePicker input component.

situchan · 2026-01-22T13:45:05Z

So in general there's no option to allow multiple fields for autoComplete, so I guess we could choose one of the email or tel as autoComplete attribute.

I am fine to use email as it's popular. Curious for thoughts from others

Also currently datePicker does not support autoComplete feature, but datePicker is soon to be re-develope

Can you link to issue or discussion?

ChavdaSachin · 2026-01-22T14:08:24Z

https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1768319127115199?thread_ts=1768190803.080029&cid=C01GTK53T8Q
Slack discussion where it was decided to redesign the datePicker...

rushatgabhane · 2026-01-24T07:52:34Z

Also currently datePicker does not support autoComplete feature,

yeah that sounds good

regarding phone vs email, we don't have to pick anything. we can choose one or do nothing

best to ask @dubielzyk-expensify on slack

#80214 (comment)

ChavdaSachin · 2026-01-26T14:35:17Z

@rushatgabhane @situchan There are two input fields which accept both email and phone number as input

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Line 147 in e8cd714

<InputWrapper

App/src/pages/TeachersUnite/KnowATeacherPage.tsx

Line 120 in e8cd714

<InputWrapper

So in general there's no option to allow multiple fields for autoComplete, so I guess we could choose one of the email or tel as autoComplete attribute.
Also currently datePicker does not support autoComplete feature, but datePicker is soon to be re-developed so I've added the autoComplete attribute here and here which would be reminder to implement autoComplete features for new datePicker input component.

@situchan's suggestion : I am fine to use email as it's popular. Curious for thoughts from others

@dubielzyk-expensify could you provide a confirmation so we could move forward.
Thanks

dubielzyk-expensify · 2026-01-26T17:22:57Z

I'm not sure what the right answer is here. Since we accept both number and email then I wonder if we should just not apply the autocomplete attribute at all. It doesn't quite make sense to me. cc @Expensify/design

dannymcclain · 2026-01-26T21:39:07Z

I think it would be good to go with email since that's likely to be the more popular option. But just for clarity, if we add autocomplete for email, the user would still be able to just type in their phone number same as today right?

shawnborton · 2026-01-27T08:23:59Z

regarding phone vs email, we don't have to pick anything. we can choose one or do nothing

I kinda think we would just do nothing here so we don't have to pick one or the other, since both are equally acceptable for us. How does that work with accessibility though? Is that an option we have?

dubielzyk-expensify · 2026-01-27T20:51:31Z

I don't think there's a perfect answer. I see where Danny is coming from, but I'm thinking that we shouldn't add anything since there's no one right autocomplete.

Accessibility rules just generally recommend doing it to ensure users have to type less than they need. Give them a helping hand.

dannymcclain · 2026-01-27T20:58:50Z

Cool cool, if you all both feel like we should just not autocomplete anything, that's totally fine with me.

shawnborton · 2026-01-28T05:43:29Z

I really don't feel too strongly, so happy to let you all decide!

…utocomplete-attributes

dubielzyk-expensify · 2026-01-28T17:25:44Z

Cool. I say let's do nothing and move onto the next few issues

ChavdaSachin · 2026-01-28T17:41:24Z

Great, then PR should be ready for review within next 24 hrs.

ChavdaSachin · 2026-01-29T14:51:26Z

PR is kinda ready but I am unable to test it on iOS emulator. As emulator does not provide options to setup autofill.
Would once again tomorrow look into it, or we'll be require to test it using adHoc build.

melvin-bot · 2026-02-02T23:17:36Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-03T01:13:08Z

🚧 @chiragsalian has triggered a test Expensify/App build. You can view the workflow run here.

ChavdaSachin · 2026-02-03T15:20:20Z

I was ooo today, I should update videos tomorrow.
Sorry for the delay.

situchan · 2026-02-05T10:17:52Z

Please merge main

chatgpt-codex-connector · 2026-02-05T10:46:29Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ChavdaSachin · 2026-02-05T13:49:31Z

@codex review

…utocomplete-attributes

ChavdaSachin · 2026-02-05T14:04:55Z

Merged main
Added the Android tests, I do't have access to an iOS device so that has to be done by QA.

Ready for review.

chatgpt-codex-connector · 2026-02-05T14:10:38Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-02-11T21:51:56Z

Please fix conflict and lint

…utocomplete-attributes

ChavdaSachin · 2026-02-13T14:43:55Z

Merged main, ready for final review

situchan · 2026-02-18T15:59:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-18.at.10.14.58.PM.mov

src/components/AddressSearch/types.ts

src/pages/ReimbursementAccount/AddressFormFields.tsx

github-actions · 2026-02-19T21:01:12Z

🚧 @chiragsalian has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-19T21:05:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80214.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3a9707b-1fe8027-9f4bae31f0820d093e22a2b27ecdb8bdf6cea757/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3a9707b-1fe8027-8970d98e20f59e4f456faea2d2ac963d5f0195ce/index.html

Web 🕸️
https://80214.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-19T21:09:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-20T16:42:28Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.3.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-23T21:44:10Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add autoComplete attributes

82195eb

melvin-bot bot assigned ChavdaSachin Jan 22, 2026

ChavdaSachin added 3 commits January 22, 2026 18:42

lint

4fd9130

add autoComplete attributes

853b9ec

add autoComplete attributes

0533019

Merge remote-tracking branch 'upstream/main' into Accessibility/Add-a…

ec6aad6

…utocomplete-attributes

ChavdaSachin marked this pull request as ready for review February 2, 2026 23:17

ChavdaSachin requested review from a team as code owners February 2, 2026 23:17

melvin-bot bot requested review from heyjennahay and situchan and removed request for a team February 2, 2026 23:17

melvin-bot bot removed the request for review from a team February 2, 2026 23:17

chiragsalian added the Ready To Build label Feb 3, 2026

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'upstream/main' into Accessibility/Add-a…

b4fafb5

…utocomplete-attributes

Merge remote-tracking branch 'upstream/main' into Accessibility/Add-a…

bac9fe6

…utocomplete-attributes

situchan reviewed Feb 18, 2026

View reviewed changes

src/components/AddressSearch/types.ts Outdated Show resolved Hide resolved

Improve type signature

ca8ba88

situchan approved these changes Feb 18, 2026

View reviewed changes

melvin-bot bot requested a review from chiragsalian February 18, 2026 16:24

chiragsalian reviewed Feb 18, 2026

View reviewed changes

src/pages/ReimbursementAccount/AddressFormFields.tsx Show resolved Hide resolved

chiragsalian approved these changes Feb 19, 2026

View reviewed changes

chiragsalian merged commit 3a9707b into Expensify:main Feb 19, 2026
33 checks passed

OSBotify mentioned this pull request Feb 20, 2026

Deploy Checklist: New Expensify 2026-02-20 #83077

Closed

67 tasks

melvin-bot bot mentioned this pull request Feb 23, 2026

[Due for payment 2026-03-02] [$250][Accessibility][Tracking] Add Autocomplete Attributes #79246

Closed

Conversation

ChavdaSachin commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 22, 2026

Uh oh!

codecov bot commented Jan 22, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ChavdaSachin commented Jan 22, 2026

Uh oh!

situchan commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChavdaSachin commented Jan 22, 2026

Uh oh!

rushatgabhane commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChavdaSachin commented Jan 26, 2026

Uh oh!

dubielzyk-expensify commented Jan 26, 2026

Uh oh!

dannymcclain commented Jan 26, 2026

Uh oh!

shawnborton commented Jan 27, 2026

Uh oh!

dubielzyk-expensify commented Jan 27, 2026

Uh oh!

dannymcclain commented Jan 27, 2026

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

dubielzyk-expensify commented Jan 28, 2026

Uh oh!

ChavdaSachin commented Jan 28, 2026

Uh oh!

ChavdaSachin commented Jan 29, 2026

Uh oh!

melvin-bot bot commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

This comment has been minimized.

ChavdaSachin commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 5, 2026

Uh oh!

ChavdaSachin commented Feb 5, 2026

Uh oh!

ChavdaSachin commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 5, 2026

Uh oh!

situchan commented Feb 11, 2026

Uh oh!

ChavdaSachin commented Feb 13, 2026

Uh oh!

situchan commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

ChavdaSachin commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited by github-actions bot

Loading

situchan commented Jan 22, 2026 •

edited

Loading

rushatgabhane commented Jan 24, 2026 •

edited

Loading

ChavdaSachin commented Feb 3, 2026 •

edited

Loading

ChavdaSachin commented Feb 5, 2026 •

edited

Loading

situchan commented Feb 18, 2026 •

edited

Loading