[No QA] HelpDot: add New Expensify domain members docs (Release 2/3)

[twisterdotcom]

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/577567

Adds New Expensify help docs for Domain Members and Domain Migration.

Tests

• N/A (docs-only)

Web QA
N/A

Mobile QA
No mobile QA

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR introduces two new documentation articles for domain management in New Expensify: Domain Members and Domain Migration. Both documents are well-structured, clear, and provide practical guidance for Domain Admins. The content demonstrates good organization with logical flow and actionable instructions. However, there are several areas where AI readiness and style compliance could be improved to meet Expensify standards.

Scores Summary

• Readability: 8/10 - Clear, well-organized content with good use of headings and logical flow. Instructions are actionable and easy to follow. Minor improvements needed in consistency and some phrasing.
• AI Readiness: 6/10 - Missing critical YAML metadata fields (breadcrumbs, schema), inconsistent heading hierarchy (uses H1 when only H2 should be used), and some vague references that need more context.
• Style Compliance: 7/10 - Generally follows Expensify conventions but has terminology inconsistencies ("Workspaces" vs workspace name, "click" vs "select"), and inconsistent UI element formatting.

Key Findings

Positive Aspects:

• Excellent use of task-based structure ("Add a Domain Member", "Close a Domain Member Account")
• Clear distinction between different member types (Domain Member vs Domain Admin)
• Helpful contextual notes and warnings (e.g., Expensify Card migration warning)
• Good use of cross-references to related documentation
• Well-organized step-by-step instructions

Critical Issues:

1. YAML Metadata Incomplete - Missing required fields:

   • No breadcrumbs field for navigation context
   • No schema field with @type and other structured data
   • Keywords could be more comprehensive

2. Heading Hierarchy Issues - Using H1 (#) headings when Expensify style requires only H2 (##) for section headings within articles

3. Terminology Inconsistencies:

   • Using "Workspaces" in navigation paths (should be specific workspace name or generic "workspace")
   • Mixing "click" and "select" for UI actions
   • Inconsistent formatting of UI elements (some bold, some not)

4. Vague References:

   • "Domain Members page" mentioned without full context
   • Some procedural steps lack sufficient context for AI assistants

Recommendations

Priority Actions Needed:

1. Add complete YAML frontmatter with breadcrumbs and schema fields to both files
2. Change all H1 headings (#) to H2 headings (##) within article body
3. Standardize UI action verbs (prefer "select" over "click")
4. Add consistent bold formatting for all UI elements and button labels
5. Review and standardize navigation paths to avoid generic "Workspaces" references

Suggestions for Improvement:

1. Expand the description field to be more detailed and SEO-friendly
2. Add more specific keywords related to common user queries
3. Consider adding a brief overview/introduction before diving into procedures
4. Ensure all cross-references use full descriptive titles
5. Add more context around edge cases and troubleshooting scenarios

Files Reviewed

• docs/articles/new-expensify/domains/Domain-Members.md - Well-structured member management guide with clear procedures, needs YAML and heading hierarchy fixes
• docs/articles/new-expensify/domains/Domain-Migration.md - Comprehensive migration guide with good warning notices, needs YAML metadata and terminology standardization

Note: Detailed line-by-line feedback will be provided as inline comments.

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://e9226310.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/domains/Domain-Migration
• articles/new-expensify/domains/Manage-Domain-Members

[twisterdotcom]

I think we can go on this now @stephanieelliott.

[stephanieelliott]

Made a few changes, feel free to merge @twisterdotcom!

[stephanieelliott]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[twisterdotcom]

I can't merge as I'm an author too!

[melvin-bot]

Concierge reviewer checklist:

• I have verified the accuracy of the article
  • The article is within a hub that makes sense, and the navigation is correct
  • All processes, screenshots, and examples align with current product behavior.
  • All links within the doc have been verified for correct destination and functionality.
• I have verified the readability of the article
  • The article's language is clear, concise, and free of jargon.
  • The grammar, spelling, and punctuation are correct.
  • The article contains at least one image, or that an image is not necessary
• I have verified the formatting of the article
  • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
  • The article has proper text spacing and breaks for readability.
• I have verified the article has the appropriate tone and style
  • The article's tone is professional, friendly, and suitable for the target audience.
  • The article's tone, terminology, and voice are consistent throughout.
• I have verified the overall quality of the article
  • The article is not missing any information, nor does it contain redundant information.
  • The article fully addresses user needs.
• I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

[melvin-bot]

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[twisterdotcom]

@bfitzexpensify could you merge this please?

[OSBotify]

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪