GPS tooltip as ProductTrainingTooltip#80351
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@joekaufmanexpensify and @rlinoz please ignore, @AndrewGable and @dukenv0307 will review |
src/pages/iou/request/step/IOURequestStepDistanceGPS/Waypoints/index.tsx
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-27.at.00.07.59.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-01-27.at.00.07.05.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #80502. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.9-0 🚀
|
|
This PR failing because of the issue |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
After the discussion here we decided to change the UX of the GPS tooltip by not showing it ever again for the user if they have ever closed it, instead of not showing it after user has ever created a GPS expense.
Because of that, in this PR the GPS tooltip is now controlled by
NVP_DISMISSED_PRODUCT_TRAININGanduseProductTrainingContentinstead ofNVP_FIRST_CREATED_GPS_EXPENSE_DATE_NEW_DOTwhich is now removed in the frontend and will be removed in the backend soon.Fixed Issues
$ part of #73261
PROPOSAL: N/A
Tests
With closing the tooltip
Without closing the tooltip
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-23.at.15.01.04.mov
iOS: Native
Screen.Recording.2026-01-23.at.15.12.53.mov
Screen.Recording.2026-01-23.at.15.13.18.mov