fix: Animation: Many Pages: The displayed animation cannot be stopped or paused#80454
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c14aaefe3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
No product considerations, removing my review |
…on-Many-Pages-The-displayed-animation-cannot-be-stopped-or-paused
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76262aa772
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@dubielzyk-expensify From your comment here, I don't think you'd be expecting the illustration to be hidden altogether when reduced motion is enabled? |
|
No, never hidden, but paused when reduced motion is enabled |
|
@TaduJR Sorry I missed in your proposal that you were hiding the animations, we just want to pause them instead. Or was there a reason why you were suggesting to hide them? |
…on-Many-Pages-The-displayed-animation-cannot-be-stopped-or-paused
|
Thanks for the feedback!
My initial proposal was to pause the animations.
But I migrated to hide and forgot to comment if there was any suggestion from the product team. Here's the reasoning behind the current approach:
I can update the implementation to:
Let me know if you'd like me to make this change cc: @dubielzyk-expensify References: https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide.html
Appt.org (React Native specific) https://appt.org/en/docs/react-native/samples/reduced-animations
|
|
Hey @jjcoffee Sorry I should have made it draft, I am discovering other animations on the codebase. |
…on-Many-Pages-The-displayed-animation-cannot-be-stopped-or-paused
…yles to prevent web crash
…on-Many-Pages-The-displayed-animation-cannot-be-stopped-or-paused
…on-Many-Pages-The-displayed-animation-cannot-be-stopped-or-paused
…n reduced motion is enabled
|
It's ready for re-review @jjcoffee |
src/pages/TeachersUnite/useSaveTheWorldSectionIllustration/index.native.ts
Outdated
Show resolved
Hide resolved
…ustration hook, reduce duplication
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5a72305e5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Friendly Bump @aldo-expensify on this one. Thanks! |
|
🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
This PR adds support for the system's "Reduce Motion" accessibility setting to disable Lottie animations throughout the app, addressing WCAG 2.2.2 (Pause, Stop, Hide) compliance.
Fixed Issues
$ #77157
PROPOSAL: #77157 (comment)
Tests
Prerequisites
Sign In Page (Native)
Sign In Page (Web)
Settings Pages (Native only — these pages use static SVGs on web)
Runtime Toggle (Dynamic Update)
Other pages to verify (with Reduce Motion enabled)
On Save the world - animation paused, illustration visible
On Reports - animation paused, illustration visible
Verify that no errors appear in the JS console
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260131_144840_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260131_142246_Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-Safari.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-01-31.at.2.51.35.in.the.afternoon.mov