fix: update RNKC and RNPV to latest versions #80478

kirillzyusko · 2026-01-26T11:16:40Z

Explanation of Change

Fixed an issue with missing keyboard animations.

Fixed Issues

$ #79512
$ #75139
$ #79313
PROPOSAL: N/A

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13833

Tests

Keyboard composer in chat

open Hybrid app
switch to NewDot app
open any chat
focus composer
make sure that keyboard appears with animation and content moves with animation

Keyboard composer in chat with A11Y features turned on

open Setting -> Accessibility -> Motion
enabled "Reduce Motion" + "Prefer Cross-Fade Transitions"
open any chat
focus composer
make sure that keyboard appears with animation and content moves with animation

No crash after creating expenses

Launch Hybrid app
Create new account & workspace
Enable Perdiem feature & import rates
Go to Inbox >> tap FAB >> Create Expense
Make sure you are on Scan tab
Upload multiple receipts (around 2-3) choosing from gallery
Tap Remove this expense button >> Tap Cancel button (this is important step)
Tap Remove this expense button again >> Confirm Remove
Tap left back button to cancel scan expense flow
Tap back button to go to Inbox
Tap FAB >> Create expense
Make sure you are on Scan tab
Tap Per diem tab
Make sure that app is not crashing

Offline tests

N/A

QA Steps

Keyboard composer in chat

open Hybrid app
switch to NewDot app
open any chat
focus composer
make sure that keyboard appears with animation and content moves with animation

Keyboard composer in chat with A11Y features turned on

open Setting -> Accessibility -> Motion
enabled "Reduce Motion" + "Prefer Cross-Fade Transitions"
open any chat
focus composer
make sure that keyboard appears with animation and content moves with animation

No crash after creating expenses

Launch Hybrid app
Create new account & workspace
Enable Perdiem feature & import rates
Go to Inbox >> tap FAB >> Create Expense
Make sure you are on Scan tab
Upload multiple receipts (around 2-3) choosing from gallery
Tap Remove this expense button >> Tap Cancel button (this is important step)
Tap Remove this expense button again >> Confirm Remove
Tap left back button to cancel scan expense flow
Tap back button to go to Inbox
Tap FAB >> Create expense
Make sure you are on Scan tab
Tap Per diem tab
Make sure that app is not crashing

PR Author Checklist

Screenshots/Videos

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-26.at.12.19.27.mov

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-26.at.12.18.39.mov

Android: Native

Android: mWeb Chrome

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-26T11:16:50Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2026-01-26T11:20:40Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2026-01-26T11:21:22Z

@mountiny may I kindly ask you to create an Ad-Hoc build for this PR? And maybe assing @ZhenjaHorbach as a reviewer, since he reviewed original PR that got reverted?

ZhenjaHorbach · 2026-01-26T11:22:45Z

package.json

    "react-native-nitro-sqlite": "9.2.0",
    "react-native-onyx": "3.0.31",
-    "react-native-pager-view": "7.0.2",
+    "react-native-pager-view": "8.0.0",


Do we also need to update react-native-pager-view?

Yes, this is a fix for #79313 🤞

ZhenjaHorbach · 2026-01-26T11:23:16Z

@mountiny may I kindly ask you to create an Ad-Hoc build for this PR? And maybe assing @ZhenjaHorbach as a reviewer, since he reviewed original PR that got reverted?

No worries
I'm already assigned here 😅
But yes
It's better to run adhoc builds in any case

mountiny · 2026-01-26T23:50:55Z

Running, thanks

github-actions · 2026-01-26T23:51:22Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2026-01-27T00:30:21Z

Seems to work well for me

Conflicts

kirillzyusko · 2026-01-27T11:53:38Z

Conflicts

Resolved @mountiny 👍

ZhenjaHorbach · 2026-01-27T19:05:41Z

I will test tomorrow!

ZhenjaHorbach · 2026-01-28T08:55:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screenrecorder-2026-01-29-13-45-05-337.mp4

Screenrecorder-2026-01-29-13-46-25-693.mp4

Screenrecorder-2026-01-29-13-48-35-37.mp4

Android: mWeb Chrome

Screenrecorder-2026-01-29-13-52-49-349.mp4

Screenrecorder-2026-01-29-13-55-10-655.mp4

Screenrecorder-2026-01-29-13-55-40-128.mp4

iOS: HybridApp

IMG_3835.MP4

IMG_3836.MP4

IMG_3837.MP4

iOS: mWeb Safari

IMG_3833.MP4

IMG_3834.MP4

IMG_3831.MP4

MacOS: Chrome / Safari

2026-01-29.12.45.12.mov

ZhenjaHorbach · 2026-01-28T08:56:07Z

@kirillzyusko
Conflicts again 😢

ZhenjaHorbach · 2026-01-28T09:16:47Z

Strange
On web adhoc build, the attachment picker is not working

2026-01-28.10.15.00.mov

kirillzyusko · 2026-01-28T09:23:47Z

Conflicts again 😢

Resolved!

kirillzyusko · 2026-01-28T09:25:13Z

Strange
On web adhoc build, the attachment picker is not working

Oh, wow, it's really strange. Though I don't think react-native-keyboard-controller or react-native-pager-view can cause it?..

kirillzyusko · 2026-01-28T09:30:24Z

@ZhenjaHorbach I tested locally after pulling in main branch and locally it works well... Do you think this bug could be fixed somewhere in latest main?

ZhenjaHorbach · 2026-01-28T09:31:11Z

Strange
On web adhoc build, the attachment picker is not working

Oh, wow, it's really strange. Though I don't think react-native-keyboard-controller or react-native-pager-view can cause it?..

Yeah
But I don't have this issue on the last main and staging

And this issue is related to tabs
So, probably it came from react-native-pager-view

ZhenjaHorbach · 2026-01-28T09:52:49Z

@mountiny
Could you please trigger adhoc builds again?

github-actions · 2026-01-29T00:13:04Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-29T00:40:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80478.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-49779be571d24087afa6e904a82aacf23417de12/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cc1545a582d33b9a1fb24118c989783da68d1e37/index.html

Web 🕸️
https://80478.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2026-01-29T13:12:01Z

LGTM!
@kirillzyusko
And could you open a PR for Mobile-Expensify ?

mountiny

@kirillzyusko @chrispader yeah we also will need the Mobile-Expensify PR I believe, can you raise that before we proceed?

chrispader · 2026-01-30T10:08:11Z

@kirillzyusko @chrispader yeah we also will need the Mobile-Expensify PR I believe, can you raise that before we proceed?

@mountiny on it!

codecov · 2026-01-30T10:25:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 3 files with indirect coverage changes

chrispader · 2026-01-30T10:28:09Z

@mountiny @kirillzyusko HybridApp PR is ready and linked in the description

mountiny · 2026-02-02T06:27:47Z

Thanks, sorry now this PR has conflicts 🙈 Can you please resolve it?

kirillzyusko · 2026-02-02T10:33:11Z

@mountiny resolved 🙌

OSBotify · 2026-02-03T06:22:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-24 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

melvin-bot bot assigned kirillzyusko Jan 26, 2026

kirillzyusko marked this pull request as ready for review January 26, 2026 11:20

kirillzyusko requested a review from a team as a code owner January 26, 2026 11:20

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team January 26, 2026 11:20

ZhenjaHorbach reviewed Jan 26, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

ZhenjaHorbach approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot requested a review from madmax330 January 29, 2026 13:11

chrispader mentioned this pull request Jan 29, 2026

feat: Migrate lists to interactive keyboard dismissal #71440

Open

51 tasks

mountiny previously approved these changes Jan 29, 2026

View reviewed changes

chrispader dismissed mountiny’s stale review via 9446322 January 30, 2026 10:14

kirillzyusko added 2 commits February 2, 2026 11:21

fix: update RNKC and RNPV to latest versions

70064d6

fix: changes after rebase

fb7aee0

kirillzyusko force-pushed the fix/keyboard-controller-missing-animations-v3 branch from 9446322 to fb7aee0 Compare February 2, 2026 10:32

mountiny approved these changes Feb 3, 2026

View reviewed changes

mountiny merged commit b7dc545 into Expensify:main Feb 3, 2026
36 checks passed

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

OSBotify mentioned this pull request Feb 3, 2026

iOS - Track distance - Details on Confirm details page are hidden behind the empty space #81285

Open

7 tasks

mountiny mentioned this pull request Feb 3, 2026

[CP Staging] Revert "fix: update RNKC and RNPV to latest versions" #81359

Merged

fix: update RNKC and RNPV to latest versions #80478

fix: update RNKC and RNPV to latest versions #80478

Conversation

kirillzyusko commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Keyboard composer in chat

Keyboard composer in chat with A11Y features turned on

No crash after creating expenses

Offline tests

QA Steps

Keyboard composer in chat

Keyboard composer in chat with A11Y features turned on

No crash after creating expenses

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

melvin-bot bot commented Jan 26, 2026

Uh oh!

kirillzyusko commented Jan 26, 2026

Uh oh!

ZhenjaHorbach Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

kirillzyusko Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

This comment has been minimized.

mountiny commented Jan 27, 2026

Uh oh!

kirillzyusko commented Jan 27, 2026

Uh oh!

ZhenjaHorbach commented Jan 27, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirillzyusko commented Jan 28, 2026

Uh oh!

kirillzyusko commented Jan 28, 2026

Uh oh!

kirillzyusko commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

ZhenjaHorbach commented Jan 29, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

chrispader commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirillzyusko commented Jan 26, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 26, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 28, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading