Update create transaction Manual flow to ask for merchant after asking for amount v2#80480
Conversation
…hant after asking for amount""
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Krishna2323 To avoid reverting again, I think we can request the QA to test this PR after the review is done. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 702485c5eb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
V2 of a product change agreed upon in slack. 👍
|
@Krishna2323 Friendly bump. |
|
Will be reviewing this today. |
|
Reviewing... |
|
@nkdengineer The merchant field shows as required for the P2P option. Steps to reproduce:
Monosnap.screencast.2026-01-30.18-41-11.mp4 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@nkdengineer bump |
|
@Krishna2323 I updated. |
|
@nkdengineer could you please merge main? I can't start the send invoice flow: Monosnap.screencast.2026-02-05.04-10-12.mp4 |
Co-authored-by: Carlos Alvarez <cead22@gmail.com>
…com/nkdengineer/App into revert-80286-revert-76595-fix/76050
|
@Krishna2323 can you please give it a final review? |
|
Reviewing... |
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM and works well! 🚀
|
🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.17-0 🚀
|
|
This PR failing (Test Case 7) because of the issue 1.mp4 |
@jponikarchuk, sorry the test step is wrong. I updated this test case, this one is working as expected. |
|
@nkdengineer Thanks |
|
Could you please confirm if we should enter Merchant and save at step 6 (Test Case 7) to Bug7074523_1770806879005.bandicam_2026-02-11_13-42-39-186.mp4 |
|
@jponikarchuk You're right, I updated the test steps |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
Explanation of Change
Update create transaction Manual flow to ask for merchant after asking for amount
Fixed Issues
$ #76050
PROPOSAL: #76050 (comment)
Tests
Pre-requisites
Test Case 1: Manual Expense from Workspace Chat (Primary Flow)
Steps:
Test Case 2: Global Create with Default Workspace
Steps:
Test Case 3: Global Create without Default Workspace (Participants Flow)
Steps:
Test Case 4: P2P (Personal) Transaction – No Merchant Step
Steps:
Test Case 5: Scan Request – No Merchant Step
Steps:
Test Case 6: Participants – Select Personal Chat (No Merchant Step)
Steps:
Test Case 7: Self DM Expense – Move to Workspace (Without Merchant)
Steps:
Test Case 8: Self DM Expense – Move to Workspace (With Merchant)
Steps:
Test Case 9: Track Expense from Workspace Chat and FAB (Both)
Steps:
Test Case 10: Track Expense (Manual) from Workspace Chat and FAB (Both)
Steps:
Precondition:
Precondition:
Precondition:
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-03.at.15.27.09.mov
Android: mWeb Chrome
Screen.Recording.2025-12-03.at.15.26.38.mov
iOS: Native
Screen.Recording.2025-12-03.at.15.25.37.mov
iOS: mWeb Safari
Screen.Recording.2025-12-03.at.15.24.18.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-03.at.15.23.20.mov
Screen.Recording.2025-12-03.at.15.35.10.mov
Screen.Recording.2026-01-28.at.01.05.58.mov
Screen.Recording.2026-01-28.at.01.06.29.mov
Screen.Recording.2026-01-28.at.01.06.56.mov
Screen.Recording.2026-01-28.at.01.07.22.mov
Screen.Recording.2026-01-28.at.01.07.42.mov
Screen.Recording.2026-01-28.at.01.09.16.mov