Added accessibilityRole header to visual headings for screen readers by abbasifaizan70 · Pull Request #80538 · Expensify/App

abbasifaizan70 · 2026-01-26T20:45:02Z

Explanation of Change

Added accessibilityRole="header" to all visual headings so screen readers announce them as headings, improving page structure and navigation across the app.

Fixed Issues

$ #79241
PROPOSAL: #79241 (comment)

Tests

Verify that no errors appear in the JS console

Tests

Turn on a screen reader (e.g. VoiceOver or TalkBack).
Go to Settings → Profile.
Confirm the “Profile” title and section titles (“Public”, “Private”) are announced as headings.

Open the sign-in page with a screen reader on.
Use heading navigation (e.g. H in JAWS/NVDA, or Rotor in VoiceOver).
Confirm the hero text (“Travel and expense, at the speed of chat”) and footer column titles (Features, Resources, etc.) are announced as headings.

Open Settings → Profile, Security, Preferences, and Subscription.
Confirm page titles and section titles still look correct.
Confirm there are no layout or styling regressions.

Offline tests

same as tests.

QA Steps

same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-03.at.4.18.14.AM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-02-03.at.3.23.00.AM.mov

Screen.Recording.2026-02-03.at.3.20.53.AM.mov

Screen.Recording.2026-02-03.at.3.27.45.AM.mov

iOS: mWeb Safari

Screen.Recording.2026-02-03.at.3.43.03.AM.mov

Screen.Recording.2026-02-03.at.3.42.38.AM.mov

Screen.Recording.2026-02-03.at.3.43.31.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-30.at.2.45.04.AM.mov

Screen.Recording.2026-01-30.at.2.45.23.AM.mov

Screen.Recording.2026-01-30.at.2.46.25.AM.mov

…t commit

codecov · 2026-01-26T21:02:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/CollapsibleSection/index.tsx	`0.00% <ø> (ø)`
src/components/EmptyStateComponent/index.tsx	`71.42% <100.00%> (+1.05%)`	⬆️
src/components/Header.tsx	`100.00% <ø> (ø)`
src/components/MenuItem.tsx	`88.29% <ø> (ø)`
...c/components/Navigation/NavigationTabBar/index.tsx	`52.53% <ø> (ø)`
src/components/Navigation/TopBar.tsx	`100.00% <ø> (ø)`
src/components/Section/index.tsx	`92.00% <100.00%> (+0.33%)`	⬆️
...omponents/SelectionList/ListItem/SplitListItem.tsx	`0.00% <ø> (ø)`
...components/SelectionList/components/ListHeader.tsx	`90.00% <ø> (ø)`
... and 33 more
... and 17 files with indirect coverage changes

…to 79241

melvin-bot · 2026-01-29T21:54:56Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx

jjcoffee · 2026-02-02T15:21:27Z

@abbasifaizan70 Please add screenshots for all devices. For iOS simulator I used Xcode > Open Developer Tool > Accessibility Inspector., and for Android followed these steps:

Go to Settings > Accessibility > TalkBack and enable it.
Go to TalkBack Settings > Advanced Settings > Developer Settings.
Enable Display speech output.

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

jjcoffee · 2026-02-02T15:26:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2026-02-17_16.30.37.mp4

Android: mWeb Chrome

android-app-2026-02-17_16.30.37.mp4

iOS: HybridApp

ios-app-2026-02-17_15.03.55.mp4

iOS: mWeb Safari

ios-safari-2026-02-17_15.06.00.mp4

MacOS: Chrome / Safari

desktop-chrome-2026-02-17_14.21.14.mp4

desktop-chrome-2026-02-17_14.22.44.mp4

…nto 79241

abbasifaizan70 · 2026-02-02T23:23:36Z

@jjcoffee Updated PR videos and also solved feedbacks. Thanks

src/components/CollapsibleSection/index.tsx

jjcoffee · 2026-02-03T15:29:13Z

Confirm the hero text (“Travel and expense, at the speed of chat”) and footer column titles (Features, Resources, etc.) are announced as headings.

@abbasifaizan70 I don't believe this test passes - I can't see the Travel and expense, at the speed of chat heading on your video.

jjcoffee · 2026-02-03T15:36:58Z

@abbasifaizan70 Please can you methodically test against each of the occurrences in the linked issues (including the "other occurrences" listed there). I'm seeing many that have not been added, for example for onboarding, What's your work email and What's your name screens don't have a heading.

abbasifaizan70 · 2026-02-03T15:46:09Z

@abbasifaizan70 Please can you methodically test against each of the occurrences in the linked issues (including the "other occurrences" listed there). I'm seeing many that have not been added, for example for onboarding, What's your work email and What's your name screens don't have a heading.

@jjcoffee, just for confirmation, asking that I need to test all headings mentioned in the link issues of the parent issue?

abbasifaizan70 · 2026-02-17T11:28:04Z

@jjcoffee Soft remainder to take a look here. Thanks

jjcoffee

Waiting for this to be resolved.

jjcoffee · 2026-02-18T10:08:29Z

@abbasifaizan70 Thanks! Can you also merge main to see if it fixes the lint failure?

abbasifaizan70 · 2026-02-18T10:38:43Z

@jjcoffee PR is ready.

jjcoffee

LGTM!

neil-marcellini

Thanks for this, it looks pretty good. I think we need to use a constant for the header rule. And then also, I don't think a lot of these components should really be considered headers.

src/components/Navigation/TopBar.tsx

src/components/MenuItem.tsx

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx

neil-marcellini · 2026-02-18T19:01:23Z

(Neil's AI agent) Non-blocking note for future reference:

The PR uses accessibilityRole="header" throughout, which is correct for React Native. Just worth noting the terminology distinction for anyone reading:

React Native: accessibilityRole="header" is the correct value. It maps to UIAccessibilityTraitHeader on iOS and the heading flag on Android.
Web ARIA: The equivalent role is role="heading" (not "header"). There is no ARIA role called "header" — the HTML <header> element maps to the banner landmark role, which is a completely different semantic.
React Native Web bridges this: accessibilityRole="header" gets mapped to role="heading" on the web.

So the naming is a React Native convention (following iOS's UIAccessibilityTraitHeader), and it's applied correctly here. No action needed.

neil-marcellini

One more thing

src/components/CollapsibleSection/index.tsx

neil-marcellini

cool thanks

OSBotify · 2026-02-18T20:09:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-18T20:29:05Z

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-18T20:56:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80538.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-14b786d-3498e81-527decd614d880ec6d265a3ef2a086c6fbf3cfa8/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://80538.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T22:20:07Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:20:57Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:35:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

fix: add accessibilityRole header to visual headings for screen readers

a3b4b81

melvin-bot bot assigned abbasifaizan70 Jan 26, 2026

abbasifaizan70 added 2 commits January 27, 2026 01:50

Reverted the changes to IOURequestStepDistanceManual.tsx from the las…

5df9b8f

…t commit

fixed prettier issues

31c48b5

abbasifaizan70 and others added 2 commits January 30, 2026 02:07

Merge branch 'Expensify:main' into 79241

a136a43

Merge branch 'main' of https://github.com/abbasifaizan70/Expensify in…

f9293a6

…to 79241

abbasifaizan70 marked this pull request as ready for review January 29, 2026 21:54

abbasifaizan70 requested review from a team as code owners January 29, 2026 21:54

melvin-bot bot requested review from jjcoffee and trjExpensify and removed request for a team and trjExpensify January 29, 2026 21:54

abbasifaizan70 mentioned this pull request Jan 29, 2026

[$250][Accessibility][Tracking] Add Header Role #79241

Closed

github-actions bot reviewed Jan 29, 2026

View reviewed changes

src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx Outdated Show resolved Hide resolved

jjcoffee reviewed Feb 2, 2026

View reviewed changes

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx Outdated Show resolved Hide resolved

abbasifaizan70 and others added 4 commits February 2, 2026 21:57

Fixed feedbacks

a1f74fb

Merge branch '79241' of https://github.com/abbasifaizan70/Expensify i…

47251df

…nto 79241

Fixed lint issues

6bb6c18

Merge branch 'Expensify:main' into 79241

107f333

jjcoffee reviewed Feb 3, 2026

View reviewed changes

src/components/CollapsibleSection/index.tsx Outdated Show resolved Hide resolved

abbasifaizan70 added 2 commits February 17, 2026 03:00

fixed lint isseus

8a26f7d

Fixed lint issues

8fbdc2b

jjcoffee suggested changes Feb 18, 2026

View reviewed changes

fixed sentryLabel issues

be75958

abbasifaizan70 and others added 3 commits February 18, 2026 15:13

Merge branch 'Expensify:main' into 79241

117930c

Fixed lint issues

542185f

fixed prettier issue

2284c26

jjcoffee approved these changes Feb 18, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini February 18, 2026 10:50

neil-marcellini requested changes Feb 18, 2026

View reviewed changes

src/components/Navigation/TopBar.tsx Outdated Show resolved Hide resolved

src/components/MenuItem.tsx Outdated Show resolved Hide resolved

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx Outdated Show resolved Hide resolved

abbasifaizan70 and others added 2 commits February 18, 2026 23:41

Merge branch 'main' into 79241

6943267

Fixed feedbacks

2e7a96a

neil-marcellini requested changes Feb 18, 2026

View reviewed changes

src/components/CollapsibleSection/index.tsx Outdated Show resolved Hide resolved

abbasifaizan70 and others added 3 commits February 19, 2026 00:16

updated header text with CONST

1c57e8c

Merge branch 'Expensify:main' into 79241

e84eab4

fixed eslint issue

9b0d4f6

neil-marcellini approved these changes Feb 18, 2026

View reviewed changes

neil-marcellini merged commit 14b786d into Expensify:main Feb 18, 2026
29 checks passed

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

mountiny mentioned this pull request Feb 19, 2026

[$250] A11y - Android - The color code also announces when navigating to the header text #80337

Open

7 tasks

Conversation

abbasifaizan70 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 26, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 29, 2026

Uh oh!

Uh oh!

jjcoffee commented Feb 2, 2026

Uh oh!

Uh oh!

jjcoffee commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abbasifaizan70 commented Feb 2, 2026

Uh oh!

Uh oh!

jjcoffee commented Feb 3, 2026

Uh oh!

jjcoffee commented Feb 3, 2026

Uh oh!

abbasifaizan70 commented Feb 3, 2026

Uh oh!

abbasifaizan70 commented Feb 17, 2026

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Feb 18, 2026

Uh oh!

abbasifaizan70 commented Feb 18, 2026

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neil-marcellini commented Feb 18, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

abbasifaizan70 commented Jan 26, 2026 •

edited

Loading

codecov bot commented Jan 26, 2026 •

edited by github-actions bot

Loading

jjcoffee commented Feb 2, 2026 •

edited

Loading