[No QA] Delete docs/articles/new-expensify/reports-and-expenses/Split-Persona…#80563
[No QA] Delete docs/articles/new-expensify/reports-and-expenses/Split-Persona…#80563stephanieelliott merged 4 commits intomainfrom
Conversation
…l-Expenses.md Deleting this article since it's captured in Create an Expense.
HelpDot Documentation ReviewOverall AssessmentThis PR removes a standalone article on splitting personal expenses (Split-Personal-Expenses.md) as the content has been successfully consolidated into the main "Create an Expense" article. This is a positive documentation maintenance action that reduces redundancy and improves content discoverability. Scores Summary
Key FindingsPositive Aspects:
Minor Observations:
RecommendationsFor this PR:
Future Considerations:
Files Reviewed
Overall Recommendation: ✅ Approve - This is good documentation housekeeping that improves content organization without losing functionality or clarity. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad288ed89b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --- | ||
| title: Split Personal Expenses | ||
| description: Learn how to split an expense with others in New Expensify, including how to initiate a chat before making a request. | ||
| keywords: [split expense, shared cost, request payment, Expensify Wallet, start chat, New Expensify] | ||
| --- |
There was a problem hiding this comment.
Update redirect target after deleting article
Deleting this article leaves an existing redirect pointing at a now-missing page: docs/redirects.csv still maps .../Split-Expenses to .../Split-Personal-Expenses (line 870). After this removal, any traffic to the old Split-Expenses URL will redirect to a 404 unless the redirect target is updated (e.g., to Create-an-Expense) or removed.
Useful? React with 👍 / 👎.
Adding redirect for Personal Expense Split since I'm removing the help page. #80563
|
Hey @garrettmknight we need to create a redirect for this article. If someone were to visit https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense#split-personal-expenses after this is deleted, where should they be directed to? |
|
Redirect is already merged! #80573 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Merging main to resolve help doc build error
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@hoangzinh @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
I fixed the failing test, adding @lydiabarclay as an add'l reviewer since I am the last pusher so can't merge myself |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
…l-Expenses.md
Deleting this article since it's captured in Create an Expense.
Explanation of Change
Fixed Issues
$https://github.com/Expensify/Expensify/issues/491348
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari