Skip to content

[No QA] Rename getInputIDPropTypes to validateInputIDProps#8069

Merged
tgolen merged 1 commit intoExpensify:mainfrom
rushatgabhane:rename-getInputIDPropTypes
Mar 10, 2022
Merged

[No QA] Rename getInputIDPropTypes to validateInputIDProps#8069
tgolen merged 1 commit intoExpensify:mainfrom
rushatgabhane:rename-getInputIDPropTypes

Conversation

@rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Mar 10, 2022 •
edited
Loading

cc: @tgolen (It's 3 AM for @thesahindia so I'm creating this PR)

Details

⚠️ Urgent ⚠️

PR #7750 by @thesahindia , used FormUtils.getInputIDPropTypes() but it was renamed to FormUtils.validateInputIDProps() in this commit 78c468d

Apoligies for the oversight.

Fixed Issues

$ #7531

Tests

  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  • Verify that no errors appear in the JS console

Screenshots

NA

@rushatgabhane rushatgabhane requested a review from a team as a code owner March 10, 2022 21:47
@MelvinBot MelvinBot requested review from tgolen and removed request for a team March 10, 2022 21:47
@tgolen tgolen merged commit 9512618 into Expensify:main Mar 10, 2022
@rushatgabhane
Copy link
Member Author

rushatgabhane commented Mar 10, 2022

Phew, disaster averted 😅

@rushatgabhane rushatgabhane deleted the rename-getInputIDPropTypes branch March 10, 2022 22:41
@OSBotify
Copy link
Contributor

OSBotify commented Mar 10, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 10, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Mar 11, 2022

🚀 Deployed to staging by @tgolen in version: 1.1.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Mar 15, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Mar 15, 2022

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Apr 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgolen tgolen tgolen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rushatgabhane @OSBotify @tgolen