Perf: Split WideRHPContext into State and Actions by staszekscp · Pull Request #80726 · Expensify/App

staszekscp · 2026-01-28T10:09:38Z

Explanation of Change

This PR spilts WideRHPContext into State and Actions. It improves the opening time of the Wide RHP by ~12% (867.39 -> 772.73).

It's a follow-up for this PR: #80487

Fixed Issues

$ #80469
$ #80271
PROPOSAL: N/A

Tests

Go to Reports
Open an expense report on wide layout
Open an expense
Change the amount
Verify that the amount has been changed

Offline tests

QA Steps

Go to Reports
Open an expense report on wide layout
Open an expense
Change the amount
Verify that the amount has been changed

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-28.at.11.06.38.mov

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-01-28.at.10.52.42.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-28.at.09.40.22.mov

melvin-bot · 2026-01-28T10:17:04Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/WideRHPContextProvider/index.tsx

mkhutornyi · 2026-01-28T10:20:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-28.at.3.28.29.pm.mov

Screen.Recording.2026-01-28.at.3.29.41.pm.mov

mkhutornyi · 2026-01-28T10:20:39Z

Please fix conflict

…p-context

codecov · 2026-01-28T10:41:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
src/components/Navigation/TopBar.tsx	`100.00% <ø> (ø)`
src/components/Search/index.tsx	`33.05% <100.00%> (ø)`
...thSections/Search/TransactionGroupListExpanded.tsx	`67.30% <ø> (ø)`
...ionModal/ValidateCodeForm/BaseValidateCodeForm.tsx	`83.33% <ø> (ø)`
...components/WideRHPContextProvider/index.native.tsx	`100.00% <100.00%> (ø)`
...ontextProvider/useShowSuperWideRHPVersion/index.ts	`0.00% <ø> (ø)`
...eRHPContextProvider/useShowWideRHPVersion/index.ts	`0.00% <ø> (ø)`
src/components/WideRHPOverlayWrapper/index.tsx	`0.00% <ø> (ø)`
src/hooks/useResponsiveLayoutOnWideRHP/index.ts	`0.00% <ø> (ø)`
... and 13 more
... and 7 files with indirect coverage changes

staszekscp · 2026-01-28T11:21:10Z

@mkhutornyi Now everything should be fine!

mkhutornyi · 2026-01-28T14:19:21Z

@staszekscp conflicts again

mkhutornyi · 2026-01-28T14:23:03Z

src/components/WideRHPContextProvider/index.tsx

-    const syncRHPKeys = useCallback(() => {
+    const syncRHPKeys = () => {


Please disable lint warning with the reason. Otherwise it will increase max warnings count in the app.

The problem is that in order to disable it I would have to use eslint-disable-next-line react-hooks/exhaustive-deps , which breaks the React Compiler. I readded the useCallback but I believe the warning is not correct.

mkhutornyi · 2026-01-28T14:26:51Z

Go to Reports

Open a report to see WideRHP

There must be a step to verify something in Tests / QA Steps

chatgpt-codex-connector · 2026-01-28T14:54:20Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…p-context

chatgpt-codex-connector · 2026-01-28T15:58:12Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny

Thank you, looks great!

OSBotify · 2026-01-28T23:23:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:23:42Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Split WideRHPContext into State and Actions

52fbb23

melvin-bot bot assigned staszekscp Jan 28, 2026

staszekscp marked this pull request as ready for review January 28, 2026 10:16

staszekscp requested review from a team as code owners January 28, 2026 10:16

melvin-bot bot requested review from JmillsExpensify and mkhutornyi and removed request for a team January 28, 2026 10:17

melvin-bot bot removed the request for review from a team January 28, 2026 10:17

github-actions bot reviewed Jan 28, 2026

View reviewed changes

src/components/WideRHPContextProvider/index.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 28, 2026

View reviewed changes

src/components/WideRHPContextProvider/index.tsx Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into perf/refactor-wide-rh…

5422778

…p-context

staszekscp added 3 commits January 28, 2026 11:42

Remove unnecessary useContext import after merge

00090c2

Remove manual memoization in WideRHPContextProvider

c62a6b7

Remove useContext import from BaseValidateCodeForm

03715ac

mkhutornyi reviewed Jan 28, 2026

View reviewed changes

staszekscp added 2 commits January 28, 2026 16:41

Readd manual useCallback to WideRHPContext to get rid of a warning

6114859

Merge remote-tracking branch 'origin/main' into perf/refactor-wide-rh…

a8c4afb

…p-context

mkhutornyi approved these changes Jan 28, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 28, 2026 15:55

mountiny approved these changes Jan 28, 2026

View reviewed changes

mountiny merged commit c01a22f into Expensify:main Jan 28, 2026
31 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

LukasMod mentioned this pull request Jan 29, 2026

[Metrics] Improve Open Report Performance #77173

Open

OSBotify mentioned this pull request Feb 6, 2026

Report - Both expenses disappear after keeping one duplicate. #81628

Closed

7 tasks

kacper-mikolajczak mentioned this pull request Feb 16, 2026

[AI Reviewer] Rule improvement: PERF-6 #82526

Closed

		const syncRHPKeys = useCallback(() => {
		const syncRHPKeys = () => {

Conversation

staszekscp commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

mkhutornyi commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

staszekscp commented Jan 28, 2026

Uh oh!

mkhutornyi commented Jan 28, 2026

Uh oh!

mkhutornyi Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staszekscp Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 28, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

staszekscp commented Jan 28, 2026 •

edited

Loading

mkhutornyi commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

mkhutornyi Jan 28, 2026 •

edited

Loading