Fix that user couldn't open controls on android#80728
Fix that user couldn't open controls on android#80728mountiny merged 3 commits intoExpensify:mainfrom
Conversation
|
I couldn't have reproduced the 'can't open controls' part on main, but after the video is played to the end, I can't replay it, the 'play' button is still unresponsive |
…eater than or equal to duration
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
mountiny
left a comment
There was a problem hiding this comment.
@ZhenjaHorbach can you review please?
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
trjExpensify
left a comment
There was a problem hiding this comment.
Gotta' be able to hit play! 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreenrecorder-2026-01-29-12-19-57-271.mp4Android: mWeb ChromeScreenrecorder-2026-01-29-12-17-38-585.mp4iOS: HybridApp2026-01-29.12.07.50.moviOS: mWeb Safari2026-01-29.12.10.21.movMacOS: Chrome / Safari2026-01-29.11.52.00.mov |
|
LGTM! |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-16 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Explanation of Change
Fixed Issues
$ #80678
PROPOSAL: N/A
Tests
1:
2:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
screen-20260128-135554-1769604936198.mp4
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2026-01-28.at.14.03.31.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-28.at.14.02.07.mov
MacOS: Desktop