fix: Enjoying Expensify popup for new user is not translated by daledah · Pull Request #80756 · Expensify/App

daledah · 2026-01-28T17:13:35Z

Explanation of Change

Fixed Issues

$ #79635
PROPOSAL: #79635 (comment)

Tests

Precond: Users device is set to Spanish and the user is on a new never used account

Access www.staging.new.expensify.com
Create a WS
Go to Reports > Reports > Create an empty Report and click on it
Add an Expense to the report then go back to the main report page
Select the report and "Submit" it (You will see a popup)
Verify that: the "How are you liking Expensify" popup is shown in Spanish

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-28T17:13:42Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-01-29T09:09:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ProactiveAppReviewModal.tsx	`100.00% <100.00%> (ø)`
... and 135 files with indirect coverage changes

melvin-bot · 2026-01-29T09:13:48Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2026-02-02T06:10:31Z

@daledah, could you please mention the Slack thread in which we confirmed the translations?
Also, please take a look at this comment #79635 (comment).

daledah · 2026-02-03T17:48:04Z

@jayeshmangwani asking here

Also, please take a look at this comment #79635 (comment).

With automatic messages from the Concierge, I think it would be fine to keep them in English because there are many such cases.

jayeshmangwani · 2026-02-05T12:29:31Z

@daledah, we have some updates regarding the translations. Would you please update them?

daledah · 2026-02-09T04:22:37Z

@jayeshmangwani i updated

jayeshmangwani · 2026-02-11T13:02:45Z

@daledah , could you please check these two usages? The text is hardcoded, so we may need to update the translations as well.

App/src/components/ProactiveAppReviewModalManager.tsx

Lines 10 to 11 in b012759

    
           const CONCIERGE_POSITIVE_MESSAGE = "Hi there! I'm glad to hear you're enjoying Expensify. What's your favorite thing about the app? Thanks!"; 
        
           const CONCIERGE_NEGATIVE_MESSAGE = "Hi there! I'm sorry to hear you aren't fully satisfied with Expensify. What's your #1 frustration? Thanks!";

daledah · 2026-02-11T16:26:15Z

@daledah , could you please check these two usages? The text is hardcoded, so we may need to update the translations as well.

@jayeshmangwani these are use for automatic messages from the Concierge. So I think we should leave it in English.

App/src/components/ProactiveAppReviewModalManager.tsx

Lines 17 to 30 in 9edca4b

    
           const handleResponse = useCallback( 
        
               (response: AppReviewResponse, message?: string) => { 
        
                   // Call the action which will create an optimistic comment (if the message is provided) and call the API 
        
                   respondToProactiveAppReview(response, proactiveAppReview, message, conciergeReportID); 
        
               }, 
        
               [conciergeReportID, proactiveAppReview], 
        
           ); 
        
           const handlePositive = useCallback(() => { 
        
               handleResponse('positive', CONCIERGE_POSITIVE_MESSAGE); 
        
               // Trigger native app store review prompt 
        
               requestStoreReview(); 
        
           }, [handleResponse]);

App/src/libs/actions/User.ts

Lines 1549 to 1559 in 9edca4b

    
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.REPORT}${conciergeChatReportID}`, 
        
                   value: { 
        
                       lastVisibleActionCreated: optimisticReportAction.reportAction.created, 
        
                       lastMessageText: message, 
        
                       lastActorAccountID: conciergeAccountID, 
        
                       lastReadTime: currentTime, 
        
                   }, 
        
               }, 
        
           );

jayeshmangwani · 2026-02-13T11:57:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

jayeshmangwani

LGTM 🚀

github-actions · 2026-02-23T09:08:26Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-23T09:10:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-23T09:11:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80756.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4c3e83e-08338eb-dcfabce0c3332c6a8d570fd85d35a211b2ffac88/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4c3e83e-08338eb-67ab6d4dd02b5bf2e1035bea9eddce420de8fb0b/index.html

Web 🕸️
https://80756.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-24T01:16:52Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-25T15:50:42Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Enjoying Expensify popup for new user is not translated

3e5aea4

melvin-bot bot assigned daledah Jan 28, 2026

resolve conflict

c54ee34

daledah marked this pull request as ready for review January 29, 2026 09:13

daledah requested review from a team as code owners January 29, 2026 09:13

melvin-bot bot requested review from heyjennahay and jayeshmangwani and removed request for a team January 29, 2026 09:13

melvin-bot bot removed the request for review from a team January 29, 2026 09:13

resolve conflict

0cba5bb

resolve conflict and change the es translation

d303d07

Merge branch 'main' into fix/79635

58c5d8c

jayeshmangwani approved these changes Feb 13, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski February 13, 2026 15:44

mjasikowski approved these changes Feb 23, 2026

View reviewed changes

mjasikowski merged commit 4c3e83e into Expensify:main Feb 23, 2026
31 checks passed

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

melvin-bot bot mentioned this pull request Feb 25, 2026

[Awaiting checklist] [Due for payment 2026-03-04] [$250] "Enjoying Expensify" popup for new user is not translated, displays in English #79635

Closed

7 tasks

Conversation

daledah commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 29, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 29, 2026

Uh oh!

jayeshmangwani commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Feb 3, 2026

Uh oh!

jayeshmangwani commented Feb 5, 2026

Uh oh!

daledah commented Feb 9, 2026

Uh oh!

jayeshmangwani commented Feb 11, 2026

Uh oh!

daledah commented Feb 11, 2026

Uh oh!

jayeshmangwani commented Feb 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

OSBotify commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 29, 2026 •

edited by github-actions bot

Loading

jayeshmangwani commented Feb 2, 2026 •

edited

Loading