Skip to content

Update statement URLS#8078

Merged
nickmurray47 merged 1 commit intomainfrom
jack-updateURL
Mar 11, 2022
Merged

Update statement URLS#8078
nickmurray47 merged 1 commit intomainfrom
jack-updateURL

Conversation

@thienlnam
Copy link
Contributor

@thienlnam thienlnam commented Mar 11, 2022

Details

Fixed Issues

URL configs have been updated, these are still on the old ones and need to be updated
Statements cannot be viewed currently

Tests

  • Verify that no errors appear in the JS console

PR Review Checklist

  1. Go to new.expensify.com/statements/202201
  2. Make sure the statement shows up and you see more than a blank screen

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Will need to be testing on production with

Screenshots

Web

Screen Shot 2022-03-10 at 4 45 02 PM

Mobile Web

Desktop

iOS

Android

@thienlnam thienlnam requested a review from a team as a code owner March 11, 2022 00:44
@MelvinBot MelvinBot requested review from neil-marcellini and removed request for a team March 11, 2022 00:44
@thienlnam thienlnam self-assigned this Mar 11, 2022
@thienlnam
Copy link
Contributor Author

Leaving out all platform SC since we're only doing a URL change here. The old constant does not exist

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@thienlnam thienlnam requested a review from nickmurray47 March 11, 2022 00:53
@nickmurray47
Copy link
Contributor

Going to merge so we can get this fixed!

@nickmurray47 nickmurray47 merged commit 1483218 into main Mar 11, 2022
@nickmurray47 nickmurray47 deleted the jack-updateURL branch March 11, 2022 01:23
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.1.42-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@thienlnam Can I checkmark this as steps seem to refer to PROD QA?

@thienlnam
Copy link
Contributor Author

Yup, this is good to check off @mvtglobally

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants