[CP Staging] Revert "Add support for groupBy week in Search"#80824
Merged
[CP Staging] Revert "Add support for groupBy week in Search"#80824
Conversation
melvin-bot
bot
requested review from
heyjennahay and
mollfpr
and removed request for
a team
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 37cc5389..ab62093e 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7000,7 +7000,7 @@ Fordere Spesendetails wie Belege und Beschreibungen an, lege Limits und Standard
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Auszahlungs-ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Kategorie',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Händler',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Stichwort',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Monat',
},
feed: 'Feed',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 1001b7ec..9410412b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7011,7 +7011,7 @@ Exigez des informations de dépense comme les reçus et les descriptions, défin
[CONST.SEARCH.GROUP_BY.CARD]: 'Carte',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de retrait',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Catégorie',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Commerçant',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Marchand',
[CONST.SEARCH.GROUP_BY.TAG]: 'Étiquette',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mois',
},
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 2c9602fd..566d321f 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6988,7 +6988,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
[CONST.SEARCH.GROUP_BY.CARD]: 'Carta',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID prelievo', //_/\__/_/ \_,_/\__/\__/\_,_/
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Commerciante',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Esercente',
[CONST.SEARCH.GROUP_BY.TAG]: 'Etichetta',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mese',
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e6e27d11..aea16b0b 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6924,7 +6924,7 @@ ${reportName}
reimbursable: '精算対象',
purchaseCurrency: '購入通貨',
groupBy: {
- [CONST.SEARCH.GROUP_BY.FROM]: '送信者',
+ [CONST.SEARCH.GROUP_BY.FROM]: '差出人',
[CONST.SEARCH.GROUP_BY.CARD]: 'カード',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'カテゴリー',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 36fed3dc..f69c02f7 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6971,7 +6971,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
[CONST.SEARCH.GROUP_BY.CARD]: 'Kaart',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Opname-ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categorie',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Verkoper',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Handelaar',
[CONST.SEARCH.GROUP_BY.TAG]: 'Label',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Maand',
},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index bf491b03..c0493111 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6961,7 +6961,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID wypłaty',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Kategoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Sprzedawca',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Etykieta',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Miesiąc',
},
feed: 'Kanał',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 3af89a7d..434aa3b5 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6959,7 +6959,7 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'De',
[CONST.SEARCH.GROUP_BY.CARD]: 'Cartão',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID da retirada',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de Saque',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Comerciante',
[CONST.SEARCH.GROUP_BY.TAG]: 'Etiqueta',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ecdb4078..d9d0b8d0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6805,12 +6805,12 @@ ${reportName}
purchaseCurrency: '购买货币',
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: '来自',
- [CONST.SEARCH.GROUP_BY.CARD]: '卡片',
+ [CONST.SEARCH.GROUP_BY.CARD]: '卡',
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现 ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: '类别',
[CONST.SEARCH.GROUP_BY.MERCHANT]: '商家',
[CONST.SEARCH.GROUP_BY.TAG]: '标签',
- [CONST.SEARCH.GROUP_BY.MONTH]: '月',
+ [CONST.SEARCH.GROUP_BY.MONTH]: '月份',
},
feed: '动态',
withdrawalType: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
7 tasks
Contributor
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
mollfpr
approved these changes
Jan 29, 2026
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
|
@mollfpr were you able to confirm that this revert fixed the issue? |
Contributor
|
@puneetlath Checking 👀 |
Contributor
|
@puneetlath The revert removes the week option in the groupBy. So I guess it's fixed. |
7 tasks
cristipaval
changed the title
OSBotify
pushed a commit
that referenced
this pull request
Jan 29, 2026
…groupByWeek Revert "Add support for groupBy week in Search" (cherry picked from commit 40f2c56) (cherry-picked to staging by puneetlath)
51 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.11-4 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.11-10 🚀
|
55 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.11-16 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #80684