Fix: Hide Concierge help button on every Search RHP by ryntgh · Pull Request #80994 · Expensify/App

ryntgh · 2026-01-30T09:51:54Z

Explanation of Change

This PR sets the default value of shouldDisplayHelpButton to false and explicitly sets it to true only for central pane components to hide the Concierge help button on RHP. This PR also adds a TopBar component to the Account page on the mobile layout (InitialSettingsPage) and swaps the positions of the search button and the Concierge help button

Fixed Issues

$ #80956
PROPOSAL: #80956 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Navigate to Reports
Open Columns
Verify that Concierge does not appear in the RHP
Open Advanced Filters and check all filters
Verify that Concierge does not appear in the RHP
Navigate to Account
Verify that the Concierge button appears for the central pane
Verify that the TopBar with the text "Account" is displayed at the top for mobile view
Verify that the Concierge button is positioned to the right of the search button

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-App.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-App.mp4

iOS: mWeb Safari

iOS-mWeb.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

codecov · 2026-01-30T10:05:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/HeaderWithBackButton/index.tsx	`91.56% <100.00%> (ø)`
src/components/Navigation/TopBar.tsx	`100.00% <100.00%> (ø)`
src/pages/Search/SearchPageNarrow.tsx	`82.35% <ø> (ø)`
src/pages/TeachersUnite/SaveTheWorldPage.tsx	`0.00% <ø> (ø)`
src/pages/home/HomePage.tsx	`100.00% <ø> (ø)`
src/pages/inbox/HeaderView.tsx	`86.48% <100.00%> (+1.35%)`	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	`56.30% <ø> (ø)`
src/pages/settings/AboutPage/AboutPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Preferences/PreferencesPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Profile/ProfilePage.tsx	`90.90% <ø> (ø)`
... and 20 more
... and 14 files with indirect coverage changes

melvin-bot · 2026-01-30T11:12:56Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a105211d5e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-30T11:23:02Z

src/pages/Search/SearchAdvancedFiltersPage.tsx

+            <HeaderWithBackButton
+                title={translate('search.filtersHeader')}
+                shouldDisplayHelpButton={false}


Make help button conditional on RHP layout

This forces shouldDisplayHelpButton={false} for the advanced filters header, which removes the Concierge button even when this screen is full‑page on narrow layouts. SearchFiltersBar (used in SearchPageNarrow) navigates to ROUTES.SEARCH_ADVANCED_FILTERS via openAdvancedFilters in src/components/Search/SearchPageHeader/SearchFiltersBar.tsx, so this page is not RHP‑only. If the requirement is to hide the button only in the RHP, this unconditional prop will regress help access on mobile; consider gating it on an “is in RHP / shouldUseNarrowLayout” check instead.

Useful? React with 👍 / 👎.

I think we want to hide the Concierge button on these Search screens in all contexts (wide and narrow layout)

@JmillsExpensify Curious to know of cases where RHP screen takes full-page on narrow layouts.
Should we show or not show the help button here in such cases?

80994-query-001.mp4

Confirmed here that even when RHP screen takes full-page on narrow layouts, we should not show the Concierge or Help button.
So, let us ignore codex review comments.

rojiphil · 2026-02-02T07:16:32Z

@ryntgh We also have RHP under Workspaces and Account settings where the help button needs to be hidden.

80994-web-chrome-i_001.mp4

JmillsExpensify

I reported this one, so also agree with the product changes here.

rojiphil · 2026-02-02T17:01:49Z

Only this comment is pending to be addressed.

ryntgh · 2026-02-03T15:30:46Z

@rojiphil Do we need to address RHP under Workspaces and Account settings as well? If so, I think this would require a lot of changes. Moreover, there are now new ESLint rules regarding sentryLabel, so I think it would affect a lot of files if we do this 😅

rojiphil · 2026-02-04T16:48:18Z

Do we need to address RHP under Workspaces and Account settings as well? If so, I think this would require a lot of changes. Moreover, there are now new ESLint rules regarding sentryLabel, so I think it would affect a lot of files if we do this 😅

@ryntgh Yeah... That would be lot of changes as there are quite a lot of RHP components.
But I am curious if we can default shouldDisplayHelpButton to false and only explicitly set it to true for central pane components. Wouldn’t that be much simpler here?

ryntgh · 2026-02-09T01:23:07Z

Yeah... That would be lot of changes as there are quite a lot of RHP components. But I am curious if we can default shouldDisplayHelpButton to false and only explicitly set it to true for central pane components. Wouldn’t that be much simpler here?

Agreed, I think we can do it that way. I’ll update the PR soon

ryntgh · 2026-02-09T03:21:22Z

@rojiphil I've updated the PR, could you please review it again?

JmillsExpensify

Still looks good to me.

rojiphil · 2026-02-14T00:39:29Z

For narrow layout versions (mobile), Accounts and Reports page does not show concierge. The wide layout versions shows Concierge which is correct since they are main pages.

80994-issue-001.mp4

rojiphil · 2026-02-14T00:46:18Z

Also on narrow window versions, opening individual expense report in RHP keeps showing Concierge. Since it is on RHP, we need to hide it.

80994-issue-002.mp4

rojiphil · 2026-02-14T00:49:43Z

@ryntgh Just left few comments for you. Also, there are conflicts. Please have a look. Thanks

dubielzyk-expensify · 2026-02-23T23:44:54Z

Let's see if anyone else has any strong opinions/rationale for the placement. cc @Expensify/design @JmillsExpensify

Agree. Would be good to get a test build when it's ready so we can test further

JmillsExpensify · 2026-02-24T10:11:52Z

I also don't feel super strongly, so I slightly prefer search being placed to the left of Concierge.

shawnborton · 2026-02-24T10:18:12Z

Yeah, I think I agree with that.

shawnborton · 2026-02-24T10:18:40Z

@ryntgh let's swap the locations of those two and then we can run a test build.

ryntgh · 2026-02-24T12:46:51Z

let's swap the locations of those two and then we can run a test build.

Sure, PR updated 👍
Here’s how it currently looks on desktop and mobile web

Desktop-.-Mobile-Web.mp4

dannymcclain · 2026-02-24T13:00:59Z

Oh yeah I like that placement better. Good call gents!

JmillsExpensify · 2026-02-24T13:16:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

80994-android-hybrid-001.mp4

Android: mWeb Chrome

80994-mweb-chrome-002.mp4

iOS: HybridApp

80994-ios-hybrid-001.mp4

iOS: mWeb Safari

80994-mweb-safari-002.mp4

80994-mweb-safari-003.mp4

MacOS: Chrome / Safari

80994-web-chrome-003.mp4

80994-web-chrome-002.mp4

rojiphil · 2026-02-26T15:32:09Z

@ryntgh Please merge with the latest main as we have conflicts.
Also, please add test steps in PR OP for the change related to the swapping of search and concierge buttons.

ryntgh · 2026-02-26T16:03:23Z

@rojiphil Merged with the latest main and updated the PR description

rojiphil

Thanks @ryntgh for the updates.

@carlosmiceli Changes LGTM and works well too.
All yours. Thanks.

github-actions · 2026-02-27T17:29:46Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-27T17:34:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80994.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e7fa71d-7ab88ad-73660a876eb9e736bcb51e8cd950b81891ee8841/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e7fa71d-7ab88ad-532b33f98d9195d4d66b2597f1153dca0075940e/index.html

Web 🕸️
https://80994.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-27T17:36:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-02T23:01:17Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:16:05Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:06:26Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

shawnborton · 2026-03-13T12:56:00Z

Hmm am I missing something - I thought we were putting the Concierge icon back in the top right of every top-level mobile page? I don't see it in the latest builds. cc @ryntgh @rojiphil can you please confirm? cc @Expensify/design @JmillsExpensify

rojiphil · 2026-03-13T14:04:35Z

I thought we were putting the Concierge icon back in the top right of every top-level mobile page?

Oh! Just checked and noticed that it works for the mobile web versions but not on the native versions.
Unfortunate that this issue slipped through unnoticed.
@ryntgh Can you please have a look at this?

JmillsExpensify · 2026-03-13T14:05:31Z

Yes, let's address it

ryntgh · 2026-03-13T14:24:15Z

I mentioned this in my comment earlier. I thought it was expected based on the original PR 🤔

JmillsExpensify · 2026-03-13T14:26:00Z

Sorry for any confusion. Let's just address it in another PR.

Fix: Hide Concierge help button on every Search RHP

a105211

melvin-bot bot assigned ryntgh Jan 30, 2026

ryntgh marked this pull request as ready for review January 30, 2026 11:12

ryntgh requested review from a team as code owners January 30, 2026 11:12

melvin-bot bot requested review from JmillsExpensify and rojiphil and removed request for a team January 30, 2026 11:12

ryntgh mentioned this pull request Jan 30, 2026

[$250] [Due for payment 2026-03-11] Concierge Appearing in Right-Hand Pane When It Shouldn’t #80956

Closed

7 tasks

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

JmillsExpensify previously approved these changes Feb 2, 2026

View reviewed changes

ryntgh added 2 commits February 9, 2026 09:26

Merge branch 'main' into issue-80956

7f50abf

Revert first commit

2c8083f

ryntgh dismissed JmillsExpensify’s stale review via 2c8083f February 9, 2026 01:38

ryntgh added 3 commits February 9, 2026 09:47

Fix: Hide Concierge help button on RHP

0ccdd4c

Hide help button on submit expense confirmation RHP

5bf080b

ESLint fix

8f3e19f

JmillsExpensify reviewed Feb 13, 2026

View reviewed changes

Merge branch 'main' into issue-80956

57ca08f

Swap SearchButton and SidePanelButton position

25b0315

Merge branch 'main' into issue-80956

664eec2

rojiphil approved these changes Feb 27, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli February 27, 2026 17:18

carlosmiceli approved these changes Feb 27, 2026

View reviewed changes

carlosmiceli merged commit e7fa71d into Expensify:main Feb 27, 2026
31 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

Conversation

ryntgh commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

ryntgh Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rojiphil Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rojiphil Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Feb 2, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Feb 2, 2026

Uh oh!

ryntgh commented Feb 3, 2026

Uh oh!

rojiphil commented Feb 4, 2026

Uh oh!

ryntgh commented Feb 9, 2026

Uh oh!

ryntgh commented Feb 9, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rojiphil commented Feb 14, 2026

Uh oh!

rojiphil commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Feb 23, 2026

Uh oh!

JmillsExpensify commented Feb 24, 2026

Uh oh!

shawnborton commented Feb 24, 2026

Uh oh!

shawnborton commented Feb 24, 2026

Uh oh!

ryntgh commented Feb 24, 2026

Uh oh!

dannymcclain commented Feb 24, 2026

Uh oh!

JmillsExpensify commented Feb 24, 2026

Uh oh!

shawnborton commented Feb 24, 2026

Uh oh!

rojiphil commented Feb 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil commented Feb 26, 2026

ryntgh commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading

rojiphil commented Feb 14, 2026 •

edited

Loading

rojiphil commented Feb 14, 2026 •

edited

Loading