Skip to content

fix: Map is missing green line when splitting distance expense, confirm page is empty #81014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertjchen merged 5 commits into from
Feb 10, 2026
+3 −2
Merged

fix: Map is missing green line when splitting distance expense, confirm page is empty #81014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1911b1
fix: Map is missing green line when splitting distance expense, confi…
nkdengineer Jan 30, 2026
ed2e592
fix lint
nkdengineer Jan 30, 2026
7e32c59
Merge branch 'main' into fix/80714
nkdengineer Feb 2, 2026
82d45fd
Merge branch 'main' into fix/80714
nkdengineer Feb 3, 2026
1c2b0ea
update with main solution
nkdengineer Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useFetchRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {deepEqual} from 'fast-equals';
import {useEffect} from 'react';
import type {OnyxEntry} from 'react-native-onyx';
import {getRoute} from '@libs/actions/Transaction';
import {getValidWaypoints, hasRoute as hasRouteTransactionUtils, isMapDistanceRequest as isMapDistanceRequestTransactionUtils} from '@libs/TransactionUtils';
import {getValidWaypoints, hasRoute as hasRouteTransactionUtils, isDistanceTypeRequest, isMapDistanceRequest as isMapDistanceRequestTransactionUtils} from '@libs/TransactionUtils';
import type {IOUAction} from '@src/CONST';
import CONST from '@src/CONST';
import type {Transaction} from '@src/types/onyx';
Expand All @@ -25,7 +25,7 @@ export default function useFetchRoute(
const validatedWaypoints = getValidWaypoints(waypoints);
const previousValidatedWaypoints = usePrevious(validatedWaypoints);
const haveValidatedWaypointsChanged = !deepEqual(previousValidatedWaypoints, validatedWaypoints);
const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);
const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction) || isDistanceTypeRequest(transaction);
const shouldFetchRoute = isMapDistanceRequest && (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;

useEffect(() => {
Expand Down
1 change: 1 addition & 0 deletions src/libs/TransactionUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
});

let allPolicyTags: OnyxCollection<PolicyTagLists> = {};
Onyx.connect({

Check warning on line 142 in src/libs/TransactionUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.POLICY_TAGS,
waitForCollectionCallback: true,
callback: (value) => {
Expand Down Expand Up @@ -2863,6 +2863,7 @@
shouldShowExpenseBreakdown,
isTimeRequest,
getExpenseTypeTranslationKey,
isDistanceTypeRequest,
};

export type {TransactionChanges};
Loading