fix: code block not displayed for ASCII characters by TaduJR · Pull Request #81018 · Expensify/App

TaduJR · 2026-01-30T15:23:22Z

Explanation of Change

Emoji shortcodes like 😂 were being converted to emoji characters even inside code blocks (:joy:). This fix adds code block awareness to emoji replacement.

Fixed Issues

$ #62710
PROPOSAL: #62710 (comment)

Tests

Navigate to any DM
Type ` to start a code block
Type :joy: (the emoji shortcode)
Verify the shortcode converts to 😂 emoji
Type a space, then ` to close the code block
Verify the emoji reverts to :joy: inside the code block
Verify no emoji suggestion popup appears

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-30.at.6.50.20.in.the.evening.mov

Android: mWeb Chrome

Screen.Recording.2026-01-30.at.6.56.34.in.the.evening.mov

iOS: Native

Screen.Recording.2026-01-30.at.6.41.03.in.the.evening.mov

iOS: mWeb Safari

Screen.Recording.2026-01-30.at.6.41.53.in.the.evening.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-30.at.6.37.53.in.the.evening.mov

melvin-bot · 2026-01-30T15:23:28Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/EmojiUtils.tsx

- Use .at() method for array element access per linting rules - Hoist englishTrie lookup outside loop to avoid O(n) overhead

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: edf095607e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/EmojiUtils.tsx

TaduJR · 2026-01-30T15:29:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33b1c9bb44

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/EmojiUtils.tsx

codecov · 2026-01-30T15:45:09Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/EmojiUtils.tsx	`69.88% <96.55%> (+5.49%)`	⬆️
...box/report/ReportActionCompose/SuggestionEmoji.tsx	`36.04% <0.00%> (-1.76%)`	⬇️
... and 11 files with indirect coverage changes

trjExpensify

👍

ShridharGoel · 2026-02-02T20:37:14Z

Go into another app, copy the text that's in the thread

Can you fix this line in the testing steps by mentioning an example like :joy:? And it can even by typed apart from copy/pasting.

src/libs/EmojiUtils.tsx

ShridharGoel · 2026-02-02T20:45:32Z

src/libs/EmojiUtils.tsx

-        // If the user has selected a language other than English, and the emoji doesn't exist in that language,
-        // we will check if the emoji exists in English.
-        if (normalizedLocale !== CONST.LOCALES.DEFAULT && !checkEmoji?.metaData?.code) {
-            const englishTrie = emojisTrie[CONST.LOCALES.DEFAULT];
-            if (englishTrie) {
-                checkEmoji = englishTrie.search(name);
-            }
+        if (!checkEmoji?.metaData?.code && englishTrie) {
+            checkEmoji = englishTrie.search(name);
        }


Why this change? Is it just to improve the code?

This refactors the englishTrie lookup outside the loop for efficiency - instead of checking normalizedLocale !== CONST.LOCALES.DEFAULT and looking up emojisTrie[CONST.LOCALES.DEFAULT] on every emoji iteration, we now pre-compute it once before the loop. The behavior is identical - if locale is not default and emoji isn't found in the localized trie, try English.

src/libs/EmojiUtils.tsx

…ock-not-displayed-for-ASCII-characters

TaduJR · 2026-02-03T15:21:49Z

Can you fix this line in the testing steps by mentioning an example like 😂? And it can even by typed apart from copy/pasting.

Done.

ShridharGoel · 2026-02-04T20:33:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-02-06.at.10.17.30.PM.mov

iOS: HybridApp

Screen.Recording.2026-02-06.at.10.15.53.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-02-06.at.10.14.46.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-06.at.10.19.06.PM.mov

src/libs/EmojiUtils.tsx

…ock-not-displayed-for-ASCII-characters

github-actions · 2026-02-10T08:54:51Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-10T08:59:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81018.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-54244ec-6536d73a279f9fc278345928ff888984779af98d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-54244ec-9ebe0623aee6fa3fd10b43fc60433b472538183c/index.html

Web 🕸️
https://81018.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-10T09:01:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-11T06:53:46Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-12T15:23:05Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: code block not displayed for ASCII characters

edf0956

TaduJR requested review from a team as code owners January 30, 2026 15:23

melvin-bot bot assigned TaduJR Jan 30, 2026

melvin-bot bot requested review from ShridharGoel and trjExpensify January 30, 2026 15:23

melvin-bot bot removed request for a team January 30, 2026 15:23

github-actions bot reviewed Jan 30, 2026

View reviewed changes

src/libs/EmojiUtils.tsx Show resolved Hide resolved

fix: address lint error and performance optimization

33b1c9b

- Use .at() method for array element access per linting rules - Hoist englishTrie lookup outside loop to avoid O(n) overhead

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

src/libs/EmojiUtils.tsx Show resolved Hide resolved

fix: process code ranges in reverse and address lint feedback

ac441dd

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

src/libs/EmojiUtils.tsx Show resolved Hide resolved

TaduJR added 2 commits January 30, 2026 19:07

refactor: extract getEmojiCodeForInsertion helper for testability

c5ce94e

fix: prevent emoji suggestions inside code blocks on iOS

d7514ae

trjExpensify previously approved these changes Jan 31, 2026

View reviewed changes

ShridharGoel reviewed Feb 2, 2026

View reviewed changes

TaduJR added 2 commits February 3, 2026 18:14

Merge branch 'main' of https://github.com/TaduJR/App into fix-code-bl…

18a91a8

…ock-not-displayed-for-ASCII-characters

fix: address PR review comments on code block emoji handling

535cbca

TaduJR dismissed trjExpensify’s stale review via 535cbca February 3, 2026 15:18

TaduJR requested a review from ShridharGoel February 3, 2026 15:22

ShridharGoel approved these changes Feb 6, 2026

View reviewed changes

melvin-bot bot requested a review from inimaga February 6, 2026 16:51

inimaga requested changes Feb 9, 2026

View reviewed changes

src/libs/EmojiUtils.tsx Outdated Show resolved Hide resolved

TaduJR added 4 commits February 10, 2026 01:19

fix: adjust cursorPosition after reverting emojis in code blocks

806a778

Merge branch 'main' of https://github.com/TaduJR/App into fix-code-bl…

a755b94

…ock-not-displayed-for-ASCII-characters

Merge branch 'main' of https://github.com/TaduJR/App into fix-code-bl…

da73a34

…ock-not-displayed-for-ASCII-characters

fix: TypeScript error in replaceEmojis early return

0cf7a0b

inimaga approved these changes Feb 10, 2026

View reviewed changes

inimaga merged commit 54244ec into Expensify:main Feb 10, 2026
30 checks passed

OSBotify mentioned this pull request Feb 11, 2026

Deploy Checklist: New Expensify 2026-02-11 #82079

Closed

This was referenced Feb 11, 2026

[No payment] Mark down - Message is centered when editing message #82095

Closed

Expense - Back button on Merchant page reopens Merchant page #82121

Closed

melvin-bot bot mentioned this pull request Feb 12, 2026

[Due for payment 2026-02-19] [$250] code block not displayed for ASCII characters #62710

Closed

16 tasks

Conversation

TaduJR commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Feb 2, 2026

Uh oh!

Uh oh!

ShridharGoel Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

TaduJR Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TaduJR commented Feb 3, 2026

Uh oh!

ShridharGoel commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TaduJR commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Feb 4, 2026 •

edited

Loading