fix Expense - Violation message no longer displayed after rotating receipt by aimane-chnaif · Pull Request #81159 · Expensify/App

aimane-chnaif · 2026-02-02T10:29:14Z

Explanation of Change

Keep receiptState when rotate image.
The change in PR keeps minimal so all other cases of replaceReceipt are not affected.

Fixed Issues

$ #78480

Tests

Tap on the global create menu
Select Scan a receipt
Once scanning finished, Edit the amount so it's higher than the scanned account
Verify a violation is displayed indicating the amount is higher than the scanned receipt
Click on the Receipt
Click on the Rotate button to rotate the receipt
Wait for the action to save
Click on the X to close the receipt page
Verify that "Amount greater than scanned receipt" violation still displayed

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

…ceipt

melvin-bot · 2026-02-02T11:18:35Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx

eh2077 · 2026-02-04T15:36:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-02.at.4.53.50.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-02.at.4.52.37.PM.mov

iOS: HybridApp

Screen.Recording.2026-03-02.at.4.55.14.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-02.at.4.53.11.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-02.at.4.50.42.PM.mov

aimane-chnaif · 2026-03-02T03:34:30Z

@eh2077 this is ready for review

eh2077

Works well!

@aimane-chnaif Can you also modify the unit test a bit to cover the change? thx 🙇

aimane-chnaif · 2026-03-02T09:01:21Z

Can you also modify the unit test a bit to cover the change?

@MelvinBot can you please help with that? 😅

- Assert default state is OPEN when no state param is provided - Add new test case verifying state is preserved when explicitly passed (e.g. rotating receipt) Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-03-02T09:04:45Z

Updated the unit tests in tests/actions/IOUTest.ts to cover the state preservation change:

Existing test ("should replace the receipt of the transaction") — added assertions that the receipt state defaults to OPEN (both on the transaction and the snapshot) when no state param is provided.
New test ("should preserve receipt state when state is provided") — sets up a transaction with SCANREADY state, calls replaceReceipt with state: SCAN_READY, and verifies the state is preserved on both the transaction and the snapshot. This covers the rotate receipt scenario from the fix.

tests/actions/IOUTest.ts

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-03-02T09:10:25Z

Added SCANREADY to cspell.json to fix the spellcheck error.

codecov · 2026-03-02T09:20:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`72.48% <100.00%> (+<0.01%)`	⬆️
...alScreen/routes/TransactionReceiptModalContent.tsx	`0.00% <0.00%> (ø)`
... and 29 files with indirect coverage changes

eh2077

Cool!

OSBotify · 2026-03-02T19:21:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T19:57:12Z

🚧 @iwiznia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-02T20:03:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81159.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5c03315-8beecd5-657aef86e7a14e2c19a6fe4e96dbdb636987a865/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5c03315-8beecd5-c4b8a017ffae572d07b4c2a4c2577f5d99e54a77/index.html

Web 🕸️
https://81159.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:01:23Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:16:11Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:06:32Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix Expense - Violation message no longer displayed after rotating re…

c984e4f

…ceipt

melvin-bot bot assigned aimane-chnaif Feb 2, 2026

fix lint

1518747

aimane-chnaif mentioned this pull request Feb 2, 2026

[$250] Expense - Violation message no longer displayed after rotating receipt #78480

Open

7 tasks

aimane-chnaif marked this pull request as ready for review February 2, 2026 11:18

aimane-chnaif requested review from a team as code owners February 2, 2026 11:18

melvin-bot bot requested review from JmillsExpensify and akinwale and removed request for a team and JmillsExpensify February 2, 2026 11:18

melvin-bot bot removed the request for review from a team February 2, 2026 11:18

github-actions bot reviewed Feb 2, 2026

View reviewed changes

src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx Show resolved Hide resolved

aimane-chnaif and others added 3 commits March 1, 2026 21:30

Merge branch 'Expensify:main' into fix-78480

bae2b1b

Merge branch 'Expensify:main' into fix-78480

a13892a

pass isSameReceipt to ReplaceReceipt

00f1605

eh2077 reviewed Mar 2, 2026

View reviewed changes

aimane-chnaif commented Mar 2, 2026

View reviewed changes

tests/actions/IOUTest.ts Show resolved Hide resolved

Add SCANREADY to cspell.json

bf94ebb

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif requested a review from eh2077 March 2, 2026 09:16

eh2077 approved these changes Mar 2, 2026

View reviewed changes

melvin-bot bot requested a review from iwiznia March 2, 2026 09:24

iwiznia approved these changes Mar 2, 2026

View reviewed changes

iwiznia merged commit 5c03315 into Expensify:main Mar 2, 2026
30 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

Conversation

aimane-chnaif commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 2, 2026

Uh oh!

Uh oh!

eh2077 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Mar 2, 2026

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 2, 2026

Uh oh!

MelvinBot commented Mar 2, 2026

Uh oh!

Uh oh!

MelvinBot commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aimane-chnaif commented Feb 2, 2026 •

edited

Loading

eh2077 commented Feb 4, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited by github-actions bot

Loading