[No QA] Revert "Fixed required columns list + Fixed parser for default sortBy and column name parsing"#81183
[No QA] Revert "Fixed required columns list + Fixed parser for default sortBy and column name parsing"#81183cristipaval wants to merge 1 commit intomainfrom
Conversation
… and column name parsing"
melvin-bot
bot
requested review from
madmax330 and
trjExpensify
and removed request for
a team
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 278c43d5ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| groupMonth = "group-month"i &wordBoundary { return "groupMonth"; } | ||
| groupWeek = "group-week"i &wordBoundary { return "groupWeek"; } | ||
| groupYear = "group-year"i &wordBoundary { return "groupYear"; } | ||
| groupQuarter = "group-quarter"i &wordBoundary { return "groupQuarter"; } |
There was a problem hiding this comment.
These rules now return groupMonth/groupWeek/groupYear/groupQuarter, but the canonical column IDs are lowercase (groupmonth/groupweek/groupyear/groupquarter in src/CONST/index.ts:7156-7159). As a result, queries like columns:group-month or sortBy:group-month will parse to values that don’t exist in SearchUIUtils’s column-to-sorting maps, so columns get ignored and group sort falls back to unsorted data. This is a behavioral regression for users who rely on group-* columns or sortBy with month/week/year/quarter.
Useful? React with 👍 / 👎.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
1 participant
Reverts #81127