Skip to content

[CHAI] Release 2 - Make helpsite search centric#81226

Merged
chuckdries merged 60 commits intoExpensify:mainfrom
rushatgabhane:chai-release-2
Feb 10, 2026
Merged

[CHAI] Release 2 - Make helpsite search centric#81226
chuckdries merged 60 commits intoExpensify:mainfrom
rushatgabhane:chai-release-2

Conversation

@rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Feb 2, 2026

Explanation of Change

Lots of file changes because I ran npm run compress-svg

  • Got rid of the right hand search panel
  • Replaced it with /search page
  • Search is made prominent in home page
  • Added skeleton loader for loading results
  • Updated layout of home page

Fixed Issues

https://github.com/Expensify/Expensify/issues/557403
PROPOSAL:

Tests

Test 1: Homepage and Search

  1. Navigate to help.expensify.com
  2. Verify search bar, "Getting Started" and "Topics" cards display in a 3 column layout. Single column for mobile.
  3. Type "expense" in the search bar and press Enter
  4. Verify you land on /search?q=expense, skeleton loaders flash, then results appear

Test 2: LHN Search and Platform Param

  1. Navigate to any Expensify Classic hub page
  2. On desktop, verify a "Search for something..." input appears at the top of the LHN
  3. Type a query and press Enter
  4. Verify you are navigated to /search?q=...&platform=expensify-classic
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web
Screen.Recording.2026-02-03.at.05.31.49.mov
image image image image image image
m-Web

https://github.com/user-attachments/assets/d5ec9d05-efc1-4b75-ac8e-a48b70ca9622
image

@rushatgabhane rushatgabhane marked this pull request as ready for review February 2, 2026 22:32
@rushatgabhane
Copy link
Member Author

@shawnborton 🦅👁️

done!

image image

@shawnborton
Copy link
Contributor

Nice, I dig it - thanks!

@rushatgabhane
Copy link
Member Author

rushatgabhane commented Feb 9, 2026

alright now the only discussion remaining is the back button. should i revert my changes and don't preserve history when going back?

because I'm not too sure why would we want to see the old search results

@dannymcclain
Copy link
Contributor

Yeah I think if they're tied together, let's revert to your previous implementation. I fully agree with Jon and Shawn here:

I dont' disagree that the browser back button should go through the search results, but I don't think the table of contents back button should do it. To me that should navigate the hierarchy. They're separate to me.

But if we're not going to separate their functionalities, I think it's probably better to just go with your initial version. Let's get confirmation from the rest of the @Expensify/design team though!

@shawnborton
Copy link
Contributor

That works for me 👍

chuckdries
chuckdries previously approved these changes Feb 9, 2026
Copy link
Contributor

@chuckdries chuckdries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me!

@rushatgabhane
Copy link
Member Author

@MelvinBot please revert the changes #81226 (comment)

@rushatgabhane
Copy link
Member Author

@MelvinBot specifically this commit - 8f1bab5

and also the changes which search again on going back.

Reverts pushState and popstate listener so the back button
navigates the hierarchy instead of cycling through search results.

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
@MelvinBot
Copy link
Contributor

Reverted the search history navigation changes as requested. Here's what was changed in docs/assets/js/main.js:

  1. history.pushStatehistory.replaceState — search queries no longer push new entries to browser history
  2. Removed window.addEventListener('popstate', initSearchPage) — no longer re-runs search on back/forward navigation

This restores the previous behavior where the back button navigates the hierarchy rather than cycling through search results.

@MelvinBot
Copy link
Contributor

Already done! The revert commit (f8ad12ef14b) has been pushed and covers both:

  1. Commit 8f1bab5 ("push to history") — reverted history.pushState back to history.replaceState
  2. "search again on going back" (6a8248b) — removed window.addEventListener('popstate', initSearchPage)

The back button will now navigate the hierarchy as before, without cycling through search results.

@rushatgabhane
Copy link
Member Author

@MelvinBot fix ts checks please

@MelvinBot
Copy link
Contributor

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/21840303664

@rushatgabhane
Copy link
Member Author

@chuckdries let's send it!

@chuckdries
Copy link
Contributor

@rushatgabhane Hm, failing type checks and unit tests. Try merging main?

@rushatgabhane
Copy link
Member Author

@chuckdries merging main fixed it

Copy link
Contributor

@chuckdries chuckdries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chuckdries chuckdries merged commit 580c98f into Expensify:main Feb 10, 2026
31 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@huult
Copy link
Contributor

huult commented Feb 21, 2026

@chuckdries I’ve reviewed this PR. Could you help create a ticket for payment?

@mallenexpensify
Copy link
Contributor

Gotcha @huult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants