[CHAI] Release 2 - Make helpsite search centric#81226
[CHAI] Release 2 - Make helpsite search centric#81226chuckdries merged 60 commits intoExpensify:mainfrom
Conversation
|
@shawnborton 🦅👁️ done!
|
|
Nice, I dig it - thanks! |
|
alright now the only discussion remaining is the back button. should i revert my changes and don't preserve history when going back? because I'm not too sure why would we want to see the old search results |
|
Yeah I think if they're tied together, let's revert to your previous implementation. I fully agree with Jon and Shawn here:
But if we're not going to separate their functionalities, I think it's probably better to just go with your initial version. Let's get confirmation from the rest of the @Expensify/design team though! |
|
That works for me 👍 |
chuckdries
left a comment
There was a problem hiding this comment.
Code looks great to me!
|
@MelvinBot please revert the changes #81226 (comment) |
|
@MelvinBot specifically this commit - 8f1bab5 and also the changes which search again on going back. |
Reverts pushState and popstate listener so the back button navigates the hierarchy instead of cycling through search results. Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
|
Reverted the search history navigation changes as requested. Here's what was changed in
This restores the previous behavior where the back button navigates the hierarchy rather than cycling through search results. |
|
Already done! The revert commit (
The back button will now navigate the hierarchy as before, without cycling through search results. |
|
@MelvinBot fix ts checks please |
|
I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai. Run details: https://github.com/Expensify/Expensify/actions/runs/21840303664 |
|
@chuckdries let's send it! |
|
@rushatgabhane Hm, failing type checks and unit tests. Try merging main? |
|
@chuckdries merging main fixed it |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.17-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
|
@chuckdries I’ve reviewed this PR. Could you help create a ticket for payment? |


Explanation of Change
Lots of file changes because I ran
npm run compress-svg/searchpageFixed Issues
https://github.com/Expensify/Expensify/issues/557403
PROPOSAL:
Tests
Test 1: Homepage and Search
/search?q=expense, skeleton loaders flash, then results appearTest 2: LHN Search and Platform Param
/search?q=...&platform=expensify-classicOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2026-02-03.at.05.31.49.mov
m-Web
https://github.com/user-attachments/assets/d5ec9d05-efc1-4b75-ac8e-a48b70ca9622
