Fix workspace mention not being recognized#81262
Fix workspace mention not being recognized#81262aldo-expensify merged 15 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aabf3d9250
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@huult, kindly bump. thanks. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-23.at.08.41.43.mp4Android: mWeb ChromeScreen.Recording.2026-02-23.at.08.44.03.mp4iOS: HybridAppScreen.Recording.2026-02-23.at.08.46.42.mp4iOS: mWeb SafariScreen.Recording.2026-02-23.at.08.47.44.mp4MacOS: Chrome / SafariScreen.Recording.2026-02-23.at.08.36.37.mp4 |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine for product
|
@huult, applied the AI feedback. Please take another look when you get a chance. Thanks. |
|
@marufsharifi Thanks, reviewing… |
Screen.Recording.2026-02-13.at.10.27.07.movWe end up with extra dots when the mention matches a suggestion. |
src/pages/inbox/report/ReportActionCompose/SuggestionMention.tsx
Outdated
Show resolved
Hide resolved
src/pages/inbox/report/ReportActionCompose/SuggestionMention.tsx
Outdated
Show resolved
Hide resolved
|
@marufsharifi Overall, it looks good and mostly works. Could you add unit tests to cover this? |
src/pages/inbox/report/ReportActionCompose/SuggestionMention.tsx
Outdated
Show resolved
Hide resolved
|
@huult, thanks for your patience. Applied your feedback. Please take another look when you get a chance. |
@marufsharifi Could you update the tests for the changes? |
|
@huult, thanks for your patience. Added a unit test. Please take another look. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.25-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
Explanation of Change
Fixed Issues
$ #80886
PROPOSAL: #80886 (comment)
Tests
Offline tests
Same as the test.
QA Steps
Same as the test.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-06.at.10.35.30.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-02-06.at.10.40.09.PM.mov
iOS: Native
Screen.Recording.2026-02-06.at.10.48.54.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-06.at.10.53.37.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-06.at.10.27.27.PM.mov