[Internal QA] Don't count CSV feeds from Classic as a feed in NewDot by allgandalf · Pull Request #81286 · Expensify/App

allgandalf · 2026-02-03T10:21:58Z

Explanation of Change

CSV uploads imported in Classic (e.g. csv#123456, ccupload) were being counted as company card feeds in NewDot. On Collect plan workspaces (limited to one feed), this incorrectly blocked users from adding bank feeds via Plaid.

The original fix (PR #77117) was reverted (PR #79206) because it changed the useIsBlockedToAddFeed hook from a useEffect/useState pattern to useMemo, which reactively recalculated when feeds changed — causing infinite loading after adding a feed mid-session.

This PR keeps the existing useEffect/useState pattern (which captures the feed count once on load and doesn't recalculate when feeds change during the session) but adds filtering to exclude CSV feeds and Expensify Cards from the count.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/569331

Tests

On a Collect plan workspace with only CSV-imported cards, navigate to Company Cards > Add cards
Verify the user is NOT blocked from adding a bank feed via Plaid
On a Collect plan workspace with a real bank feed (e.g. Plaid) + CSV feed, navigate to Company Cards > Add cards
Verify the user IS blocked from adding another feed
On a Collect plan workspace with only an Expensify Card, navigate to Company Cards > Add cards
Verify the user is NOT blocked from adding a bank feed
On a Control plan workspace, verify no blocking regardless of feeds
Add a feed mid-session and verify no infinite loading occurs

Verify that no errors appear in the JS console

Offline tests

N/A - Feed data is fetched from the server, offline behavior is unchanged.

QA Steps

On a Collect plan workspace with only CSV-imported cards, navigate to Company Cards > Add cards
Verify the user can add a bank feed via Plaid
On a Collect plan workspace with a real bank feed + CSV feed, verify the user is blocked from adding another feed
On a Control plan workspace, verify no blocking regardless of feeds

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

CSV uploads from Classic and Expensify Cards should not count toward the one-feed limit for Collect plan workspaces, so users are not incorrectly blocked from adding bank feeds via Plaid.

melvin-bot · 2026-02-03T10:22:05Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/CardUtils.ts

allgandalf · 2026-02-04T05:24:32Z

@mountiny next steps here is to get this tested by @eh2077 , @MariaHCD assigned us a test policy of csv feed, so @eh2077 would be able to test this PR . Apologies for not updating here :)

github-actions · 2026-02-04T06:16:09Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2026-02-04T06:18:07Z

Thread for this here https://expensify.slack.com/archives/C07NMDKEFMH/p1770185782100099

eh2077

Code looks good! I'll proceed with completing checklist once I was invited to a test policy with csv feed. fyi, my test account is ericwdev001+d3@gmail.com, thanks!

allgandalf · 2026-02-04T08:23:04Z

@eh2077 you can see this workspace right?:

eh2077 · 2026-02-04T08:29:56Z

Yes! thanksss!

eh2077 · 2026-02-04T08:30:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-02-04.at.5.27.57.PM.mov

iOS: HybridApp

Screen.Recording.2026-02-04.at.5.25.36.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-02-04.at.5.26.25.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-04.at.5.15.19.PM.mov

Screen.Recording.2026-02-04.at.5.21.52.PM.mov

eh2077

It seems we have issue with Android build, other platforms tested well!

melvin-bot · 2026-02-04T09:54:16Z

🎯 @eh2077, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #81387.

allgandalf · 2026-02-04T10:36:42Z

@eh2077 just wanted to confirm that you also tested the regression issue right?:

Company cards - Infinite loading on Add cards page when adding direct feed #79182

eh2077 · 2026-02-04T10:50:17Z

Yeah, confirmed it's working

Screen.Recording.2026-02-04.at.6.48.54.PM.mov

mountiny

Thanks!

github-actions · 2026-02-05T07:57:38Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-05T08:03:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81286.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-181547f-2e219f78ca3bc5337bdb26c14e30c9994ec2829b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-181547f-403a7d4b5b86c5a9d928e38f36d0492881f3b878/index.html

Web 🕸️
https://81286.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-05T08:07:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

joekaufmanexpensify · 2026-02-05T20:42:22Z

@mountiny @MariaHCD @allgandalf @eh2077 I just tested this one on the adhoc build and noticed this navigation issue if you try to add a direct feed on a collect workspace with a CSV feed from Expensify Classic. We should clean this up yeah?

2026-02-05_15-34-00.mp4

OSBotify · 2026-02-05T20:49:12Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:49:38Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2026-02-06T00:49:51Z

@allgandalf @eh2077 Could you please look into that and try to fix in a follow up?

OSBotify · 2026-02-10T07:05:33Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Exclude CSV feeds and Expensify Cards from Collect plan feed limit

0904db3

CSV uploads from Classic and Expensify Cards should not count toward the one-feed limit for Collect plan workspaces, so users are not incorrectly blocked from adding bank feeds via Plaid.

allgandalf requested review from a team as code owners February 3, 2026 10:21

melvin-bot bot assigned allgandalf Feb 3, 2026

melvin-bot bot requested review from eh2077 and trjExpensify February 3, 2026 10:22

melvin-bot bot removed request for a team and trjExpensify February 3, 2026 10:22

allgandalf added the InternalQA This pull request required internal QA label Feb 3, 2026

allgandalf changed the title ~~Don't count CSV feeds from Classic as a feed in NewDot~~ [Internal QA[ Don't count CSV feeds from Classic as a feed in NewDot Feb 3, 2026

allgandalf requested review from MariaHCD and mountiny February 3, 2026 10:23

allgandalf changed the title ~~[Internal QA[ Don't count CSV feeds from Classic as a feed in NewDot~~ [Internal QA] Don't count CSV feeds from Classic as a feed in NewDot Feb 3, 2026

github-actions bot reviewed Feb 3, 2026

View reviewed changes

src/libs/CardUtils.ts Show resolved Hide resolved

mountiny previously approved these changes Feb 4, 2026

View reviewed changes

src/libs/CardUtils.ts Show resolved Hide resolved

allgandalf commented Feb 4, 2026

View reviewed changes

src/libs/CardUtils.ts Show resolved Hide resolved

Apply suggestion from @allgandalf

ebb37b8

allgandalf dismissed mountiny’s stale review via ebb37b8 February 4, 2026 05:23

Merge branch 'Expensify:main' into allgandalf/fix-csv-feed-collect-block

1b756f4

This comment has been minimized.

Sign in to view

eh2077 reviewed Feb 4, 2026

View reviewed changes

eh2077 approved these changes Feb 4, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Feb 4, 2026

[Due for payment 2026-02-17] Payment issue for E/App PR#81286 #81387

Closed

mountiny approved these changes Feb 5, 2026

View reviewed changes

MariaHCD approved these changes Feb 5, 2026

View reviewed changes

MariaHCD merged commit 181547f into Expensify:main Feb 5, 2026
31 of 32 checks passed

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Closed

dominictb mentioned this pull request Mar 18, 2026

[HOLD E/E issue 594594 and App PR 85759] fix: navigation issue after adding Plaid feed in Collect workspace #85688

Draft

52 tasks

Conversation

allgandalf commented Feb 3, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

mountiny commented Feb 4, 2026

Uh oh!

This comment has been minimized.

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Feb 4, 2026

Uh oh!

eh2077 commented Feb 4, 2026

Uh oh!

eh2077 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 4, 2026

Uh oh!

allgandalf commented Feb 4, 2026

Uh oh!

eh2077 commented Feb 4, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

joekaufmanexpensify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

mountiny commented Feb 6, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eh2077 commented Feb 4, 2026 •

edited

Loading