Align export condition with BE check by luacmartins · Pull Request #81445 · Expensify/App

luacmartins · 2026-02-04T21:41:41Z

Explanation of Change

Aligns the export condition with BE logic.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/594467

Tests

Supportaled into the user account
Verified that the Export count is at 0 and no incorrect expenses are shown

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-04T22:09:49Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/libs/ReportPrimaryActionUtils.ts	`91.74% <100.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`92.39% <100.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
...onents/ReportActionItem/ExportWithDropdownMenu.tsx	`0.00% <0.00%> (ø)`
src/libs/ReportUtils.ts	`74.93% <83.33%> (-0.03%)`	⬇️
... and 15 files with indirect coverage changes

melvin-bot · 2026-02-12T21:45:25Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-12T21:45:30Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2026-02-12T21:46:15Z

Assigning @DylanDylann since this is related to the to-do counters project

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6ec1daddc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-12T21:54:25Z

src/libs/ReportUtils.ts

+            const label = originalMessage?.label;
+            // It's possible for originalMessage?.markedManually to be `false`, but the report is still has a valid automatic export.
+            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+            const isValidExport = originalMessage?.markedManually || (label && validExportLabels.has(label) && originalMessage?.type !== CONST.EXPORT_TEMPLATE);


Ignore optimistic export actions when determining success

Treating any labeled EXPORTED_TO_INTEGRATION action as a successful export causes failed exports to be misclassified in the fallback path. exportToIntegration() always adds an optimistic export action with a valid label before the API result, and on failure an INTEGRATIONS_MESSAGE is added while that export action remains (src/libs/actions/Report/index.ts), so this condition now returns true for a failed attempt that previously returned false. That affects code paths still using action-based fallback (for example src/pages/inbox/report/ReportDetailsExportPage.tsx and isPrimaryPayAction in src/libs/ReportPrimaryActionUtils.ts) or reports where isExportedToIntegration is absent, which can hide export-failure behavior and incorrectly treat reports as already exported.

Useful? React with 👍 / 👎.

While that makes sense, I copied over the BE logic so the new logic should align with what the server does.

JmillsExpensify

In align with product spec

DylanDylann · 2026-02-14T10:18:58Z

@luacmartins I think the report param should not be marked as optional. This seems to be a missed spot

App/src/libs/ReportPrimaryActionUtils.ts

Line 191 in a93a316

const isExported = isExportedUtil(reportActions);

DylanDylann · 2026-02-14T10:19:15Z

@luacmartins The test coverage has dropped due to our changes. Could you update the unit tests?

DylanDylann · 2026-02-14T10:24:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

DylanDylann · 2026-02-14T10:24:45Z

@luacmartins Before merging, could we have QA test this change on an ad-hoc build first?

melvin-bot · 2026-02-14T10:25:22Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-14T10:25:25Z

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #82484.

OSBotify · 2026-02-17T13:31:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-17T13:47:40Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-17T13:51:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81445.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8b7d321-f1b1b3d-dcf593369dcb3b5bfec46da05ca72a0ab9d60ff3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8b7d321-f1b1b3d-ea71e56cbdaec0d37fdbec16f0d4daf1447f8331/index.html

Web 🕸️
https://81445.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T00:06:07Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ndition2" This reverts commit 8b7d321, reversing changes made to 13da2f9.

OSBotify · 2026-02-18T22:01:41Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-18T22:20:28Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:21:18Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:35:38Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Align export condition with BE check

2ae9b7a

luacmartins self-assigned this Feb 4, 2026

rm comment

193f24c

luacmartins added 4 commits February 10, 2026 01:00

Merge branch 'main' into cmartins-fixExportCondition2

69a7b86

Merge branch 'main' into cmartins-fixExportCondition2

d1818fb

Update isExported logic

7968871

fix lint

48a7baa

luacmartins changed the title ~~Align export condition with BE check~~ [HOLD Auth 19858] Align export condition with BE check Feb 10, 2026

Merge branch 'main' into cmartins-fixExportCondition2

a6ec1da

luacmartins changed the title ~~[HOLD Auth 19858] Align export condition with BE check~~ Align export condition with BE check Feb 12, 2026

luacmartins requested a review from JS00001 February 12, 2026 21:44

luacmartins added the InternalQA This pull request required internal QA label Feb 12, 2026

luacmartins marked this pull request as ready for review February 12, 2026 21:45

luacmartins requested review from a team as code owners February 12, 2026 21:45

melvin-bot bot requested review from JmillsExpensify and parasharrajat and removed request for a team February 12, 2026 21:45

melvin-bot bot requested review from a team and Ollyws and removed request for a team February 12, 2026 21:45

melvin-bot bot removed the request for review from a team February 12, 2026 21:45

luacmartins requested review from DylanDylann and removed request for Ollyws and parasharrajat February 12, 2026 21:45

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

JS00001 approved these changes Feb 13, 2026

View reviewed changes

JmillsExpensify approved these changes Feb 13, 2026

View reviewed changes

DylanDylann approved these changes Feb 14, 2026

View reviewed changes

melvin-bot bot requested a review from cristipaval February 14, 2026 10:25

melvin-bot bot mentioned this pull request Feb 14, 2026

Payment issue for E/App PR#81445 #82484

Closed

cristipaval approved these changes Feb 16, 2026

View reviewed changes

JS00001 merged commit 8b7d321 into main Feb 17, 2026
37 of 43 checks passed

JS00001 deleted the cmartins-fixExportCondition2 branch February 17, 2026 13:23

OSBotify mentioned this pull request Feb 17, 2026

Deploy Checklist: New Expensify 2026-02-17 #82716

Closed

93 tasks

cristipaval added a commit that referenced this pull request Feb 18, 2026

Revert "Merge pull request #81445 from Expensify/cmartins-fixExportCo…

a689fd3

…ndition2" This reverts commit 8b7d321, reversing changes made to 13da2f9.

This was referenced Feb 18, 2026

[CP Staging] Revert "Align export condition with BE check" #82844

Merged

[Due for payment 2026-03-02] Expense - "You rejected this report" appears in report after admin reopens report #82744

Closed

mountiny mentioned this pull request Feb 18, 2026

Revert "[CP Staging] Revert "Align export condition with BE check"" #82861

Merged

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

Conversation

luacmartins commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

luacmartins commented Feb 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 14, 2026

Uh oh!

DylanDylann commented Feb 14, 2026

Uh oh!

DylanDylann commented Feb 14, 2026

Reviewer Checklist

Uh oh!

DylanDylann commented Feb 14, 2026

Uh oh!

melvin-bot bot commented Feb 14, 2026

Uh oh!

melvin-bot bot commented Feb 14, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luacmartins commented Feb 4, 2026 •

edited

Loading

codecov bot commented Feb 4, 2026 •

edited by github-actions bot

Loading