Skip to content

[No QA] Update docs to reflect GL Code column in Categories and Tags tables#81468

Merged
RachCHopkins merged 11 commits intomainfrom
helpsite-add-GL-to-category-table
Feb 10, 2026
Merged

[No QA] Update docs to reflect GL Code column in Categories and Tags tables#81468
RachCHopkins merged 11 commits intomainfrom
helpsite-add-GL-to-category-table

Conversation

@stephanieelliott
Copy link
Contributor

Added documentation for the new GL Code column that now appears in the Categories and Tags table views for Workspace Admins.

  • Updated Create-expense-categories.md to clarify GL codes are visible in table

  • Updated Create-expense-tags.md to mention GL Code column visibility

Related Design request for images: https://github.com/Expensify/Expensify/issues/597217

stephanieelliott and others added 4 commits February 4, 2026 17:51
Added documentation for the new GL Code column that now appears in the Categories and Tags table views for Workspace Admins.

- Updated Create-expense-categories.md to clarify GL codes are visible in table

- Updated Create-expense-tags.md to mention GL Code column visibility

- Updated Require-tags-and-categories-for-expenses.md with table column info

- Updated Workspace-Rules.md to include GL Code in table descriptions

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

HelpDot Documentation Review

Overall Assessment

This PR adds documentation for the new GL Code column visibility in the Categories and Tags table views for Workspace Admins. The changes are straightforward and well-targeted, updating three documentation files to clarify that GL codes are now visible to admins in table views. The updates are contextually appropriate and improve user understanding of the feature.

Scores Summary

  • Readability: 9/10 - The writing is clear, concise, and maintains excellent flow. The additions integrate seamlessly with existing content and use appropriate language for the target audience.
  • AI Readiness: 8/10 - Good context and structure. The changes maintain proper heading hierarchy and add descriptive content. Minor opportunity to enhance searchability with more explicit feature descriptions.
  • Style Compliance: 9/10 - Excellent adherence to Expensify style guidelines. Proper use of terminology ("Workspace Admins," "workspace members"), consistent formatting, and appropriate voice.

Key Findings

Strengths:

  • Clear distinction between "Workspace Admins" (who can see GL codes) and "workspace members" (who cannot)
  • Consistent messaging across both Categories and Tags documentation
  • Updates placed in logical locations within the document flow
  • Maintains the existing helpful suggestion for workaround (including GL codes in names if member visibility is needed)
  • New table description adds helpful context at the beginning of both documents

Minor Issues:

  • Workspace-Rules.md: The change appears to be whitespace-only (trailing space added to line 102), which adds no value
  • Slight redundancy: The phrase "GL codes are visible to Workspace Admins in the Tags table" appears twice in Create-expense-tags.md (lines 42 and 119 in the updated version), though in slightly different contexts

Opportunities for Enhancement:

  • Consider adding a screenshot callout specifically highlighting the GL Code column in the table view (though the PR notes this is on hold pending design)
  • The FAQ answer in Create-expense-categories.md could potentially reference the new table view more explicitly

Recommendations

Required Actions:

  1. Remove the whitespace-only change in Workspace-Rules.md - This appears to be an accidental edit and should be reverted

Optional Improvements:

  1. Consider whether the repeated mention of GL code visibility in the Tags import section (line 42) and the GL code editing section (line 119) is intentional or could be streamlined
  2. When images become available, ensure the new GL Code column is clearly visible in screenshots to reinforce the text descriptions

Positive Elements to Maintain:

  • The parallel structure between Categories and Tags documentation
  • The clear distinction between admin and member visibility
  • The practical workaround suggestion for member visibility needs

Files Reviewed

  • Create-expense-categories.md: Good additions. New table description is helpful, and the FAQ update provides important clarification about admin-only visibility.
  • Create-expense-tags.md: Solid updates throughout. Multiple touchpoints reinforce the GL code visibility feature appropriately.
  • Workspace-Rules.md: Whitespace-only change that should be removed.

Conclusion

This is a high-quality documentation update that successfully communicates the new GL Code column visibility feature. With the removal of the unnecessary whitespace change in Workspace-Rules.md, this PR will be ready for approval. The writing is clear, consistent, and follows Expensify standards effectively.

Overall Score: 8.7/10


Detailed line-by-line feedback has been provided as inline comments where applicable.

@github-actions github-actions bot changed the title [HOLD on image] Update docs to reflect GL Code column in Categories and Tags tables [No QA] [HOLD on image] Update docs to reflect GL Code column in Categories and Tags tables Feb 5, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Feb 5, 2026

@stephanieelliott stephanieelliott requested review from a team as code owners February 7, 2026 01:24
@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team February 7, 2026 01:24
@melvin-bot
Copy link

melvin-bot bot commented Feb 7, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot melvin-bot bot requested review from RachCHopkins and luacmartins and removed request for a team February 7, 2026 01:24
@melvin-bot
Copy link

melvin-bot bot commented Feb 7, 2026

@luacmartins @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott stephanieelliott removed the request for review from luacmartins February 7, 2026 01:36
@stephanieelliott stephanieelliott changed the title [No QA] [HOLD on image] Update docs to reflect GL Code column in Categories and Tags tables [No QA] Update docs to reflect GL Code column in Categories and Tags tables Feb 7, 2026
Copy link
Contributor

@RachCHopkins RachCHopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@RachCHopkins RachCHopkins merged commit c298874 into main Feb 10, 2026
12 of 13 checks passed
@RachCHopkins RachCHopkins deleted the helpsite-add-GL-to-category-table branch February 10, 2026 19:50
@melvin-bot melvin-bot bot added the Emergency label Feb 10, 2026
@melvin-bot
Copy link

melvin-bot bot commented Feb 10, 2026

@RachCHopkins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.3.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants