Skip to content

[No QA] Update View-the-Top-Categories-report.md#81473

Merged
stephanieelliott merged 1 commit intostephanieelliott-patch-31from
stephanieelliott-patch-33
Feb 5, 2026
Merged

[No QA] Update View-the-Top-Categories-report.md#81473
stephanieelliott merged 1 commit intostephanieelliott-patch-31from
stephanieelliott-patch-33

Conversation

@stephanieelliott
Copy link
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@stephanieelliott stephanieelliott merged commit ba937e8 into stephanieelliott-patch-31 Feb 5, 2026
6 of 8 checks passed
@stephanieelliott stephanieelliott deleted the stephanieelliott-patch-33 branch February 5, 2026 05:09
## How to interpret the Top Categories report

Each row represents a single expense category, sorted in descending order by total spend. Columns include:
Each category entry represents a single expense category, ordered from highest to lowest total spend. The report shows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: "ordered from highest to lowest total spend" is unnecessarily verbose. The original phrase "sorted in descending order" is more concise and clearer. Simplify to maintain scannability.

- **Total amount spent** in that category

Click any row to view all expenses tied to that category.
Select a category to review all expenses included in that grouping.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: "Select a category to review all expenses included in that grouping" is unnecessarily wordy. "Grouping" is vague corporate jargon. The original "Click any row to view all expenses tied to that category" was clearer and more direct.


## How to switch the Top Categories report to table view

By default, the Top Categories report displays a bar chart. The table view shows expense categories sorted in descending order by total spend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: This sentence repeats information that was just stated in the previous sentence. The second sentence "The table view shows expense categories sorted in descending order by total spend" is redundant - this was already explained in line 50. Remove the duplicate information.

1. Click **View** in the top navigation tabs.
2. Select **Table**.

The table view shows expense categories as rows sorted in descending order by total spend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: This sentence duplicates information already provided in the introduction (line 77). The explanation of what table view shows is repeated three times in this section. Remove this redundant sentence to improve clarity and scannability.


---

## How to switch the Top Categories report to table view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Readiness violation: Heading uses vague pronoun "the Top Categories report" when it should be more descriptive. Consider: "How to switch Top Categories from chart to table view" or "How to view Top Categories as a table" for better AI parsing and user clarity.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

HelpDot Documentation Review

Overall Assessment

This PR introduces minor improvements to the Top Categories report documentation by refining language for clarity and adding a new section on switching to table view. The changes are generally well-written but contain some style and consistency issues that impact overall quality.

Scores Summary

  • Readability: 7/10 - Language improvements enhance clarity, but some redundancy and passive voice reduce effectiveness. The new section is clear and well-structured.
  • AI Readiness: 6/10 - Section headings use descriptive "How to" format which is good, but there's inconsistency in terminology and some vague references. Missing YAML metadata assessment.
  • Style Compliance: 6/10 - Mixed adherence to Expensify style guidelines. Some improvements in natural language, but issues with redundancy and inconsistent terminology.

Key Findings

Positive Aspects:

  • Simplified "How to interpret" section removes technical jargon ("row" replaced with "category entry")
  • New table view section follows a clear, actionable format with numbered steps
  • More natural phrasing ("Select a category" vs "Click any row")

Issues Identified:

  1. Redundancy - The new section repeats "sorted in descending order by total spend" twice within three sentences
  2. Inconsistent UI terminology - Uses "Click" in one place but likely should be "Select" for consistency with rest of changes
  3. Passive voice - "The table view shows" could be more direct
  4. Vague reference - "that grouping" is less specific than needed
  5. Missing context - Doesn't explain why/when users might prefer table view over chart view

Recommendations

Priority Actions:

  1. Remove redundant phrase in the new section (lines 84-85 repeat the same information)
  2. Standardize button/UI interaction terminology throughout (prefer "Select" over "Click")
  3. Add brief context explaining when table view is useful vs chart view
  4. Replace "that grouping" with "that category" for consistency

Suggestions for Enhancement:

  • Consider adding a visual indicator note about how to identify the View toggle
  • Brief mention of any differences in functionality between views (if applicable)

Files Reviewed

  • docs/articles/new-expensify/insights/View-the-Top-Categories-report.md - Minor language improvements with new table view section. Contains redundancy and style inconsistencies that should be addressed in follow-up.

Note: This PR has already been merged. Recommendations apply to future documentation updates for this file.

@github-actions github-actions bot changed the title Update View-the-Top-Categories-report.md [No QA] Update View-the-Top-Categories-report.md Feb 5, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Feb 5, 2026

A preview of your ExpensifyHelp changes have been deployed to https://72514168.helpdot.pages.dev ⚡️

Updated articles:

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants