fix: Mark as unread doesn’t work with IOU report by paulnjs · Pull Request #81499 · Expensify/App

paulnjs · 2026-02-05T09:29:51Z

Explanation of Change

Fixed Issues

$#80486
PROPOSAL:#80486 (comment)

Tests

Open the app
Login with an account with IOU report
Long press or right click on an IOU report on LHN, choose "Mark as unread"
Verify IOU report title is bold on LHN

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Login with an account with IOU report
Long press or right click on an IOU report on LHN, choose "Mark as unread"
Verify IOU report title is bold on LHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_sfr.mov

MacOS: Chrome / Safari

chorme.mov

melvin-bot · 2026-02-08T17:15:21Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51ad7c9b4c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/ReportUtils.ts

joekaufmanexpensify

Good for product

truph01 · 2026-02-13T08:43:53Z

@paulnjs PR has conflict.

Also, could you please go through all the AI suggestions, react to each one with 👍 or 👎, and provide a brief explanation for your decision? Thanks!

truph01 · 2026-03-04T08:19:55Z

Sorry, this one is missing from my K2. Reviewing now

truph01 · 2026-03-04T08:20:04Z

@paulnjs Could you resolve conflict?

paulnjs · 2026-03-04T10:09:06Z

@truph01 Resolved

truph01 · 2026-03-05T08:53:45Z

src/libs/actions/Report/index.ts

            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                lastReadTime,
+                ...(lastActorAccountID !== undefined && {lastActorAccountID}),


@paulnjs This logic was intended to address the following concern mentioned in your proposal:

This function only updates lastReadTime and does not update lastActorAccountID, which may result in lastActorAccountID being missed when called with an IOU report.

However, after testing, I was unable to find any scenario in which lastActorAccountID becomes undefined.

Could you share the case where it occurs?

@truph01 This is the case that I debugged

Screen.Recording.2026-03-13.at.14.55.30.mov

src/libs/ReportUtils.ts

truph01 · 2026-03-05T09:04:35Z

@paulnjs I left a few comments, please help check.

truph01 · 2026-03-31T04:41:14Z

@paulnjs We have conflict again

paulnjs · 2026-03-31T07:52:11Z

@truph01 Resolved

truph01 · 2026-03-31T08:06:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-31.at.15.13.37.mov

Android: mWeb Chrome

Screen.Recording.2026-03-31.at.15.11.05.mov

iOS: HybridApp

Screen.Recording.2026-03-31.at.15.14.37.mov

iOS: mWeb Safari

Screen.Recording.2026-03-31.at.15.11.41.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-31.at.15.10.08.mov

github-actions · 2026-03-31T14:37:34Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-31T14:41:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81499.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f69c7cf-0c048d4-239e14b5208754764117938b636b6885fc143e25/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://81499.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-31T14:46:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2026-03-31T15:23:20Z

FYI this PR is making TS fail on main

Error: src/components/LHNOptionsList/OptionRowLHNData.tsx(48,12): error TS2451: Cannot redeclare block-scoped variable 'reportActions'.
Error: src/components/LHNOptionsList/OptionRowLHNData.tsx(120,12): error TS2451: Cannot redeclare block-scoped variable 'reportActions'.
Error: Process completed with exit code 2.

truph01 · 2026-03-31T15:32:01Z

@MelvinBot Create PR to fix this #81499 (comment)

MelvinBot · 2026-03-31T15:33:42Z

🤖 Cannot proceed: truph01 does not have write access to the target repository (Expensify/App). MelvinBot will not create branches or PRs on repos that the requesting user cannot access themselves.

luacmartins · 2026-03-31T15:34:12Z

PR fixing it here #86756

truph01 · 2026-03-31T15:37:09Z

I'm not sure why everything passed when I approved it.

What was your experience when merging this, @Valforte?

OSBotify · 2026-03-31T20:01:16Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.51-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-31T20:03:09Z

🤖 Help Site Review — No Changes Required

I reviewed all files under docs/articles/ for content related to "mark as unread", IOU reports, and the unread indicator behavior modified by this PR.

Findings:

There are no existing help site articles that document the "Mark as unread" feature. The term "unread" only appears in passing references (e.g., the #focus filter description in Prioritize-and-Pin-Chats.md, and search operators in Using-search-operators.md).
This PR is a bug fix — it corrects the isUnread logic so that IOU reports properly show as unread when marked. It does not introduce any new user-facing features, UI elements, settings, or workflows.
No feature names, button labels, tab names, or settings were changed.

Conclusion: Since this is a code-level bug fix to existing behavior (not a new feature or changed UI), no updates to the help site documentation are required.

trjExpensify · 2026-03-31T23:05:32Z

@Valforte @luacmartins https://expensify.slack.com/archives/C05LX9D6E07/p1774997693250829?thread_ts=1774991107.356179&cid=C05LX9D6E07

Since the deploy, a bunch of workspace chats appeared unread in my LHN and when I clicked into them they scroll me back to random IOU previews in the chat. Not entirely sure if it's related to this PR or not.

2026-03-31_23-53-06.mp4

luacmartins · 2026-03-31T23:19:00Z

@Valforte @paulnjs @truph01 could you please take a look ^

trjExpensify · 2026-04-02T11:00:00Z

@paulnjs did you look at this?

paulnjs · 2026-04-02T11:53:24Z

@trjExpensify Sorry, I didn't have time check it ytd. Will check it today and get back to you asap

s77rt · 2026-04-02T15:55:40Z

src/libs/ReportUtils.ts


    // If the user was mentioned and the comment got deleted the lastMentionedTime will be more recent than the lastVisibleActionCreated
-    return lastReadTime < (lastVisibleActionCreated ?? '') || lastReadTime < lastMentionedTime;
+    return lastReadTime < (lastVisibleActionCreated ?? '') || lastReadTime < lastMentionedTime || lastReadTime < (latestReportActionFromOtherUsers?.created ?? '');


We should not look into report actions to determine if the report is unread. We should keep using only lastVisibleActionCreated as we don't want to mark the report unread if last action is non-actionable (e.g. system message)

s77rt · 2026-04-02T17:06:53Z

We are reverting the PR #86980

OSBotify · 2026-04-02T19:52:39Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

paulnjs · 2026-04-03T02:07:18Z

Created #87041 to fix the original issue

fix: Mark as unread doesn’t work with IOU report

084a342

melvin-bot bot assigned paulnjs Feb 5, 2026

paulnjs added 3 commits February 9, 2026 00:00

update unit test

c7484cc

Merge branch 'main' into paulnjs-fix/80486

0b6cac3

update code

51ad7c9

paulnjs marked this pull request as ready for review February 8, 2026 17:15

paulnjs requested review from a team as code owners February 8, 2026 17:15

melvin-bot bot requested review from joekaufmanexpensify and truph01 and removed request for a team February 8, 2026 17:15

melvin-bot bot removed the request for review from a team February 8, 2026 17:15

github-actions bot reviewed Feb 8, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 8, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

paulnjs added 2 commits February 9, 2026 00:33

refactor code

21142b3

update code

ae8d91f

joekaufmanexpensify previously approved these changes Feb 9, 2026

View reviewed changes

Merge branch 'main' into paulnjs-fix/80486

881db58

paulnjs dismissed joekaufmanexpensify’s stale review via 881db58 February 13, 2026 08:51

Merge branch 'main' into paulnjs-fix/80486

ec3be4f

truph01 reviewed Mar 5, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

truph01 reviewed Mar 5, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

Merge branch 'main' into paulnjs-fix/80486

343b658

Merge branch 'main' into paulnjs-fix/80486

0ebb8dd

truph01 approved these changes Mar 31, 2026

View reviewed changes

melvin-bot bot requested a review from Valforte March 31, 2026 07:57

Valforte approved these changes Mar 31, 2026

View reviewed changes

Valforte merged commit f69c7cf into Expensify:main Mar 31, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Mar 31, 2026

Deploy Checklist: New Expensify 2026-03-31 #86774

Closed

s77rt reviewed Apr 2, 2026

View reviewed changes

s77rt mentioned this pull request Apr 2, 2026

[CP Staging] Revert "fix: Mark as unread doesn’t work with IOU report" #86980

Merged

50 tasks

MelvinBot mentioned this pull request Apr 2, 2026

🍒 Cherry pick PR #86980 to staging 🍒 #86983

Merged

50 tasks

mallenexpensify mentioned this pull request Apr 9, 2026

[$250] iOS - Mark as unread doesn’t work with IOU report #80486

Open

7 tasks

Conversation

paulnjs commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 8, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Feb 13, 2026

Uh oh!

truph01 commented Mar 4, 2026

Uh oh!

truph01 commented Mar 4, 2026

Uh oh!

paulnjs commented Mar 4, 2026

Uh oh!

truph01 Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

paulnjs Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

truph01 commented Mar 5, 2026

Uh oh!

truph01 commented Mar 31, 2026

Uh oh!

paulnjs commented Mar 31, 2026

Uh oh!

truph01 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

luacmartins commented Mar 31, 2026

Uh oh!

truph01 commented Mar 31, 2026

Uh oh!

MelvinBot commented Mar 31, 2026

Uh oh!

luacmartins commented Mar 31, 2026

Uh oh!

truph01 commented Mar 31, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

MelvinBot commented Mar 31, 2026

Uh oh!

trjExpensify commented Mar 31, 2026

Uh oh!

luacmartins commented Mar 31, 2026

Uh oh!

trjExpensify commented Apr 2, 2026

Uh oh!

paulnjs commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt Apr 2, 2026

paulnjs commented Feb 5, 2026 •

edited

Loading

truph01 commented Mar 31, 2026 •

edited

Loading

paulnjs commented Apr 2, 2026 •

edited

Loading