Conversation
carlosmiceli
approved these changes
Feb 5, 2026
Closed
7 tasks
Contributor
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
melvin-bot
bot
requested review from
a team,
abdulrahuman5196 and
heyjennahay
and removed request for
a team and
heyjennahay
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
lakchote
approved these changes
Feb 5, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: queryString}), {forceReplace: true}); | ||
| } else { | ||
| Navigation.dismissModal(); | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
The ESLint rule disable comment lacks a justification explaining why InteractionManager.runAfterInteractions() is being used despite being deprecated.
Suggested fix:
Add a comment explaining the reason for using the deprecated API:
// eslint-disable-next-line @typescript-eslint/no-deprecated
// InteractionManager is needed here to ensure navigation happens after modal dismiss animations complete on wide layouts
InteractionManager.runAfterInteractions(() => {
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: queryString}));
});Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dd2c0a54f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
OSBotify
pushed a commit
that referenced
this pull request
Feb 5, 2026
Fix Android screen flash (cherry picked from commit c4b8c06) (cherry-picked to staging by Julesssss)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.13-1 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.15-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes an Android deploy blocker where Android screen flashes during navigation.
Fixed Issues
$ #81450
Tests
Screen_recording_20260205_104406.mp4
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari