Fix: "Attachment can't be downloaded" error when downloading receipt by linhvovan29546 · Pull Request #81652 · Expensify/App

linhvovan29546 · 2026-02-06T08:41:37Z

Explanation of Change

Fixed Issues

$ #80860
PROPOSAL: #80860 (comment)

Tests

Create scan expense in the workspace chat, uploading a valid receipt (not pdf)
Fully close the app
Reopen the app, open any chat with a attachments
Open a attachments, click Download
Verify that "Attachment successfully downloaded" is shown on the screen

Verify that no errors appear in the JS console

Offline tests

No impact offline mode.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-06.at.18.51.45.mov

Android: mWeb Chrome

Screen.Recording.2026-02-06.at.18.36.06.mov

iOS: Native

Screen.Recording.2026-02-06.at.19.29.14.mov

iOS: mWeb Safari

Screen.Recording.2026-02-06.at.18.54.01.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-06.at.18.33.59.mov

linhvovan29546 · 2026-02-06T12:08:32Z

src/components/PDFThumbnail/index.native.tsx

 import type PDFThumbnailProps from './types';

-function PDFThumbnail({previewSourceURL, style, isAuthTokenRequired = false, enabled = true, fitPolicy = 0, onPassword, onLoadError, onLoadSuccess}: PDFThumbnailProps) {
+function PDFThumbnail({previewSourceURL, style, enabled = true, fitPolicy = 0, onPassword, onLoadError, onLoadSuccess}: PDFThumbnailProps) {


I checked the other places where the PDFThumbnail component is used, and we no longer use isAuthTokenRequired. Since it’s no longer needed, I removed this prop and addEncryptedAuthTokenToURL

codecov · 2026-02-06T12:42:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/VideoPlayer/BaseVideoPlayer.tsx	`48.44% <100.00%> (+0.40%)`	⬆️
...ts/VideoPlayerContexts/VideoPopoverMenuContext.tsx	`86.95% <100.00%> (+0.59%)`	⬆️
src/libs/addEncryptedAuthTokenToURL.ts	`100.00% <100.00%> (ø)`
...tModalScreen/routes/hooks/useDownloadAttachment.ts	`100.00% <100.00%> (+71.42%)`	⬆️
...rc/components/Attachments/AttachmentView/index.tsx	`51.13% <50.00%> (+0.56%)`	⬆️
src/components/PDFThumbnail/index.native.tsx	`10.00% <0.00%> (+0.90%)`	⬆️
src/components/PDFThumbnail/index.tsx	`0.00% <0.00%> (ø)`
...orAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/Report/index.ts	`61.45% <0.00%> (ø)`
... and 4 more
... and 8 files with indirect coverage changes

melvin-bot · 2026-02-06T12:52:19Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/Composer/implementation/index.tsx

src/components/VideoPlayer/BaseVideoPlayer.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 875f359aad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Composer/implementation/index.tsx

mananjadhav

I reviewed the code.

Can we trigger an adhoc build for this one?

Valforte · 2026-02-10T13:30:48Z

I'll trigger an ad-hoc build

github-actions · 2026-02-10T14:05:21Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-10T14:07:21Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81652.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

Valforte · 2026-02-10T14:15:42Z

Please merge main so the ad hoc build works

…ent-on-mobile

github-actions · 2026-02-10T14:57:03Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-10T15:01:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81652.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-66ad53c5f4c4c90347dfc885a5faeb3704da693b-27c4bed4e1bad1547533f64eeead688916046d3b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-66ad53c5f4c4c90347dfc885a5faeb3704da693b-d61873b20eca4b461028c5927fe580bab8fc178b/index.html

Web 🕸️
https://81652.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mananjadhav

The code changes are fine. Just the QA is taking a bit longer. I'll finish this tomorrow. The method call changed at 15+ places so need to test it.

mananjadhav · 2026-02-12T17:42:20Z

@linhvovan29546 Can you please resolve conflicts?

linhvovan29546 · 2026-02-12T17:45:51Z

Resolving

linhvovan29546 · 2026-02-12T17:51:55Z

@linhvovan29546 Can you please resolve conflicts?

Done, just waiting for the workflow to complete.

mananjadhav · 2026-02-12T19:06:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-attachment-download.mov

Android: mWeb Chrome

mweb-chrome-attachment-download.mov

iOS: HybridApp

ios-attachment-download.MP4

iOS: mWeb Safari

mweb-safari-attachment-download.MP4

MacOS: Chrome / Safari

web-attachment-download.mov

mananjadhav · 2026-02-12T19:11:12Z

@linhvovan29546 Can you fix the type in the PR title can't ?

linhvovan29546 · 2026-02-13T02:30:15Z

@linhvovan29546 Can you fix the type in the PR title can't ?

Done. Previously I was unable to update PR titles across my PR, this is now resolved

Valforte

LGTM

github-actions · 2026-02-13T13:58:39Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-13T13:59:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-13T14:02:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81652.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-37141f940dc9a35de62173017fea69d028653317-7651e83217265ec00c08a80c5e415faab71d47c8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-37141f940dc9a35de62173017fea69d028653317-5cec6d15d5aac59028e47630f5f60453a4c39a12/index.html

Web 🕸️
https://81652.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-13T19:10:49Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.19-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2026-02-15T03:13:24Z

src/components/Composer/implementation/index.tsx

    const styles = useThemeStyles();
+    const session = useSession();
+    const encryptedAuthToken = session?.encryptedAuthToken ?? '';
+    const addAuthTokenToImageURL = (url: string) => addEncryptedAuthTokenToURL(url, encryptedAuthToken);


This component is not react compilable so auto memoization didn't work. So it caused #82465.

In the future, please carefully check if component is react compilable or not when remove manual memoization.

For this check, install react-compiler-marker extension.

OSBotify · 2026-02-16T15:26:32Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chore: remove encryptedAuthToken usage from Onyx.connect

828b74d

melvin-bot bot assigned linhvovan29546 Feb 6, 2026

linhvovan29546 added 2 commits February 6, 2026 15:49

chore: fix eslint fail and reoder value

dec416f

chore: write test for addEncryptedAuthTokenToURL

6cddb9b

linhvovan29546 commented Feb 6, 2026

View reviewed changes

chore: test fail

875f359

linhvovan29546 marked this pull request as ready for review February 6, 2026 12:52

linhvovan29546 requested review from a team as code owners February 6, 2026 12:52

melvin-bot bot requested review from JmillsExpensify and mananjadhav and removed request for a team February 6, 2026 12:52

github-actions bot reviewed Feb 6, 2026

View reviewed changes

src/components/Composer/implementation/index.tsx Show resolved Hide resolved

github-actions bot reviewed Feb 6, 2026

View reviewed changes

src/components/VideoPlayer/BaseVideoPlayer.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 6, 2026

View reviewed changes

src/components/Composer/implementation/index.tsx Show resolved Hide resolved

mananjadhav approved these changes Feb 9, 2026

View reviewed changes

melvin-bot bot requested a review from Valforte February 9, 2026 08:41

This comment has been minimized.

Sign in to view

Valforte added the Ready To Build label Feb 10, 2026

Expensify deleted a comment from github-actions bot Feb 10, 2026

Merge branch 'Expensify:main' into fix/80860-can-not-download-attachm…

66ad53c

…ent-on-mobile

mananjadhav reviewed Feb 11, 2026

View reviewed changes

Merge branch 'main' into fix/80860-can-not-download-attachment-on-mobile

78b86d9

mananjadhav approved these changes Feb 12, 2026

View reviewed changes

linhvovan29546 changed the title ~~Fix: "Attachment ca't be downloaded" error when downloading receipt~~ Fix: "Attachment can't be downloaded" error when downloading receipt Feb 13, 2026

Valforte approved these changes Feb 13, 2026

View reviewed changes

Valforte merged commit 37141f9 into Expensify:main Feb 13, 2026
31 checks passed

OSBotify mentioned this pull request Feb 13, 2026

Deploy Checklist: New Expensify 2026-02-13 #82449

Closed

69 tasks

situchan mentioned this pull request Feb 13, 2026

[CP Staging] Revert "Fix: "Attachment can't be downloaded" error when downloading receipt" #82457

Merged

54 tasks

linhvovan29546 mentioned this pull request Feb 14, 2026

Fix: "Attachment can't be downloaded" error when downloading receipt #82479

Merged

53 tasks

situchan reviewed Feb 15, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Feb 16, 2026

[Due for payment 2026-02-23] [$250] Scan expense-"Attachment ca't be downloaded" error when downloading receipt #80860

Open

7 tasks

situchan mentioned this pull request Feb 23, 2026

[Due for payment 2026-02-24] Web - Chat - Unable to select all text in the composer via CMD+A or double clicking #82465

Closed

7 tasks

Conversation

linhvovan29546 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Valforte commented Feb 10, 2026

Uh oh!

This comment has been minimized.

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

Valforte commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Feb 12, 2026

Uh oh!

linhvovan29546 commented Feb 12, 2026

Uh oh!

linhvovan29546 commented Feb 12, 2026

Uh oh!

mananjadhav commented Feb 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Feb 12, 2026

Uh oh!

linhvovan29546 commented Feb 13, 2026

Uh oh!

Valforte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

situchan Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

linhvovan29546 commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited by github-actions bot

Loading