Fix points clipping by borys3kk · Pull Request #81669 · Expensify/App

borys3kk · 2026-02-06T11:40:47Z

Explanation of Change

Changed calculation logic for domainPadding in LineChartContent, ensuring that we always have enough space to render full dots / labels.

Fixed Issues

$ #81611
$ #81611 (comment)
PROPOSAL:

Tests

Testcase 1 (point cutoff test)
Prerequisite: Have an account with many merchants/months/something else that can be groupped-by

Go to Reports tab
Select view:line and your preferred group-by filter
Change size of Window (If you're on web, if on mobile just omit this step)
Ensure that at any time no point is cut off

Testcase 2 (label cutoff test)

Go to Reports tab
Select view:line and group-by month
Change date to year to date (or something similar so that you have exactly two points in a chart)
Change size of window (if you're on web, if on mobile just omit this step)
Ensure that at any time no label is cut off (the issue originated from label cutoff on right hand side of the chart, but ensure that none of them overlap/are cut off)

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-02-06.at.16.23.15.mov

iOS: mWeb Safari

Screen.Recording.2026-02-06.at.16.39.43.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-06.at.16.12.06.mov

codecov · 2026-02-06T11:51:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/components/Charts/LineChart/LineChartContent.tsx	`11.11% <33.33%> (+2.02%)`	⬆️
... and 423 files with indirect coverage changes

melvin-bot · 2026-02-06T15:42:01Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-06T15:42:07Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2026-02-06T15:43:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

aimane-chnaif · 2026-02-06T16:07:00Z

src/components/Charts/LineChart/LineChartContent.tsx

        // Only reduce if both sides have excess space (labels short enough for 0°)
        // If canReduce <= 0, labels are too long and hook will use rotation/truncation
-        const horizontalPadding = canReduce > 0 ? geometricPadding - canReduce : geometricPadding;
+        const extraPadding = canReduce > 0;


NAB: As it's boolean, extraPadding can be renamed to something like hasExtraPadding

Can you address this one @borys3kk? I agree it should follow our boolean naming conventions. Something like:

Suggested change

const extraPadding = canReduce > 0;

const shouldUseExtraPadding = canReduce > 0;

canReduce is also a weird name for a non-boolean variable. It seems like it's a number we use in various places. Can we instead name that to be something that better explains what that number is.

mateuuszzzzz · 2026-02-09T12:19:01Z

I can still reproduce this issue. I'm afraid we might need to adjust hook that handles labels' layout to take space on the edges into consideration.

(Data on screenshot is mocked so it doesn't make any sense)

puneetlath · 2026-02-09T17:19:45Z

@mateuuszzzzz do we want to address that in this PR?

mateuuszzzzz · 2026-02-10T09:51:24Z

Let's merge this one, I'll address remaining issue in separate PR

puneetlath · 2026-02-10T15:35:51Z

src/components/Charts/LineChart/LineChartContent.tsx

        // Only reduce if both sides have excess space (labels short enough for 0°)
        // If canReduce <= 0, labels are too long and hook will use rotation/truncation
-        const horizontalPadding = canReduce > 0 ? geometricPadding - canReduce : geometricPadding;
+        const extraPadding = canReduce > 0;


Can you address this one @borys3kk? I agree it should follow our boolean naming conventions. Something like:

Suggested change

const extraPadding = canReduce > 0;

const shouldUseExtraPadding = canReduce > 0;

puneetlath · 2026-02-10T15:37:19Z

src/components/Charts/LineChart/LineChartContent.tsx

        // Only reduce if both sides have excess space (labels short enough for 0°)
        // If canReduce <= 0, labels are too long and hook will use rotation/truncation
-        const horizontalPadding = canReduce > 0 ? geometricPadding - canReduce : geometricPadding;
+        const extraPadding = canReduce > 0;


canReduce is also a weird name for a non-boolean variable. It seems like it's a number we use in various places. Can we instead name that to be something that better explains what that number is.

puneetlath · 2026-02-10T15:37:51Z

src/components/Charts/LineChart/LineChartContent.tsx

+        const horizontalPadding = Math.max(extraPadding ? geometricPadding - canReduce : geometricPadding, MIN_SAFE_PADDING);

-        return {...BASE_DOMAIN_PADDING, left: horizontalPadding, right: horizontalPadding};
+        // if extraPadding is true then we have to add the extra padding to the right so the label is not clipped


Suggested change

// if extraPadding is true then we have to add the extra padding to the right so the label is not clipped

// If shouldUseExtraPadding is true then we have to add the extra padding to the right so the label is not clipped

mateuuszzzzz · 2026-02-11T12:58:26Z

@puneetlath I addressed remaining comments

puneetlath

Awesome, thank you! I like the new names, much clearer.

github-actions · 2026-02-11T16:16:23Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T16:20:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81669.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4b11f10-c84ed63408786622722d39194ea8bfa7fcbc3ff0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4b11f10-45fc56ea0b0435daad9274a71e514e3b76757883/index.html

Web 🕸️
https://81669.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-11T16:24:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-12T15:48:25Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-13T18:49:07Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix points clipping

036056f

melvin-bot bot assigned borys3kk Feb 6, 2026

fix label cut off / prettier

862069e

borys3kk marked this pull request as ready for review February 6, 2026 15:41

borys3kk requested review from a team as code owners February 6, 2026 15:41

melvin-bot bot requested review from JmillsExpensify and aimane-chnaif and removed request for a team February 6, 2026 15:41

melvin-bot bot requested review from a team and puneetlath and removed request for a team February 6, 2026 15:42

aimane-chnaif reviewed Feb 6, 2026

View reviewed changes

aimane-chnaif approved these changes Feb 6, 2026

View reviewed changes

puneetlath requested changes Feb 10, 2026

View reviewed changes

Address review comments

f691588

puneetlath approved these changes Feb 11, 2026

View reviewed changes

puneetlath merged commit 4b11f10 into Expensify:main Feb 11, 2026
29 checks passed

OSBotify mentioned this pull request Feb 12, 2026

Deploy Checklist: New Expensify 2026-02-12 #82262

Closed

melvin-bot bot mentioned this pull request Feb 13, 2026

[Due for payment 2026-02-20] [$250] Android - Reports - Data point is cut off at the edge in line chart #81611

Closed

7 tasks

aimane-chnaif mentioned this pull request Feb 20, 2026

feat: Add SearchLineChart component #81049

Merged

51 tasks

	const extraPadding = canReduce > 0;
	const shouldUseExtraPadding = canReduce > 0;

	// if extraPadding is true then we have to add the extra padding to the right so the label is not clipped
	// If shouldUseExtraPadding is true then we have to add the extra padding to the right so the label is not clipped

Conversation

borys3kk commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

aimane-chnaif commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

puneetlath Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puneetlath commented Feb 9, 2026

Uh oh!

mateuuszzzzz commented Feb 10, 2026

Uh oh!

puneetlath Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

puneetlath Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

puneetlath Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz commented Feb 11, 2026

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

borys3kk commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited by github-actions bot

Loading

aimane-chnaif commented Feb 6, 2026 •

edited

Loading

aimane-chnaif Feb 6, 2026 •

edited

Loading

mateuuszzzzz commented Feb 9, 2026 •

edited

Loading