Skip to content

Fix: Workspace - Approver user briefly reappears in member list after removal #81733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 10 commits into from
Mar 18, 2026
Merged

Fix: Workspace - Approver user briefly reappears in member list after removal #81733

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2ce6c26
fix: init
annaweber830 Feb 6, 2026
9fcd2e1
fix: prettier
annaweber830 Feb 6, 2026
5d4d733
fix: remove fix
annaweber830 Feb 8, 2026
bff1fce
fix: comment fix
annaweber830 Feb 8, 2026
c26358d
Merge branch 'main' of https://github.com/annaweber830/App into fix-8…
annaweber830 Feb 10, 2026
e27791b
fix: removemembers submit
annaweber830 Mar 9, 2026
87d2e63
Merge branch 'main' of https://github.com/annaweber830/App into fix-8…
annaweber830 Mar 9, 2026
5490481
fix: lint
annaweber830 Mar 9, 2026
eca0216
Merge branch 'main' of https://github.com/annaweber830/App into fix-8…
annaweber830 Mar 17, 2026
93fdaae
fix: validation member
annaweber830 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libs/actions/Policy/Member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
};

let allReportActions: OnyxCollection<ReportActions>;
Onyx.connect({

Check warning on line 46 in src/libs/actions/Policy/Member.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
waitForCollectionCallback: true,
callback: (actions) => (allReportActions = actions),
Expand Down Expand Up @@ -400,6 +400,9 @@
const employee = policy?.employeeList?.[employeeEmail];
optimisticMembersState[employeeEmail] = optimisticMembersState[employeeEmail] ?? {};
failureMembersState[employeeEmail] = failureMembersState[employeeEmail] ?? {};
if (employee?.email && selectedMemberEmails.includes(employee.email)) {
continue;
}
if (employee?.submitsTo && selectedMemberEmails.includes(employee?.submitsTo)) {
optimisticMembersState[employeeEmail] = {
...optimisticMembersState[employeeEmail],
Expand Down
Loading