Refactor convertBulkTrackedExpensesToIOU to accept transactions array…#81742
Refactor convertBulkTrackedExpensesToIOU to accept transactions array…#81742tgolen merged 8 commits intoExpensify:mainfrom
Conversation
… and filter undefined transactions
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 similar comment
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e48ca2d92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for (const transactionID of transactionIDs) { | ||
| const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]; | ||
| for (const transaction of transactions) { | ||
| const transactionID = transaction.transactionID; |
There was a problem hiding this comment.
Guard transaction before reading transactionID
This loop now dereferences transaction.transactionID before checking whether transaction exists, so a falsy entry will throw and abort the entire bulk-convert flow. That can happen because the caller builds this array from an Onyx collection and only filters out undefined values, while collection entries may be null during deletion/tombstone states. Please validate transaction before accessing its fields (or ensure the caller filters out both null and undefined).
Useful? React with 👍 / 👎.
|
No product review needed |
|
♻️ Reviewing this week... |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-02-16.at.17.09.20.mov |
|
This PR picked up conflicts, then I'll review. |
|
@parasharrajat Can you please fix the conflicts? Then I will review |
tgolen
left a comment
There was a problem hiding this comment.
Great, that looks good now. Thanks!
|
Bump @tgolen |
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.27-0 🚀
|
|
Deploy Blocker #83712 was identified to be related to this PR. |
|
Already created a PR for this. |
|
Deploy Blocker #83761 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Fixed Issues
$ #66510
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
12.02.2026_20.27.35_REC.mp4