Update customUnitRateID to _FAKE_P2P_ID_ when unreporting expense#81756
Update customUnitRateID to _FAKE_P2P_ID_ when unreporting expense#81756pecanoro merged 21 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Why this requested two C+ reviewers 😅 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33d145cccb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
It looks like @thesahindia is already working on this, so please unassign me from the issue. |
|
@s77rt for currencies other than USD, the default rate is showing correctly inside the expense view but the rate is different at the header and expense preview title Screen.Recording.2026-02-08.at.9.34.59.AM.mov |
|
@thesahindia Thanks! I think I will fix this in backend to update the currency/unit based on your personal policy then update this PR accordingly. I'm making this PR a draft for now. |
|
@thesahindia Can you give this a quick retest. The issue should be fixed now. However BE PR is not merged yet so the changes are only applied optimistically for now |
heyjennahay
left a comment
There was a problem hiding this comment.
Code change only. Product approval not required
|
@thesahindia Backend PR is deployed. Can you please give this another test/review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 460142a1bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Tests well! Could you review the comments and merge main? |
|
Resolved comments and merged main |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-25.at.3.48.25.PM.movAndroid: mWeb ChromeScreen.Recording.2026-02-25.at.4.24.01.PM.moviOS: HybridAppScreen.Recording.2026-02-25.at.8.05.13.PM.moviOS: mWeb SafariScreen.Recording.2026-02-25.at.8.03.22.PM.movMacOS: Chrome / SafariScreen.Recording.2026-02-25.at.3.24.10.PM.mov |
|
🎯 @thesahindia, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #83555. |
|
We have conflicts! |
|
Resolved |
|
I deleted an old comment with an incomplete checklist because the GH action was getting super confused |
|
🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.28-0 🚀
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
Explanation of Change
When a distance transaction is unreported:
customUnitID/customUnitRateIDto_FAKE_P2P_ID_to prevent "Rate out of policy" violation from being displayed.defaultP2PRateand update thedistanceUnit, thequantity, theamount, thecurrencyand themerchant-- Related PR: https://github.com/Expensify/Auth/pull/19783
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/597345
PROPOSAL:
Tests
RatefieldScreen.Recording.2026-02-06.at.11.52.51.PM.mov
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari