Refactor convertBulkTrackedExpensesToIOU to accept chatReport and iouReport#81757
Refactor convertBulkTrackedExpensesToIOU to accept chatReport and iouReport#81757tgolen merged 7 commits intoExpensify:mainfrom
Conversation
…Report as parameters
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 similar comment
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7671c0b320
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-02-16.at.17.09.20.mov |
| chatReport, | ||
| isASAPSubmitBetaEnabled, | ||
| currentUserAccountIDParam, | ||
| currentUserEmailParam, |
There was a problem hiding this comment.
🟡 NAB: Code Quality & Clean Code: Naming Convention (Nit)
Issue: The Param suffix is redundant when using named properties. It smells of legacy argument naming.
Suggestion: Rename these properties to currentUserAccountID and currentUserEmail for a cleaner API.
Example:
// src/libs/actions/IOU/index.ts
function convertBulkTrackedExpensesToIOU({
// ...
currentUserAccountID, // instead of currentUserAccountIDParam
currentUserEmail, // instead of currentUserEmailParam
// ...
})Co-authored-by: Kevin Brian Bader <56457735+ikevin127@users.noreply.github.com>
|
That was outdated. |
|
cc: @tgolen |
|
ESLint failures |
This reverts commit 6e67413.
|
Reverted the renamed param commit as there is a similar param with that name in the upper scope. Also that param is unrelated for the change here. We can update that later in other PRs when we will remove the currenuser personal details kep. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.22-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
Explanation of Change
Fixed Issues
$ #66517
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
12.02.2026_20.27.35_REC.mp4