fix: mWeb - Keyboard doesn't pop-up, when foreground the app using device menu button by TaduJR · Pull Request #81809 · Expensify/App

TaduJR · 2026-02-08T21:13:34Z

Explanation of Change

On Android mWeb (Chrome), the keyboard doesn't appear when returning from background via the device menu button, even though the input has focus.

Root cause: The existing keyboard restoration uses visibilitychange, which doesn't fire when using the device menu without switching apps. When it does fire (after switching apps), the immediate blur()/focus() fails because Android hasn't fully restored the window yet.

Fix: Replace the visibilitychange handler with a window.focus listener that blurs and refocuses with a 300ms delay (CONST.ANIMATED_TRANSITION), giving Android time to restore the window state. A module-level flag prevents FormProvider from triggering validation during the blur/focus cycle.

Fixed Issues

$ #75055
PROPOSAL: #75055 (comment)

Tests

Go to https://staging.new.expensify.com/
Open the Workspace with "Accounting" enabled
Tap "Accounting"
Tap "Connect" at NetSuite
Tap "Next" until reach NetSuite step 4
Tap the device menu button in the bottom navigation
Open other app
Repeat "step 6"
Tap in the chrome app
Repeat "step 6" 4 times
Repeat steps 1-10 using Expensify Android App
Verify When foreground the app using only the device menu button in the bottom navigation, cursor should be focused in the "NetSuite account ID" field and keyboard should pop-up.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

…vice menu button

melvin-bot · 2026-02-08T21:13:41Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-08T21:13:41Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2026-02-08T21:17:07Z

Code Review Summary

I've reviewed PR #81809 and identified the following issues:

Issues Found

1. [PERF-12] Memory leak risk (src/components/TextInput/index.tsx:51)
The nested setTimeout callbacks may execute after component unmount. Store timeout IDs and clear them in the cleanup function to prevent updating isRestoringKeyboardFocus after the component is destroyed.

2. [CONSISTENCY-2] Magic number (src/components/TextInput/index.tsx:54)
The hardcoded 100 ms timeout should be moved to a named constant (e.g., CONST.KEYBOARD_RESTORATION_BUFFER) to clarify its purpose.

3. [PERF-8] Module-level state concerns (src/components/TextInput/index.tsx:12)
Module-level mutable state (isRestoringKeyboardFocus) can cause issues when multiple TextInput instances are mounted simultaneously. If two inputs are being restored at once, this shared flag could interfere. Consider using a ref-based approach or a Set of refs to track restoration state per-instance.

4. [CONSISTENCY-5] Empty listener (src/components/TextInput/index.tsx:62)
The empty listener () => {} effectively disables the visibility change handler. Consider removing the Visibility.onVisibilityChange call entirely if it's no longer needed, or add a comment explaining why it's intentionally empty.

Positive Aspects

Good problem analysis and solution approach
Clear comments explaining the Android-specific behavior
Proper guard checks with isMobileChrome()
Test coverage appears comprehensive

Recommendations

Store and clear timeout IDs to prevent memory leaks
Move magic number to CONST
Consider per-instance state management instead of module-level flag
Clean up or document the empty visibility listener

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8af5c0718

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/TextInput/index.tsx

codecov · 2026-02-08T21:19:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.54% <ø> (ø)`
src/components/Form/FormProvider.tsx	`59.79% <0.00%> (ø)`
src/components/TextInput/index.native.tsx	`75.00% <0.00%> (-15.00%)`	⬇️
src/components/TextInput/index.tsx	`0.00% <0.00%> (ø)`
... and 26 files with indirect coverage changes

…mber

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

src/components/TextInput/index.tsx

src/components/Form/FormProvider.tsx

src/components/TextInput/index.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cee074552

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Form/FormProvider.tsx

truph01 · 2026-02-13T08:32:10Z

@TaduJR Could you please go through all the AI suggestions, react to each one with 👍 or 👎, and provide a brief explanation for your decision? Thanks!

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

TaduJR · 2026-02-13T13:58:34Z

#81809 (comment)

[PERF-12] Memory leak - nested setTimeout

👍 Valid addressed. Both timeouts are cleared and the flag is reset in the effect cleanup

[CONSISTENCY-2] Magic number 100ms

👍 Valid extracted as KEYBOARD_RESTORATION_FLAG_RESET_DELAY constant with a comment explaining the relationship to FormProvider's VALIDATE_DELAY.

[PERF-8] Module-level state concerns

👎 Not valid. Not applicable only one element can be document.activeElement at a time. The guard DomUtils.getActiveElement() !== textInputRef.current ensures only the actively focused input triggers restoration. Multiple inputs cannot interfere because only one can hold focus.

[CONSISTENCY-5] Empty listener

👍 Valid removed entirely along with the unused Visibility import and cleanup infrastructure."

TaduJR · 2026-02-13T14:06:36Z

@TaduJR Could you please go through all the AI suggestions, react to each one with 👍 or 👎, and provide a brief explanation for your decision? Thanks!

Done @truph01

TaduJR · 2026-03-04T10:10:22Z

Friendly Bump @truph01 when you have moment

Thanks!

src/components/TextInput/index.tsx

src/components/Form/FormProvider.tsx

truph01 · 2026-03-06T10:20:31Z

@TaduJR I have two comments. Also, could you merge main?

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

src/components/TextInput/index.tsx

truph01 · 2026-03-10T10:59:02Z

@TaduJR In your PR, you added the getIsRestoringKeyboardFocus logic to skip the validate action. However, this point is not mentioned in the OP, so it appears to be out of scope for this issue.

This PR should focus on syncing the focus state with the keyboard state.

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

… listener

TaduJR · 2026-03-10T11:56:38Z

@TaduJR In your PR, you added the getIsRestoringKeyboardFocus logic to skip the validate action. However, this point is not mentioned in the OP, so it appears to be out of scope for this issue.
This PR should focus on syncing the focus state with the keyboard state.

@truph01

The validation skip prevents a regression our fix introduces. The original visibilitychange blur was safe because document.hasFocus() is false at that point, so FormProvider skips validation automatically. The window.focus blur happens when document.hasFocus() is true by definition, which triggers validation showing errors on form inputs when returning from background. The flag is the minimal fix for this.

src/components/TextInput/index.tsx

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

… check

truph01 · 2026-03-15T15:21:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-15.at.22.20.10.mov

Android: mWeb Chrome

Screen.Recording.2026-03-15.at.22.19.01.mov

iOS: HybridApp

Screen.Recording.2026-03-15.at.22.14.00.mov

iOS: mWeb Safari

Screen.Recording.2026-03-15.at.22.12.11.mov

MacOS: Chrome / Safari

This platform doesn't have a keyboard.

github-actions · 2026-03-20T00:29:19Z

🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-20T00:33:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-20T00:33:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81809.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ef4ce16-c58bf3c-85a0504ac1e2c2261939f77ac30c28f0a9bcc461/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ef4ce16-c58bf3c-55f68a5cf836d8a8634336d73ef8dcc8bec35925/index.html

Web 🕸️
https://81809.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-23T09:49:54Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-24T11:45:37Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.42-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: mWeb - Keyboard doesn't pop-up, when foreground the app using de…

c8af5c0

…vice menu button

TaduJR requested review from a team as code owners February 8, 2026 21:13

melvin-bot bot assigned TaduJR Feb 8, 2026

melvin-bot bot requested review from trjExpensify and truph01 and removed request for a team February 8, 2026 21:13

chatgpt-codex-connector bot reviewed Feb 8, 2026

View reviewed changes

src/components/TextInput/index.tsx Show resolved Hide resolved

TaduJR marked this pull request as draft February 8, 2026 21:26

trjExpensify removed their request for review February 9, 2026 11:49

TaduJR added 4 commits February 10, 2026 01:11

fix: clear timeouts on unmount, guard stale refocus, extract magic nu…

6956b12

…mber

Merge branch 'main' of https://github.com/TaduJR/App into fix-mWeb-Ke…

6f9d40d

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

fix: restore validation skip comment in FormProvider

937dccd

Merge branch 'main' of https://github.com/TaduJR/App into fix-mWeb-Ke…

0cee074

…yboard-doesnt-pop-up-when-foreground-the-app-using-device-menu-button

TaduJR marked this pull request as ready for review February 10, 2026 07:13