refactor: Remove manual memoization from SettlementButton and add UI tests by TaduJR · Pull Request #81818 · Expensify/App

TaduJR · 2026-02-09T05:47:25Z

Explanation of Change

This PR addresses the first two goals of #79387: adding automated UI tests and removing manual memoization from SettlementButton.

Fixed Issues

$ #79387
PROPOSAL: #79387 (comment)

Tests

Prerequisites

Have a workspace with a verified business bank account connected
Have Expensify Wallet set up (Gold tier)
Have a second test account to send/receive payments
Have an invoice room set up between two accounts

Test 1 — Pay from Report Preview in Chat

Open a chat containing a submitted expense report preview card
Verify the Pay button on the preview card displays with the correct amount (e.g. "Pay $50.00")
Verify the subtitle below the button shows the correct payment method (e.g. bank last 4 digits or policy name)
Press the Pay button to open the dropdown
Verify the expected payment options appear (business bank account, "Mark as paid")
Verify no "Wallet" option appears for expense reports
Select a payment method and verify the payment processes
Verify the paid animation (checkmark) plays after successful payment

Test 2 — Pay from Report Header

Open the full expense report view (tap into the report from the chat)
Verify the Pay button displays correctly in the header with the correct amount
Press the Pay button dropdown and verify the payment options appear
If an Approve option appears inside the dropdown, verify tapping it changes the report status
Select "Mark as paid" and verify the payment completes
Verify the paid animation (checkmark) plays after successful payment

Test 3 — Invoice Room (Regression for #80189)

Create or open an invoice room with an individual receiver
Verify the app does NOT freeze or hang when the invoice room loads
Verify the Pay button renders correctly on the invoice
Press the Pay button and verify the dropdown shows two options:
- "Pay $X.XX as an individual" (opens submenu with personal bank accounts, "Add bank account", and "Mark as paid")
- "Pay $X.XX as a business" (opens submenu with business bank accounts, "Add bank account", and "Mark as paid")
Verify no workspace is created automatically — check Settings > Workspaces for unexpected new workspaces
Repeat with a business invoice room:
- Verify payment options show directly as a flat list (business bank accounts, "Add bank account", "Mark as paid") without the individual/business split
- Verify only fully verified bank accounts appear (partially setup ones should not)

Test 4 — Search Results

Navigate to the Search tab
Find unpaid expenses/IOUs in the results
Verify the compact "Pay" button appears (just "Pay", no amount shown)
Press the Pay button and verify the dropdown options appear
Select a payment method and verify the payment processes

Test 5 — Pay Someone (Quick Action)

Open a DM chat with another user
Tap the "Pay someone" quick action
Enter an amount on the amount screen
Verify the Pay button appears directly on the amount screen (not a "Next" button)
Verify payment method options are available in the dropdown (Wallet, personal bank account, "Mark as paid")
Select a payment method and verify the payment completes

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native-1.mp4

Android-Native-2.mp4

Android: mWeb Chrome

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome-1.mp4

Mac-Chrome-2.mp4

melvin-bot · 2026-02-09T05:47:32Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-02-09T06:07:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SettlementButton/index.tsx	`86.50% <87.93%> (+86.50%)`	⬆️
... and 23 files with indirect coverage changes

…up-SettlementButton

src/components/SettlementButton/index.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 843ae81054

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/SettlementButton/index.tsx

…Button

linhvovan29546 · 2026-02-11T10:25:52Z

I’ll review this based on the discussion in Slack

linhvovan29546 · 2026-02-11T11:09:54Z

Ah, it looks like @roryabraham wants to review this PR instead of assigning it to C+, since you reviewed the original one as well.

thesahindia · 2026-02-11T15:24:17Z

Ah, it looks like @roryabraham wants to review this PR instead of assigning it to C+, since you reviewed the original one as well.

Apologies 😓 I didn't look into it before posting.

…up-SettlementButton

roryabraham · 2026-02-18T00:31:00Z

@linhvovan29546 can you please review this PR?

linhvovan29546 · 2026-02-18T07:14:39Z

Reviewing...

linhvovan29546

getPaymentSubItems and paymentButtonOptions are not automatically memoized after applying this check. Could you please re-check? I used react complier playground(and react-compiler-marker extension) tool to verify the auto memoization

roryabraham

Generally I think the pattern of defining a function in render to generate some object, then calling it once in render to generate that object is a bad practice in React Compiler world.

Because you're obfuscating the logic and wrapping it up into an unnecessary function that's called only once. If you instead inline the content of the function in render, I think React Compiler will do a better job memoizing it. The code tends to end up simpler too.

…up-SettlementButton

tests/ui/components/SettlementButtonTest.tsx

linhvovan29546 · 2026-02-20T13:39:23Z

I'm blocked by this bug. I'll test the PR once it's resolved.

linhvovan29546 · 2026-02-21T10:36:46Z

@TaduJR Please add videos to the PR description. These tests are easy to record and attach.

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

TaduJR · 2026-02-25T14:25:05Z

NAB: Please extract getPolicyID outside getInvoicesOptions to avoid redefining it on every call. Defining it in the outer scope ensures it's created only once per render.

Done.

Please update the PR title to match the guidelines

Done.

linhvovan29546 · 2026-02-26T10:04:09Z

@TaduJR #81818 (comment)

TaduJR · 2026-02-26T11:46:53Z

@linhvovan29546

I am having difficulties setting up VBBA.

Raised a discussion here https://expensify.slack.com/archives/C01GTK53T8Q/p1772106257184279?thread_ts=1711049879.962529&cid=C01GTK53T8Q

Feel free to reply if you have any suggestions.

Thanks!

linhvovan29546 · 2026-02-26T12:14:50Z

Feel free to reply if you have any suggestions.

I’ve replied. Could you merge main and resolve the conflicts?

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

TaduJR · 2026-02-27T09:51:47Z

@TaduJR Please add videos to the PR description. These tests are easy to record and attach.

Done.

linhvovan29546 · 2026-02-27T10:01:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-27.at.17.17.55.mov

Android: mWeb Chrome

Screen.Recording.2026-02-27.at.17.13.42.mov

iOS: HybridApp

Screen.Recording.2026-02-27.at.17.07.15.mov

iOS: mWeb Safari

Screen.Recording.2026-02-27.at.17.03.13.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-27.at.16.58.11.mov

Screen.Recording.2026-02-27.at.17.00.58.mov

linhvovan29546

The metric in this PR looks better than the one in main.

roryabraham · 2026-02-27T16:54:12Z

@TaduJR looks like we've got some conflicts

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

TaduJR · 2026-02-27T17:56:03Z

@TaduJR looks like we've got some conflicts

Done.

OSBotify · 2026-03-02T18:12:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T18:41:46Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-02T18:47:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81818.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c75239a-1c9ede1-0b5652789c26dac753560e005e5f9906e53d2ec6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c75239a-1c9ede1-4e777df7d163b37cd3aa75bcaef2456a4b7954e0/index.html

Web 🕸️
https://81818.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:01:38Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-03-03T09:58:32Z

Hi @TaduJR. QA team doesn't have a Gold tier.
Will it be enough to enable it in the Wallet?

cc @roryabraham

linhvovan29546 · 2026-03-03T10:04:20Z

@IuliiaHerets We don’t need the Gold tier

OSBotify · 2026-03-04T03:16:26Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:06:47Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

test: Clean up SettlementButton

478cdf2

TaduJR requested review from a team as code owners February 9, 2026 05:47

melvin-bot bot assigned TaduJR Feb 9, 2026

melvin-bot bot requested review from JmillsExpensify and thesahindia and removed request for a team and JmillsExpensify February 9, 2026 05:47

melvin-bot bot removed the request for review from a team February 9, 2026 05:47

TaduJR marked this pull request as draft February 9, 2026 06:52

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

843ae81

…up-SettlementButton

TaduJR marked this pull request as ready for review February 10, 2026 16:16

github-actions bot reviewed Feb 10, 2026

View reviewed changes

src/components/SettlementButton/index.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

src/components/SettlementButton/index.tsx Outdated Show resolved Hide resolved

chore: convert function declarations to arrow functions in Settlement…

eb57c99

…Button

kacper-mikolajczak mentioned this pull request Feb 16, 2026

[AI Reviewer] Rule improvement: PERF-6 #82526

Closed

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

dffaa67

…up-SettlementButton

roryabraham requested review from linhvovan29546 and removed request for thesahindia February 18, 2026 00:31

linhvovan29546 suggested changes Feb 18, 2026

View reviewed changes

roryabraham reviewed Feb 18, 2026

View reviewed changes

TaduJR added 2 commits February 19, 2026 09:31

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

31bcaa7

…up-SettlementButton

fix: Inline single-call functions for React Compiler memoization

4c93ec0

linhvovan29546 suggested changes Feb 20, 2026

View reviewed changes

tests/ui/components/SettlementButtonTest.tsx Outdated Show resolved Hide resolved

TaduJR added 2 commits February 25, 2026 17:14

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

a18cd7f

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

refactor: Scope invoice functions and use ComposeProviders in tests

e815fb6

TaduJR changed the title ~~test: Clean up SettlementButton~~ refactor: Remove manual memoization from SettlementButton and add UI tests Feb 25, 2026

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

423a97e

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

linhvovan29546 approved these changes Feb 27, 2026

View reviewed changes

melvin-bot bot requested a review from roryabraham February 27, 2026 10:42

Merge branch 'main' of https://github.com/TaduJR/App into test-Clean-…

457075d

…up-SettlementButton # Conflicts: # src/components/SettlementButton/index.tsx

roryabraham approved these changes Mar 2, 2026

View reviewed changes

roryabraham merged commit c75239a into Expensify:main Mar 2, 2026
29 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

linhvovan29546 mentioned this pull request Mar 18, 2026

fix: remove onyx connect ONYXKEYS.NVP_PRIVATE_OWNER_BILLING_GRACE_PERIOD_END (part 3) #84293

Merged

53 tasks

Conversation

TaduJR commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 9, 2026

Uh oh!

codecov bot commented Feb 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

linhvovan29546 commented Feb 11, 2026

Uh oh!

linhvovan29546 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thesahindia commented Feb 11, 2026

Uh oh!

roryabraham commented Feb 18, 2026

Uh oh!

linhvovan29546 commented Feb 18, 2026

Uh oh!

linhvovan29546 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linhvovan29546 commented Feb 20, 2026

Uh oh!

linhvovan29546 commented Feb 21, 2026

Uh oh!

TaduJR commented Feb 25, 2026

Uh oh!

linhvovan29546 commented Feb 26, 2026

Uh oh!

TaduJR commented Feb 26, 2026

Uh oh!

linhvovan29546 commented Feb 26, 2026

Uh oh!

TaduJR commented Feb 27, 2026

Uh oh!

linhvovan29546 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Feb 27, 2026

Uh oh!

TaduJR commented Feb 27, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

IuliiaHerets commented Mar 3, 2026

TaduJR commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited by github-actions bot

Loading

linhvovan29546 commented Feb 11, 2026 •

edited

Loading

linhvovan29546 left a comment •

edited

Loading

roryabraham left a comment •

edited

Loading

linhvovan29546 commented Feb 27, 2026 •

edited

Loading

linhvovan29546 left a comment •

edited

Loading