Use Send icon for Submit in Reports/Search page by MobileMage · Pull Request #81915 · Expensify/App

MobileMage · 2026-02-10T00:18:53Z

Explanation of Change

The Submit action used different icons on the Home page (Send/paper plane icon) vs the Reports/Search page (Pencil icon). This updates the Reports/Search page to use the Send icon, matching the Home page and the AnimatedSubmitButton.

Changes:

src/libs/SearchUIUtils.ts: Changed icon from Pencil to Send in type signatures and usage
src/hooks/useSearchTypeMenuSections.ts: Updated lazy icon loader from Pencil to Send

Fixed Issues

$ #81398
PROPOSAL: #81398 (comment)

Tests

Navigate to the Home page
Observe the icon next to "Submit X report" in the For You section — it should be the Send (paper plane) icon
Navigate to the Reports page
Observe the icon next to "Submit" in the left sidebar — it should now also be the Send (paper plane) icon
Verify both icons match

Verify that no errors appear in the JS console

Offline tests

Go offline
Navigate to the Reports page
Verify the Submit icon still displays as the Send (paper plane) icon

QA Steps

Navigate to the Home page and note the Submit icon (paper plane)
Navigate to the Reports page and note the Submit icon in the sidebar
Verify both pages use the same Send (paper plane) icon for Submit

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The Submit action used the Pencil icon on the Reports/Search page but the Send icon on the Home page. Update SearchUIUtils and the hook to use the Send icon consistently, matching the Home page and the AnimatedSubmitButton. Fixes Expensify#81398

melvin-bot · 2026-02-10T00:19:00Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-10T00:19:05Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-10T00:21:07Z

Code Review Complete ✅

I've performed a comprehensive inline review of all code changes in this PR.

Review Summary:

✅ No issues found - All changes are correct and consistent
✅ Type safety - TypeScript signatures properly updated
✅ Completeness - All relevant icon references updated from Pencil to Send
✅ Correctness - Other Pencil icon usage (for renaming saved searches) correctly left unchanged

Files Reviewed:

src/hooks/useSearchTypeMenuSections.ts - Icon loader updated
src/libs/SearchUIUtils.ts - Type signatures and icon reference updated

The icon change from Pencil to Send is properly implemented across all necessary locations. The PR is ready for merge.

QichenZhu

@MobileMage, could you fix the types, complete the checklist, and add screenshots? Thanks!

MobileMage · 2026-02-10T09:33:54Z

@QichenZhu The Submit/Pencil icon only appears in the search type menu sidebar, which is a desktop-only panel. On mobile, that sidebar is either hidden or only partially visible via the hamburger menu, and the specific menu items with our icon aren't shown there.

QichenZhu · 2026-02-10T09:50:18Z

@MobileMage, could you clarify what you mean by partially visible? From what I can see, the hamburger menu on mobile has the same icons as desktop.

MobileMage · 2026-02-10T10:09:40Z

It doesn't expose the icon we changed

QichenZhu · 2026-02-10T10:14:29Z

@MobileMage I see the Reports page is empty. Please create a few draft reports for testing.

MobileMage · 2026-02-10T11:45:31Z

Thanks @QichenZhu , I've fixed these

trjExpensify

Discovered via Home project and being updated for consistency. 👍 CC: @Expensify/design for vis!

shawnborton · 2026-02-10T20:01:58Z

Send it!

chuckdries

chuckdries · 2026-02-10T21:54:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chuckdries

take two

github-actions · 2026-02-10T21:58:26Z

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-10T22:05:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81915.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-24df0d5-89b095592782095d313b6ce2e38f89cad7947b2e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-24df0d5-99ea5842b5481e21253afb243204b7aef48418c7/index.html

Web 🕸️
https://81915.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-10T22:09:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-11T06:55:31Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-12T15:24:51Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

MobileMage requested review from a team as code owners February 10, 2026 00:18

melvin-bot bot assigned MobileMage Feb 10, 2026

melvin-bot bot requested review from a team, QichenZhu and trjExpensify and removed request for a team February 10, 2026 00:18

melvin-bot bot requested review from chuckdries and removed request for a team February 10, 2026 00:19

QichenZhu suggested changes Feb 10, 2026

View reviewed changes

Fix test type errors: update Pencil to Send in SearchUIUtilsTest

be2c472

trjExpensify approved these changes Feb 10, 2026

View reviewed changes

chuckdries approved these changes Feb 10, 2026

View reviewed changes

chuckdries merged commit 24df0d5 into Expensify:main Feb 10, 2026
30 of 33 checks passed

OSBotify mentioned this pull request Feb 11, 2026

Deploy Checklist: New Expensify 2026-02-11 #82079

Closed

Conversation

MobileMage commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 10, 2026

Uh oh!

melvin-bot bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Code Review Complete ✅

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

MobileMage commented Feb 10, 2026

Uh oh!

QichenZhu commented Feb 10, 2026

Uh oh!

MobileMage commented Feb 10, 2026

Uh oh!

QichenZhu commented Feb 10, 2026

Uh oh!

MobileMage commented Feb 10, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Feb 10, 2026

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Feb 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MobileMage commented Feb 10, 2026 •

edited

Loading